Force global atrributes to be declared for every cluster in MatterIDL #24951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Feb 9, 2023
tehampson
approved these changes
Feb 9, 2023
emargolis
approved these changes
Feb 9, 2023
|
PR #24951: Size comparison from 11c0cdf to ea10d7e Full report (1 build for cc32xx)
|
pullapprove
bot
requested review from
amitnj,
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jmeg-sfy
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
pjzander-signify,
saurabhst,
selissia,
tecimovic,
vijs and
xylophone21
|
PR #24951: Size comparison from 36735ed to a9d9294 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
|
This does not seem to work - java read callback paths do not actually take into consideration that some things are just hard-coded and as a result we do not codegen the underlying types in CHIPReadCallbacks.h / CHIPReadCallbacks.cpp . Hardcoding into matter files makes more things available to the python codegen and results in build errors. Commenting out the event list was not sufficient. |
|
Updated PR: created a script to ensure all the mandatory attributes are enabled for all clusters. |
|
PR #24951: Size comparison from 36735ed to 61f3e1d Full report (2 builds for cc32xx, mbed)
|
bzbarsky-apple
approved these changes
Feb 10, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…project-chip#24951) * Update IDL tempalte: force a fixed set of global attributes * Ran zap regen * Regen and fix some odd UFT8 wrong values * Comment out eventList from matter as ZAP global resposes does NOT yet seem to return this list. * Zap regen * Ensure acceptedcommandlist is available in ALL clusters * Zap regen * Add generated command list as well * Zap regen * Marking AttributeList as included for several clusters * Zap regen * Add EventList to all clusters * zap regen * Zap regen: re-enable event list attribute --------- Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spect section
7.13 Global Elementsdescribes a set of elements that are mandatory for every cluster to have.Fixes #24947 for the matter IDL bits (although java may still depend on zap, where handling seems to need specialization)
It also turns out that both JAVA and PYTHON rely on zap templating to have global attributes enabled. As a result I updated controller_clusters.zap to enable mandatory attributes (a lot of event list adding, some adding/enabling for a few other clusters). This resulted in java and python generated code updates.