-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path filter patterns for doxygen workflow #24944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chip-build-doxygen image does not contain node binary. Retry is not required for docygen workflow because it is can be run manually anyway.
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
February 9, 2023 13:24
pullapprove
bot
requested review from
LuDuda,
mlepage-google,
msandstedt,
mspang,
pjzander-signify,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 9, 2023 13:24
PR #24944: Size comparison from a55b245 to 7667561 Increases (1 build for cc32xx)
Decreases (1 build for k32w)
Full report (10 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
|
bzbarsky-apple
approved these changes
Feb 9, 2023
yufengwangca
approved these changes
Feb 11, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Fix regexp paths for doxygen workflow * Do not use wretry.action for doxygen workflow The chip-build-doxygen image does not contain node binary. Retry is not required for docygen workflow because it is can be run manually anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Doxygen workflow uses incorrect filtering path syntax:
https://github.com/arkq/connectedhomeip/actions/runs/4134131824
Changes
+
characters in the path filters stringsTesting
Tested on local fork - files like
foo.c++
correctly trigger this workflow now (such files are not available in the repo, though)