Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path filter patterns for doxygen workflow #24944

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Feb 9, 2023

Problem

Doxygen workflow uses incorrect filtering path syntax:

https://github.com/arkq/connectedhomeip/actions/runs/4134131824

[Error: .github#L1](https://github.com/arkq/connectedhomeip/commit/d3f33230343e59071ee6e02d0ed5b5834ed71249#annotation_8721928396)
push event contained invalid paths patterns: the following globs were invalid: **.c++, **.i++, **.h++, pull_request event contained invalid paths patterns: the following globs were invalid: **.c++, **.i++, **.h++

Changes

  • escape + characters in the path filters strings
  • do not use wretry for checkout - the chip-build-doxygen image does not contain node binary (doxygen workflow is run manually, retry is not required)

Testing

Tested on local fork - files like foo.c++ correctly trigger this workflow now (such files are not available in the repo, though)

arkq added 2 commits February 9, 2023 13:51
The chip-build-doxygen image does not contain node binary. Retry is not
required for docygen workflow because it is can be run manually anyway.
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

PR #24944: Size comparison from a55b245 to 7667561

Increases (1 build for cc32xx)
platform target config section a55b245 7667561 change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 20194394 20194395 1 0.0
Decreases (1 build for k32w)
platform target config section a55b245 7667561 change % change
k32w contact k32w0+release (read/write) 660124 660108 -16 -0.0
.text 562340 562324 -16 -0.0
Full report (10 builds for cc32xx, k32w, mbed, nrfconnect, qpg)
platform target config section a55b245 7667561 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 640233 640233 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928439 928439 0 0.0
.debug_aranges 87352 87352 0 0.0
.debug_frame 299840 299840 0 0.0
.debug_info 20194394 20194395 1 0.0
.debug_line 2649797 2649797 0 0.0
.debug_loc 2785922 2785922 0 0.0
.debug_ranges 280720 280720 0 0.0
.debug_str 3001474 3001474 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105585 105585 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375840 375840 0 0.0
.symtab 255856 255856 0 0.0
.text 532524 532524 0 0.0
k32w contact k32w0+release (read/write) 660124 660108 -16 -0.0
.bss 76560 76560 0 0.0
.data 2112 2112 0 0.0
.text 562340 562324 -16 -0.0
light k32w0+release (read/write) 672368 672368 0 0.0
.bss 74344 74344 0 0.0
.data 2064 2064 0 0.0
.text 593232 593232 0 0.0
lock k32w0+release (read/write) 631760 631760 0 0.0
.bss 75112 75112 0 0.0
.data 2084 2084 0 0.0
.text 551836 551836 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464576 2464576 0 0.0
.bss 215892 215892 0 0.0
.data 5880 5880 0 0.0
.text 1427220 1427220 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1162364 1162364 0 0.0
bss 143531 143531 0 0.0
rodata 134376 134376 0 0.0
text 804572 804572 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108392 1108392 0 0.0
bss 142687 142687 0 0.0
rodata 111364 111364 0 0.0
text 774564 774564 0 0.0
all-clusters-app nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1367600 1367600 0 0.0
bss 105990 105990 0 0.0
rodata 211808 211808 0 0.0
text 764276 764276 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148688 1148688 0 0.0
.bss 99876 99876 0 0.0
.data 848 848 0 0.0
.text 595788 595788 0 0.0
lock-app qpg6105+debug (read/write) 1116736 1116736 0 0.0
.bss 96396 96396 0 0.0
.data 860 860 0 0.0
.text 563832 563832 0 0.0

@yufengwangca yufengwangca merged commit 4895dc6 into project-chip:master Feb 11, 2023
@arkq arkq deleted the doxygen-workflow-fix branch February 13, 2023 09:06
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
* Fix regexp paths for doxygen workflow

* Do not use wretry.action for doxygen workflow

The chip-build-doxygen image does not contain node binary. Retry is not
required for docygen workflow because it is can be run manually anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants