Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop requiring openssl to bootstrap. #24901

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Stop requiring openssl to bootstrap. #24901

merged 2 commits into from
Feb 8, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Feb 7, 2023 •
edited
Loading

Bootstrap seems to do something with chip_crypto as part ofthe bootstrap process. Have it use the already-available boringssl for that instead of requiring an external openssl.

Fixes #24897

@bzbarsky-apple
Stop requiring openssl to bootstrap.
4e98092 
Bootstrap seems to do something with chip_crypto as part ofthe bootstrap
process.  Have it use the already-available boringssl for that instead of
requiring an external openssl.

Fixes project-chip#24897
@pullapprove pullapprove bot removed the scripts label Feb 7, 2023
@pullapprove pullapprove bot requested a review from vijs February 7, 2023 14:37
@pullapprove pullapprove bot added the scripts label Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

PR #24901: Size comparison from 382bea4 to 4e98092

Full report (1 build for cc32xx)
platform target config section 382bea4 4e98092 change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 639725 639725 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928401 928401 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 299792 299792 0 0.0
.debug_info 19915393 19915393 0 0.0
.debug_line 2646819 2646819 0 0.0
.debug_loc 2781044 2781044 0 0.0
.debug_ranges 280656 280656 0 0.0
.debug_str 2978585 2978585 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105269 105269 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375623 375623 0 0.0
.symtab 255664 255664 0 0.0
.text 532332 532332 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 7, 2023

PR #24901: Size comparison from 382bea4 to 5bff78b

Decreases (1 build for cc32xx)
platform target config section 382bea4 5bff78bd change % change
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19915393 19915392 -1 -0.0
Full report (1 build for cc32xx)
platform target config section 382bea4 5bff78bd change % change
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 639725 639725 0 0.0
(read/write) 204084 204084 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197488 197488 0 0.0
.comment 194 194 0 0.0
.data 1476 1476 0 0.0
.debug_abbrev 928401 928401 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 299792 299792 0 0.0
.debug_info 19915393 19915392 -1 -0.0
.debug_line 2646819 2646819 0 0.0
.debug_loc 2781044 2781044 0 0.0
.debug_ranges 280656 280656 0 0.0
.debug_str 2978585 2978585 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105269 105269 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 375623 375623 0 0.0
.symtab 255664 255664 0 0.0
.text 532332 532332 0 0.0

@bzbarsky-apple bzbarsky-apple mentioned this pull request Feb 8, 2023
Closed
@yufengwangca yufengwangca merged commit 8dc253c into project-chip:master Feb 8, 2023
@bzbarsky-apple bzbarsky-apple deleted the bootstrap-no-openssl branch February 8, 2023 16:12
lpbeliveau-silabs pushed a commit to lpbeliveau-silabs/connectedhomeip that referenced this pull request Feb 13, 2023
@bzbarsky-apple @lpbeliveau-silabs
Stop requiring openssl to bootstrap. (project-chip#24901)
30b11c3 
* Stop requiring openssl to bootstrap.

Bootstrap seems to do something with chip_crypto as part ofthe bootstrap
process.  Have it use the already-available boringssl for that instead of
requiring an external openssl.

Fixes project-chip#24897

* Also fix the no-cipd bootstrap.
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Stop requiring openssl to bootstrap. (project-chip#24901)
438e3f7 
* Stop requiring openssl to bootstrap.

Bootstrap seems to do something with chip_crypto as part ofthe bootstrap
process.  Have it use the already-available boringssl for that instead of
requiring an external openssl.

Fixes project-chip#24897

* Also fix the no-cipd bootstrap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy31415 andy31415 andy31415 approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS project is not compiling "No package 'openssl' found"
6 participants
@bzbarsky-apple @tcarmelveilleux @andy31415 @yunhanw-google @yufengwangca @jmartinez-silabs