-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: Pass event timestamp to MTRDeviceDelegate #24858
Merged
jtung-apple
merged 8 commits into
project-chip:master
from
jtung-apple:jtung/issue-24711-darwin-event-timestamp
Feb 10, 2023
Merged
Darwin: Pass event timestamp to MTRDeviceDelegate #24858
jtung-apple
merged 8 commits into
project-chip:master
from
jtung-apple:jtung/issue-24711-darwin-event-timestamp
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
February 3, 2023 20:42
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 3, 2023 20:42
PR #24858: Size comparison from 1832750 to d8f27e3 Increases (5 builds for cc13x2_26x2, esp32, telink)
Decreases (6 builds for bl702, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24858: Size comparison from 1832750 to 239af08 Increases above 0.2%:
Increases (10 builds for cc13x2_26x2, linux, psoc6, telink)
Decreases (4 builds for bl702, cyw30739, esp32, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 4, 2023
Co-authored-by: Boris Zbarsky <[email protected]>
PR #24858: Size comparison from 1832750 to 9a062f2 Increases above 0.2%:
Increases (12 builds for bl602, cc13x2_26x2, linux, psoc6, telink)
Decreases (4 builds for esp32, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Feb 6, 2023
yunhanw-google
approved these changes
Feb 9, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Darwin: Pass event timestamp to MTRDeviceDelegate Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds event number, event priority, and event time to event reports with MTRDevice.
Fixes #24711