Fix timestamps in Diagnostic Logs cluster to follow the spec. #24830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mrjerryjohns
bzbarsky-apple
force-pushed
the
fix-diagnostic-logs-timestamps
branch
from
fef3749 to
b7b1af2
Compare
woody-apple
approved these changes
Feb 2, 2023
bzbarsky-apple
force-pushed
the
fix-diagnostic-logs-timestamps
branch
from
b7b1af2 to
a9717a8
Compare
andy31415
reviewed
Feb 2, 2023
andy31415
approved these changes
Feb 2, 2023
jtung-apple
approved these changes
Feb 2, 2023
msandstedt
approved these changes
Feb 2, 2023
|
PR #24830: Size comparison from c3a5b9e to 94c68f8 Increases above 0.2%:
Increases (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl702, cc13x2_26x2, psoc6)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
auto-merge was automatically disabled
February 2, 2023 22:24
Pull request was converted to draft
jmeg-sfy
reviewed
Feb 9, 2023
There were a few issues here: 1. We were using a monotonic timestamp, but setting the UTCTimeStamp in the response payload. 2. We were using a millisecond timestamp, whereas the spec has microsecond ones. Switch to using "time since server init" for the timestamp, put it in the TimeSinceBoot field, and make sure it has the right units. Also fixes the timestamps to actually be optional, per spec. Fixes project-chip#24265
bzbarsky-apple
force-pushed
the
fix-diagnostic-logs-timestamps
branch
from
94c68f8 to
1bc5e35
Compare
|
PR #24830: Size comparison from e497117 to 1bc5e35 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…t-chip#24830) * Fix timestamps in Diagnostic Logs cluster to follow the spec. There were a few issues here: 1. We were using a monotonic timestamp, but setting the UTCTimeStamp in the response payload. 2. We were using a millisecond timestamp, whereas the spec has microsecond ones. Switch to using "time since server init" for the timestamp, put it in the TimeSinceBoot field, and make sure it has the right units. Also fixes the timestamps to actually be optional, per spec. Fixes project-chip#24265 * Address review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few issues here:
We were using a monotonic timestamp, but setting the UTCTimeStamp in the response payload.
We were using a millisecond timestamp, whereas the spec has microsecond ones.
Switch to using "time since server init" for the timestamp, put it in the TimeSinceBoot field, and make sure it has the right units.
Also fixes the timestamps to actually be optional, per spec.
Fixes #24265