-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability for OperationalSessionSetup to retry a few times automatically. #24808
Merged
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:case-automatic-reattempts
Feb 2, 2023
Merged
Add the ability for OperationalSessionSetup to retry a few times automatically. #24808
woody-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:case-automatic-reattempts
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
February 2, 2023 02:29
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
February 2, 2023 02:29
PR #24808: Size comparison from 1ba581b to 4085341 Increases (25 builds for esp32, linux, nrfconnect, telink)
Decreases (12 builds for esp32, nrfconnect, telink)
Full report (25 builds for esp32, linux, nrfconnect, telink)
|
bzbarsky-apple
force-pushed
the
case-automatic-reattempts
branch
from
February 2, 2023 04:12
4085341
to
e6aa58f
Compare
PR #24808: Size comparison from 6f041ac to e6aa58f Increases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
…matically. The basic idea is that if CASE establishment fails we try again, after a brief backoff.
bzbarsky-apple
force-pushed
the
case-automatic-reattempts
branch
from
February 2, 2023 07:02
e6aa58f
to
77ee378
Compare
PR #24808: Size comparison from cd919db to 77ee378 Increases (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Feb 2, 2023
woody-apple
approved these changes
Feb 2, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…matically. (project-chip#24808) The basic idea is that if CASE establishment fails we try again, after a brief backoff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic idea is that if CASE establishment fails we try again, after a brief backoff.
Also aligns all logging in OperationalSessionSetup to be Discovery, not Controller (it was a mix of the two).