-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make OperationalSessionSetup a bit smaller. #24805
Merged
yufengwangca
merged 1 commit into
project-chip:master
from
bzbarsky-apple:smaller-session-setup
Feb 2, 2023
Merged
Make OperationalSessionSetup a bit smaller. #24805
yufengwangca
merged 1 commit into
project-chip:master
from
bzbarsky-apple:smaller-session-setup
Feb 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mrjerryjohns
February 1, 2023 23:43
pullapprove
bot
requested review from
msandstedt,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
turon and
vijs
February 1, 2023 23:43
pullapprove
bot
requested review from
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
February 1, 2023 23:43
PR #24805: Size comparison from 54b2461 to aed58bc Increases (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
Decreases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cliffamzn
approved these changes
Feb 2, 2023
jtung-apple
approved these changes
Feb 2, 2023
jmartinez-silabs
approved these changes
Feb 2, 2023
We had two one-byte values, each of which was taking up 4-8 bytes (depending on target arch). Putting them next to each other packs better.
bzbarsky-apple
force-pushed
the
smaller-session-setup
branch
from
February 2, 2023 04:06
aed58bc
to
ba140cd
Compare
PR #24805: Size comparison from 6f041ac to ba140cd Increases (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, psoc6, qpg, telink)
Decreases (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Feb 2, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
We had two one-byte values, each of which was taking up 4-8 bytes (depending on target arch). Putting them next to each other packs better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two one-byte values, each of which was taking up 4-8 bytes (depending on target arch). Putting them next to each other packs better.