Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a method to send the NOC with CATs when pairing devices #24774

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Add a method to send the NOC with CATs when pairing devices #24774

merged 3 commits into from
Feb 2, 2023

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Feb 1, 2023 •
edited
Loading

Problem

We always send the NOC without CATs when we are pairing the devices. We should have a method to set the CATs attribute of the NOC sent to the commissionee.

Solution

  • Add interface for setting CATs in ExampleOperationalCredentialsIssuer
  • Add CATs to commissioning parameters

Test

# pairing the light
./chip-tool pairing ble-wifi 1 ssid password 20202021 3840

# pairing the light switch with CATs 
./chip-tool pairing ble-wifi 2 ssid password 20202021 3840 --case-auth-tags 0xABCD0001,0xDCBA0002

# binding the light the the switch
./chip-tool binding write binding '[{"fabricIndex": 1, "node":1, "endpoint":1, "cluster":6}]' 2 1

# the control should fail since the switch does not have the access for light

# add the CAT to the ACL of the light
./chip-tool accesscontrol write acl '[{"fabricIndex": 1, "privilege": 5, "authMode": 2, "subjects": [112233, 18446744063706988545], "targets":null}]' 1 0

# the control should success now

@pullapprove pullapprove bot requested a review from saurabhst February 1, 2023 03:35
@github-actions
Copy link

github-actions bot commented Feb 1, 2023 •
edited
Loading

PR #24774: Size comparison from 8dc9323 to a2fa000

Increases (8 builds for bl602, bl702, esp32, linux, psoc6, telink)
platform target config section 8dc9323e a2fa000 change % change
bl602 lighting-app bl602+rpc .text 1053458 1053460 2 0.0
bl702 lighting-app bl702 .debug_info 40197532 40197533 1 0.0
.text 951562 951564 2 0.0
esp32 all-clusters-app m5stack (read/write) 497823 497827 4 0.0
.flash.rodata 248900 248904 4 0.0
linux chip-tool-ipv6only arm64 (read only) 11063484 11065236 1752 0.0
(read/write) 704776 704792 16 0.0
.data.rel.ro 648200 648216 16 0.0
.rodata 576284 576372 88 0.0
.text 8814244 8815860 1616 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27506003 27506004 1 0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27063754 27063755 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22711597 22711598 1 0.0
telink lighting-app tlsr9518adk80d text 658298 658300 2 0.0
Decreases (8 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
platform target config section 8dc9323e a2fa000 change % change
bl702 lighting-app bl702+rpc .debug_info 44594117 44594116 -1 -0.0
.text 1028590 1028588 -2 -0.0
cc13x2_26x2 all-clusters-minimal-app LP_CC2652R7 (read only) 640851 640843 -8 -0.0
.text 563064 563056 -8 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 763564 763560 -4 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22491180 22491179 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 647802 647800 -2 -0.0
light-switch-app tlsr9518adk80d text 592904 592902 -2 -0.0
ota-requestor-app tlsr9518adk80d text 604272 604270 -2 -0.0
thermostat tlsr9518adk80d text 594480 594478 -2 -0.0
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 8dc9323e a2fa000 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022526 1022526 0 0.0
bl602+rpc (read/write) 1390938 1390938 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053458 1053460 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183467 1183467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69969 69969 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549875 1549875 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490964 490964 0 0.0
.debug_info 40197532 40197533 1 0.0
.debug_line 5265819 5265819 0 0.0
.debug_loc 3400392 3400392 0 0.0
.debug_ranges 371624 371624 0 0.0
.debug_str 3534818 3534818 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106752 106752 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571683 571683 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951562 951564 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276159 1276159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78017 78017 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698271 1698271 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518668 518668 0 0.0
.debug_info 44594117 44594116 -1 -0.0
.debug_line 5664170 5664170 0 0.0
.debug_loc 3596502 3596502 0 0.0
.debug_ranges 395328 395328 0 0.0
.debug_str 3938127 3938127 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121296 121296 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632280 632280 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028590 1028588 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676771 676771 0 0.0
(read/write) 174476 174476 0 0.0
.bss 80940 80940 0 0.0
.data 3384 3384 0 0.0
.rodata 87515 87515 0 0.0
.text 588940 588940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640851 640843 -8 -0.0
(read/write) 157632 157632 0 0.0
.bss 80132 80132 0 0.0
.data 3384 3384 0 0.0
.rodata 77467 77467 0 0.0
.text 563064 563056 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 673823 673823 0 0.0
(read/write) 174768 174768 0 0.0
.bss 78372 78372 0 0.0
.data 3312 3312 0 0.0
.rodata 76311 76311 0 0.0
.text 597032 597032 0 0.0
lock-mtd LP_CC2652R7 (read only) 660183 660183 0 0.0
(read/write) 183672 183672 0 0.0
.bss 73636 73636 0 0.0
.data 3312 3312 0 0.0
.rodata 102775 102775 0 0.0
.text 556928 556928 0 0.0
pump-app LP_CC2652R7 (read only) 686883 686883 0 0.0
(read/write) 162444 162444 0 0.0
.bss 78340 78340 0 0.0
.data 3276 3276 0 0.0
.rodata 90435 90435 0 0.0
.text 595968 595968 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672315 672315 0 0.0
(read/write) 177124 177124 0 0.0
.bss 78452 78452 0 0.0
.data 3300 3300 0 0.0
.rodata 86515 86515 0 0.0
.text 585320 585320 0 0.0
shell LP_CC2652R7 (read only) 668022 668022 0 0.0
(read/write) 185296 185296 0 0.0
.bss 83012 83012 0 0.0
.data 3380 3380 0 0.0
.rodata 84254 84254 0 0.0
.text 583456 583456 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583898 583898 0 0.0
.app_xip_area 460652 460652 0 0.0
.bss 65696 65696 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587614 587614 0 0.0
.app_xip_area 459072 459072 0 0.0
.bss 70984 70984 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549358 549358 0 0.0
.app_xip_area 431592 431592 0 0.0
.bss 60256 60256 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1037404 1037404 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853712 853712 0 0.0
BRD4187C (read/write) 1150156 1150156 0 0.0
.bss 132916 132916 0 0.0
.data 2544 2544 0 0.0
.text 990100 990100 0 0.0
lock-app BRD4161A+wf200 (read/write) 1065044 1065044 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909824 909824 0 0.0
window-app BRD4187C (read/write) 1145052 1145052 0 0.0
.bss 134428 134428 0 0.0
.data 2572 2572 0 0.0
.text 983456 983456 0 0.0
esp32 all-clusters-app c3devkit (read only) 1042100 1042100 0 0.0
(read/write) 1516178 1516178 0 0.0
.dram0.bss 76032 76032 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220136 220136 0 0.0
.flash.text 1042100 1042100 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1094279 1094279 0 0.0
(read/write) 497823 497827 4 0.0
.dram0.bss 81080 81080 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248900 248904 4 0.0
.flash.text 1088895 1088895 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659420 659420 0 0.0
.bss 76624 76624 0 0.0
.data 2112 2112 0 0.0
.text 561572 561572 0 0.0
light k32w0+release (read/write) 671420 671420 0 0.0
.bss 74408 74408 0 0.0
.data 2064 2064 0 0.0
.text 592220 592220 0 0.0
lock k32w0+release (read/write) 630800 630800 0 0.0
.bss 75176 75176 0 0.0
.data 2084 2084 0 0.0
.text 550812 550812 0 0.0
linux chip-tool-ipv6only arm64 (read only) 11063484 11065236 1752 0.0
(read/write) 704776 704792 16 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648200 648216 16 0.0
.dynamic 560 560 0 0.0
.got 14120 14120 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 576284 576372 88 0.0
.text 8814244 8815860 1616 0.0
thermostat-no-ble arm64 (read only) 2506620 2506620 0 0.0
(read/write) 144680 144680 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2093936 2093936 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160672 1160672 0 0.0
bss 143595 143595 0 0.0
rodata 133436 133436 0 0.0
text 803808 803808 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366012 1366012 0 0.0
bss 106054 106054 0 0.0
rodata 210876 210876 0 0.0
text 763564 763560 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107048 1107048 0 0.0
bss 142751 142751 0 0.0
rodata 110580 110580 0 0.0
text 773880 773880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840808 840808 0 0.0
(read/write) 1755764 1755764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251453 1251453 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373636 373636 0 0.0
.debug_info 27506003 27506004 1 0.0
.debug_line 3778996 3778996 0 0.0
.debug_loc 3673164 3673164 0 0.0
.debug_ranges 362248 362248 0 0.0
.debug_str 3485030 3485030 0 0.0
.heap 840808 840808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577246 577246 0 0.0
.symtab 424288 424288 0 0.0
.text 0 0 0 0.0
1554840 1554840 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841624 841624 0 0.0
(read/write) 1697644 1697644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237164 1237164 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376080 376080 0 0.0
.debug_info 27063754 27063755 1 0.0
.debug_line 3787362 3787362 0 0.0
.debug_loc 3656895 3656895 0 0.0
.debug_ranges 360216 360216 0 0.0
.debug_str 3470783 3470783 0 0.0
.heap 841624 841624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 538662 538662 0 0.0
.symtab 409728 409728 0 0.0
.text 1497536 1497536 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611196 1611196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1072030 1072030 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22491180 22491179 -1 -0.0
.debug_line 3340167 3340167 0 0.0
.debug_loc 3336443 3336443 0 0.0
.debug_ranges 319440 319440 0 0.0
.debug_str 3274807 3274807 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474072 474072 0 0.0
.symtab 377632 377632 0 0.0
.text 1419408 1419408 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645188 1645188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073262 1073262 0 0.0
.debug_aranges 103192 103192 0 0.0
.debug_frame 348448 348448 0 0.0
.debug_info 22711597 22711598 1 0.0
.debug_line 3341772 3341772 0 0.0
.debug_loc 3357821 3357821 0 0.0
.debug_ranges 321304 321304 0 0.0
.debug_str 3291255 3291255 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477035 477035 0 0.0
.symtab 379504 379504 0 0.0
.text 1448416 1448416 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147688 0 0.0
.bss 99940 99940 0 0.0
.data 848 848 0 0.0
.text 594788 594788 0 0.0
lock-app qpg6105+debug (read/write) 1115408 1115408 0 0.0
.bss 96460 96460 0 0.0
.data 860 860 0 0.0
.text 562504 562504 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015280 1015280 0 0.0
bss 98044 98044 0 0.0
text 685420 685420 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951940 951940 0 0.0
bss 97092 97092 0 0.0
text 647802 647800 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857388 857388 0 0.0
bss 89216 89216 0 0.0
text 578778 578778 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873168 873168 0 0.0
bss 89304 89304 0 0.0
text 592904 592902 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950484 950484 0 0.0
bss 97452 97452 0 0.0
text 658298 658300 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887328 887328 0 0.0
bss 90252 90252 0 0.0
text 604272 604270 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877376 877376 0 0.0
bss 90692 90692 0 0.0
text 594480 594478 -2 -0.0

@wqx6 wqx6 force-pushed the controller/set_cats branch from a2fa000 to fef63cd Compare February 1, 2023 07:39
@github-actions
Copy link

github-actions bot commented Feb 1, 2023 •
edited
Loading

PR #24774: Size comparison from 8dc9323 to b1bec5d

Increases (8 builds for bl702, esp32, linux, psoc6, telink)
platform target config section 8dc9323e b1bec5d change % change
bl702 lighting-app bl702 .debug_info 40197532 40197533 1 0.0
.text 951562 951564 2 0.0
esp32 all-clusters-app m5stack (read/write) 497823 497827 4 0.0
.flash.rodata 248900 248904 4 0.0
linux chip-tool debug (read only) 1168931 11689809 496 0.0
.rodata 650341 650373 32 0.0
.text 9515956 9516420 464 0.0
chip-tool-ipv6only arm64 (read only) 11063484 11064036 552 0.0
.rodata 576284 576356 72 0.0
.text 8814244 8814724 480 0.0
tv-app debug (read only) 3314737 3314769 32 0.0
.text 2849490 2849522 32 0.0
tv-casting-app debug .text 5048626 5048658 32 0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 27063754 27063755 1 0.0
telink lighting-app tlsr9518adk80d text 658298 658300 2 0.0
Decreases (8 builds for bl602, bl702, linux, nrfconnect, psoc6, qpg, telink)
platform target config section 8dc9323e b1bec5d change % change
bl602 lighting-app bl602 .text 1022526 1022524 -2 -0.0
bl702 lighting-app bl702+rpc .debug_info 44594117 44594115 -2 -0.0
.text 1028590 1028586 -4 -0.0
linux tv-casting-app debug .rodata 365268 365236 -32 -0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1160672 1160656 -16 -0.0
text 803808 803804 -4 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22491180 22491179 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147680 -8 -0.0
.text 594788 594780 -8 -0.0
telink all-clusters-app tlsr9518adk80d text 685420 685418 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d text 647802 647800 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 8dc9323e b1bec5d change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022526 1022524 -2 -0.0
bl602+rpc (read/write) 1390938 1390938 0 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053458 1053458 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183467 1183467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69969 69969 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1549875 1549875 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490964 490964 0 0.0
.debug_info 40197532 40197533 1 0.0
.debug_line 5265819 5265819 0 0.0
.debug_loc 3400392 3400392 0 0.0
.debug_ranges 371624 371624 0 0.0
.debug_str 3534818 3534818 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106752 106752 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571683 571683 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951562 951564 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276159 1276159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78017 78017 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698271 1698271 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518668 518668 0 0.0
.debug_info 44594117 44594115 -2 -0.0
.debug_line 5664170 5664170 0 0.0
.debug_loc 3596502 3596502 0 0.0
.debug_ranges 395328 395328 0 0.0
.debug_str 3938127 3938127 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121296 121296 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632280 632280 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028590 1028586 -4 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676771 676771 0 0.0
(read/write) 174476 174476 0 0.0
.bss 80940 80940 0 0.0
.data 3384 3384 0 0.0
.rodata 87515 87515 0 0.0
.text 588940 588940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640851 640851 0 0.0
(read/write) 157632 157632 0 0.0
.bss 80132 80132 0 0.0
.data 3384 3384 0 0.0
.rodata 77467 77467 0 0.0
.text 563064 563064 0 0.0
lock-ftd LP_CC2652R7 (read only) 673823 673823 0 0.0
(read/write) 174768 174768 0 0.0
.bss 78372 78372 0 0.0
.data 3312 3312 0 0.0
.rodata 76311 76311 0 0.0
.text 597032 597032 0 0.0
lock-mtd LP_CC2652R7 (read only) 660183 660183 0 0.0
(read/write) 183672 183672 0 0.0
.bss 73636 73636 0 0.0
.data 3312 3312 0 0.0
.rodata 102775 102775 0 0.0
.text 556928 556928 0 0.0
pump-app LP_CC2652R7 (read only) 686883 686883 0 0.0
(read/write) 162444 162444 0 0.0
.bss 78340 78340 0 0.0
.data 3276 3276 0 0.0
.rodata 90435 90435 0 0.0
.text 595968 595968 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672315 672315 0 0.0
(read/write) 177124 177124 0 0.0
.bss 78452 78452 0 0.0
.data 3300 3300 0 0.0
.rodata 86515 86515 0 0.0
.text 585320 585320 0 0.0
shell LP_CC2652R7 (read only) 668022 668022 0 0.0
(read/write) 185296 185296 0 0.0
.bss 83012 83012 0 0.0
.data 3380 3380 0 0.0
.rodata 84254 84254 0 0.0
.text 583456 583456 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583898 583898 0 0.0
.app_xip_area 460652 460652 0 0.0
.bss 65696 65696 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587614 587614 0 0.0
.app_xip_area 459072 459072 0 0.0
.bss 70984 70984 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549358 549358 0 0.0
.app_xip_area 431592 431592 0 0.0
.bss 60256 60256 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1037404 1037404 0 0.0
.bss 181632 181632 0 0.0
.data 2040 2040 0 0.0
.text 853712 853712 0 0.0
BRD4187C (read/write) 1150156 1150156 0 0.0
.bss 132916 132916 0 0.0
.data 2544 2544 0 0.0
.text 990100 990100 0 0.0
lock-app BRD4161A+wf200 (read/write) 1065044 1065044 0 0.0
.bss 153152 153152 0 0.0
.data 2048 2048 0 0.0
.text 909824 909824 0 0.0
window-app BRD4187C (read/write) 1145052 1145052 0 0.0
.bss 134428 134428 0 0.0
.data 2572 2572 0 0.0
.text 983456 983456 0 0.0
esp32 all-clusters-app c3devkit (read only) 1042100 1042100 0 0.0
(read/write) 1516178 1516178 0 0.0
.dram0.bss 76032 76032 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220136 220136 0 0.0
.flash.text 1042100 1042100 0 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1094279 1094279 0 0.0
(read/write) 497823 497827 4 0.0
.dram0.bss 81080 81080 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248900 248904 4 0.0
.flash.text 1088895 1088895 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659420 659420 0 0.0
.bss 76624 76624 0 0.0
.data 2112 2112 0 0.0
.text 561572 561572 0 0.0
light k32w0+release (read/write) 671420 671420 0 0.0
.bss 74408 74408 0 0.0
.data 2064 2064 0 0.0
.text 592220 592220 0 0.0
lock k32w0+release (read/write) 630800 630800 0 0.0
.bss 75176 75176 0 0.0
.data 2084 2084 0 0.0
.text 550812 550812 0 0.0
linux all-clusters-app debug (read only) 3154937 3154937 0 0.0
(read/write) 154864 154864 0 0.0
.bss 63744 63744 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283659 283659 0 0.0
.text 2685858 2685858 0 0.0
all-clusters-minimal-app debug (read only) 2971209 2971209 0 0.0
(read/write) 148080 148080 0 0.0
.bss 62880 62880 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 282379 282379 0 0.0
.text 2506738 2506738 0 0.0
bridge-app debug (read only) 2524825 2524825 0 0.0
(read/write) 132320 132320 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68952 68952 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 213920 213920 0 0.0
.text 2138514 2138514 0 0.0
chip-tool debug (read only) 1168931 11689809 496 0.0
(read/write) 655472 655472 0 0.0
.bss 26264 26264 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 619408 619408 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 650341 650373 32 0.0
.text 9515956 9516420 464 0.0
chip-tool-ipv6only arm64 (read only) 11063484 11064036 552 0.0
(read/write) 704776 704776 0 0.0
.bss 34248 34248 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 648200 648200 0 0.0
.dynamic 560 560 0 0.0
.got 14120 14120 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 576284 576356 72 0.0
.text 8814244 8814724 480 0.0
lighting-app debug+rpc (read only) 2692257 2692257 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229856 229856 0 0.0
.text 2285042 2285042 0 0.0
lock-app debug (read only) 2655033 2655033 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 246088 246088 0 0.0
.text 2236434 2236434 0 0.0
ota-provider-app debug (read only) 2225057 2225057 0 0.0
(read/write) 106480 106480 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51560 51560 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197416 197416 0 0.0
.text 1887122 1887122 0 0.0
ota-requestor-app debug (read only) 2386569 2386569 0 0.0
(read/write) 114208 114208 0 0.0
.bss 50176 50176 0 0.0
.data 2480 2480 0 0.0
.data.rel.ro 56328 56328 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 204400 204400 0 0.0
.text 2032626 2032626 0 0.0
shell debug (read only) 2684385 2684385 0 0.0
(read/write) 139360 139360 0 0.0
.bss 59144 59144 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241746 241746 0 0.0
.text 2282194 2282194 0 0.0
thermostat-no-ble arm64 (read only) 2506620 2506620 0 0.0
(read/write) 144680 144680 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76968 76968 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150856 150856 0 0.0
.text 2093936 2093936 0 0.0
tv-app debug (read only) 3314737 3314769 32 0.0
(read/write) 259568 259568 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78096 78096 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270520 270520 0 0.0
.text 2849490 2849522 32 0.0
tv-casting-app debug (read only) 5699513 5699513 0 0.0
(read/write) 164568 164568 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 102520 102520 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 365268 365236 -32 -0.0
.text 5048626 5048658 32 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160672 1160656 -16 -0.0
bss 143595 143595 0 0.0
rodata 133436 133436 0 0.0
text 803808 803804 -4 -0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366012 1366012 0 0.0
bss 106054 106054 0 0.0
rodata 210876 210876 0 0.0
text 763564 763564 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107048 1107048 0 0.0
bss 142751 142751 0 0.0
rodata 110580 110580 0 0.0
text 773880 773880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840808 840808 0 0.0
(read/write) 1755764 1755764 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251453 1251453 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373636 373636 0 0.0
.debug_info 27506003 27506003 0 0.0
.debug_line 3778996 3778996 0 0.0
.debug_loc 3673164 3673164 0 0.0
.debug_ranges 362248 362248 0 0.0
.debug_str 3485030 3485030 0 0.0
.heap 840808 840808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577246 577246 0 0.0
.symtab 424288 424288 0 0.0
.text 1554840 1554840 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841624 841624 0 0.0
(read/write) 1697644 1697644 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237164 1237164 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376080 376080 0 0.0
.debug_info 27063754 27063755 1 0.0
.debug_line 3787362 3787362 0 0.0
.debug_loc 3656895 3656895 0 0.0
.debug_ranges 360216 360216 0 0.0
.debug_str 3470783 3470783 0 0.0
.heap 841624 841624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 538662 538662 0 0.0
.symtab 409728 409728 0 0.0
.text 1497536 1497536 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611196 1611196 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1072030 1072030 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346624 346624 0 0.0
.debug_info 22491180 22491179 -1 -0.0
.debug_line 3340167 3340167 0 0.0
.debug_loc 3336443 3336443 0 0.0
.debug_ranges 319440 319440 0 0.0
.debug_str 3274807 3274807 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474072 474072 0 0.0
.symtab 377632 377632 0 0.0
.text 1419408 1419408 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645188 1645188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073262 1073262 0 0.0
.debug_aranges 103192 103192 0 0.0
.debug_frame 348448 348448 0 0.0
.debug_info 22711597 22711597 0 0.0
.debug_line 3341772 3341772 0 0.0
.debug_loc 3357821 3357821 0 0.0
.debug_ranges 321304 321304 0 0.0
.debug_str 3291255 3291255 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477035 477035 0 0.0
.symtab 379504 379504 0 0.0
.text 1448416 1448416 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147680 -8 -0.0
.bss 99940 99940 0 0.0
.data 848 848 0 0.0
.text 594788 594780 -8 -0.0
lock-app qpg6105+debug (read/write) 1115408 1115408 0 0.0
.bss 96460 96460 0 0.0
.data 860 860 0 0.0
.text 562504 562504 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015280 1015280 0 0.0
bss 98044 98044 0 0.0
text 685420 685418 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951940 951940 0 0.0
bss 97092 97092 0 0.0
text 647802 647800 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857388 857388 0 0.0
bss 89216 89216 0 0.0
text 578778 578778 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873168 873168 0 0.0
bss 89304 89304 0 0.0
text 592904 592904 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950484 950484 0 0.0
bss 97452 97452 0 0.0
text 658298 658300 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887328 887328 0 0.0
bss 90252 90252 0 0.0
text 604272 604272 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877376 877376 0 0.0
bss 90692 90692 0 0.0
text 594480 594480 0 0.0

@wqx6 wqx6 force-pushed the controller/set_cats branch from b1bec5d to e96946d Compare February 2, 2023 05:33
@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited
Loading

PR #24774: Size comparison from 6f041ac to e96946d

Increases (3 builds for bl602, bl702)
platform target config section 6f041ac e96946d change % change
bl602 lighting-app bl602 .text 1022522 1022526 4 0.0
bl602+rpc (read/write) 1390674 1390682 8 0.0
.text 1053200 1053202 2 0.0
bl702 lighting-app bl702 .debug_info 40198207 40198208 1 0.0
.text 951562 951564 2 0.0
Full report (13 builds for bl602, bl702, k32w, mbed, nrfconnect, qpg)
platform target config section 6f041ac e96946d change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022522 1022526 4 0.0
bl602+rpc (read/write) 1390674 1390682 8 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053200 1053202 2 0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1183467 1183467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69969 69969 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550158 1550158 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490960 490960 0 0.0
.debug_info 40198207 40198208 1 0.0
.debug_line 5266054 5266054 0 0.0
.debug_loc 3400632 3400632 0 0.0
.debug_ranges 371672 371672 0 0.0
.debug_str 3534920 3534920 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106752 106752 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571683 571683 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 951562 951564 2 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1276159 1276159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78017 78017 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698572 1698572 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518664 518664 0 0.0
.debug_info 44594580 44594580 0 0.0
.debug_line 5664522 5664522 0 0.0
.debug_loc 3596881 3596881 0 0.0
.debug_ranges 395376 395376 0 0.0
.debug_str 3938158 3938158 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121296 121296 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632280 632280 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1028588 1028588 0 0.0
k32w contact k32w0+release (read/write) 659452 659452 0 0.0
.bss 76624 76624 0 0.0
.data 2112 2112 0 0.0
.text 561604 561604 0 0.0
light k32w0+release (read/write) 671404 671404 0 0.0
.bss 74408 74408 0 0.0
.data 2064 2064 0 0.0
.text 592204 592204 0 0.0
lock k32w0+release (read/write) 630784 630784 0 0.0
.bss 75176 75176 0 0.0
.data 2084 2084 0 0.0
.text 550796 550796 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160672 1160672 0 0.0
bss 143595 143595 0 0.0
rodata 133436 133436 0 0.0
text 803808 803808 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366012 1366012 0 0.0
bss 106054 106054 0 0.0
rodata 210876 210876 0 0.0
text 763564 763564 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107048 1107048 0 0.0
bss 142751 142751 0 0.0
rodata 110580 110580 0 0.0
text 773880 773880 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147688 0 0.0
.bss 99940 99940 0 0.0
.data 848 848 0 0.0
.text 594788 594788 0 0.0
lock-app qpg6105+debug (read/write) 1115408 1115408 0 0.0
.bss 96460 96460 0 0.0
.data 860 860 0 0.0
.text 562504 562504 0 0.0

@github-actions
Copy link

github-actions bot commented Feb 2, 2023 •
edited
Loading

PR #24774: Size comparison from 6f041ac to 1f66a17

Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
platform target config section 6f041ac 1f66a17 change % change
bl602 lighting-app bl602+rpc (read/write) 1390674 1390682 8 0.0
.text 1053200 1053202 2 0.0
bl702 lighting-app bl702 .debug_info 40198207 40198208 1 0.0
.text 951562 951564 2 0.0
bl702+rpc .debug_info 44594580 44594581 1 0.0
.text 1028588 1028590 2 0.0
cc13x2_26x2 shell LP_CC2652R7 (read/write) 185296 185304 8 0.0
esp32 all-clusters-app c3devkit (read only) 1046600 1046602 2 0.0
.flash.text 1046600 1046602 2 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27505608 27505609 1 0.0
light cy8ckit_062s2_43012 .debug_info 22490619 22490620 1 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 647798 647800 2 0.0
light-switch-app tlsr9518adk80d text 592904 592906 2 0.0
lighting-app tlsr9518adk80d text 658298 658300 2 0.0
ota-requestor-app tlsr9518adk80d (read/write) 887328 887336 8 0.0
text 604272 604274 2 0.0
thermostat tlsr9518adk80d text 594480 594482 2 0.0
Decreases (1 build for cc13x2_26x2)
platform target config section 6f041ac 1f66a17 change % change
cc13x2_26x2 shell LP_CC2652R7 (read only) 668022 668014 -8 -0.0
.text 583456 583448 -8 -0.0
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6f041ac 1f66a17 change % change
bl602 lighting-app bl602 (read/write) 1345490 1345490 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1022522 1022522 0 0.0
bl602+rpc (read/write) 1390674 1390682 8 0.0
.bss 102906 102906 0 0.0
.data 10128 10128 0 0.0
.text 1053200 1053202 2 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1183467 1183467 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69969 69969 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1550158 1550158 0 0.0
.debug_aranges 134056 134056 0 0.0
.debug_frame 490960 490960 0 0.0
.debug_info 40198207 40198208 1 0.0
.debug_line 5266054 5266054 0 0.0
.debug_loc 3400632 3400632 0 0.0
.debug_ranges 371672 371672 0 0.0
.debug_str 3534920 3534920 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106752 106752 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 571683 571683 0 0.0
.symtab 173184 173184 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
951562 951564 2 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276159 1276159 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78017 78017 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1698572 1698572 0 0.0
.debug_aranges 142280 142280 0 0.0
.debug_frame 518664 518664 0 0.0
.debug_info 44594580 44594581 1 0.0
.debug_line 5664522 5664522 0 0.0
.debug_loc 3596881 3596881 0 0.0
.debug_ranges 395376 395376 0 0.0
.debug_str 3938158 3938158 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121296 121296 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 632280 632280 0 0.0
.symtab 191536 191536 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028588 1028590 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676771 676771 0 0.0
(read/write) 174476 174476 0 0.0
.bss 80940 80940 0 0.0
.data 3384 3384 0 0.0
.rodata 87515 87515 0 0.0
.text 588940 588940 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640851 640851 0 0.0
(read/write) 157632 157632 0 0.0
.bss 80132 80132 0 0.0
.data 3384 3384 0 0.0
.rodata 77467 77467 0 0.0
.text 563064 563064 0 0.0
lock-ftd LP_CC2652R7 (read only) 673823 673823 0 0.0
(read/write) 174768 174768 0 0.0
.bss 78372 78372 0 0.0
.data 3312 3312 0 0.0
.rodata 76311 76311 0 0.0
.text 597032 597032 0 0.0
lock-mtd LP_CC2652R7 (read only) 660183 660183 0 0.0
(read/write) 183672 183672 0 0.0
.bss 73636 73636 0 0.0
.data 3312 3312 0 0.0
.rodata 102775 102775 0 0.0
.text 556928 556928 0 0.0
pump-app LP_CC2652R7 (read only) 686883 686883 0 0.0
(read/write) 162444 162444 0 0.0
.bss 78340 78340 0 0.0
.data 3276 3276 0 0.0
.rodata 90435 90435 0 0.0
.text 595968 595968 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672315 672315 0 0.0
(read/write) 177124 177124 0 0.0
.bss 78452 78452 0 0.0
.data 3300 3300 0 0.0
.rodata 86515 86515 0 0.0
.text 585320 585320 0 0.0
shell LP_CC2652R7 (read only) 668022 668014 -8 -0.0
(read/write) 185296 185304 8 0.0
.bss 83012 83012 0 0.0
.data 3380 3380 0 0.0
.rodata 84254 84254 0 0.0
.text 583456 583448 -8 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 583898 583898 0 0.0
.app_xip_area 460652 460652 0 0.0
.bss 65696 65696 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 587614 587614 0 0.0
.app_xip_area 459072 459072 0 0.0
.bss 70984 70984 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549358 549358 0 0.0
.app_xip_area 431592 431592 0 0.0
.bss 60256 60256 0 0.0
.data 692 692 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs911x (read/write) 1037624 1037624 0 0.0
.bss 181624 181624 0 0.0
.data 2044 2044 0 0.0
.text 853932 853932 0 0.0
BRD4187C (read/write) 1150752 1150752 0 0.0
.bss 132920 132920 0 0.0
.data 2544 2544 0 0.0
.text 990692 990692 0 0.0
lock-app BRD4161A+wf200 (read/write) 1065296 1065296 0 0.0
.bss 153152 153152 0 0.0
.data 2052 2052 0 0.0
.text 910068 910068 0 0.0
window-app BRD4187C (read/write) 1145660 1145660 0 0.0
.bss 134424 134424 0 0.0
.data 2572 2572 0 0.0
.text 984068 984068 0 0.0
esp32 all-clusters-app c3devkit (read only) 1046600 1046602 2 0.0
(read/write) 1518682 1518682 0 0.0
.dram0.bss 78024 78024 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 220640 220640 0 0.0
.flash.text 1046600 1046602 2 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1098291 1098291 0 0.0
(read/write) 500307 500307 0 0.0
.dram0.bss 83072 83072 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 249392 249392 0 0.0
.flash.text 1092907 1092907 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 659452 659452 0 0.0
.bss 76624 76624 0 0.0
.data 2112 2112 0 0.0
.text 561604 561604 0 0.0
light k32w0+release (read/write) 671404 671404 0 0.0
.bss 74408 74408 0 0.0
.data 2064 2064 0 0.0
.text 592204 592204 0 0.0
lock k32w0+release (read/write) 630784 630784 0 0.0
.bss 75176 75176 0 0.0
.data 2084 2084 0 0.0
.text 550796 550796 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463256 2463256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1425900 1425900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1160672 1160672 0 0.0
bss 143595 143595 0 0.0
rodata 133436 133436 0 0.0
text 803808 803808 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366012 1366012 0 0.0
bss 106054 106054 0 0.0
rodata 210876 210876 0 0.0
text 763564 763564 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1107048 1107048 0 0.0
bss 142751 142751 0 0.0
rodata 110580 110580 0 0.0
text 773880 773880 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840808 840808 0 0.0
(read/write) 1755732 1755732 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189864 189864 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2672 2672 0 0.0
.debug_abbrev 1251513 1251513 0 0.0
.debug_aranges 111280 111280 0 0.0
.debug_frame 373628 373628 0 0.0
.debug_info 27505608 27505609 1 0.0
.debug_line 3779124 3779124 0 0.0
.debug_loc 3673185 3673185 0 0.0
.debug_ranges 362248 362248 0 0.0
.debug_str 3485030 3485030 0 0.0
.heap 840808 840808 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 577246 577246 0 0.0
.symtab 424288 424288 0 0.0
.text 1554808 1554808 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841624 841624 0 0.0
(read/write) 1697612 1697612 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189056 189056 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1237224 1237224 0 0.0
.debug_aranges 110544 110544 0 0.0
.debug_frame 376072 376072 0 0.0
.debug_info 27063369 27063369 0 0.0
.debug_line 3787499 3787499 0 0.0
.debug_loc 3656916 3656916 0 0.0
.debug_ranges 360216 360216 0 0.0
.debug_str 3470783 3470783 0 0.0
.heap 841624 841624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 538662 538662 0 0.0
.symtab 409728 409728 0 0.0
.text 1497504 1497504 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1611180 1611180 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1071614 1071614 0 0.0
.debug_aranges 102800 102800 0 0.0
.debug_frame 346616 346616 0 0.0
.debug_info 22490619 22490620 1 0.0
.debug_line 3340291 3340291 0 0.0
.debug_loc 3336464 3336464 0 0.0
.debug_ranges 319440 319440 0 0.0
.debug_str 3274807 3274807 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 474072 474072 0 0.0
.symtab 377632 377632 0 0.0
.text 1419392 1419392 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1645188 1645188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1073262 1073262 0 0.0
.debug_aranges 103192 103192 0 0.0
.debug_frame 348448 348448 0 0.0
.debug_info 22711597 22711597 0 0.0
.debug_line 3341772 3341772 0 0.0
.debug_loc 3357821 3357821 0 0.0
.debug_ranges 321304 321304 0 0.0
.debug_str 3291255 3291255 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 477035 477035 0 0.0
.symtab 379504 379504 0 0.0
.text 1448416 1448416 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147688 1147688 0 0.0
.bss 99940 99940 0 0.0
.data 848 848 0 0.0
.text 594788 594788 0 0.0
lock-app qpg6105+debug (read/write) 1115408 1115408 0 0.0
.bss 96460 96460 0 0.0
.data 860 860 0 0.0
.text 562504 562504 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1015272 1015272 0 0.0
bss 98044 98044 0 0.0
text 685416 685416 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 951940 951940 0 0.0
bss 97092 97092 0 0.0
text 647798 647800 2 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 857468 857468 0 0.0
bss 89216 89216 0 0.0
text 578858 578858 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 873168 873168 0 0.0
bss 89304 89304 0 0.0
text 592904 592906 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 950484 950484 0 0.0
bss 97452 97452 0 0.0
text 658298 658300 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887328 887336 8 0.0
bss 90252 90252 0 0.0
text 604272 604274 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877376 877376 0 0.0
bss 90692 90692 0 0.0
text 594480 594482 2 0.0

@yufengwangca yufengwangca merged commit 79d5ac4 into project-chip:master Feb 2, 2023
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@wqx6 @bzbarsky-apple
Add a method to send the NOC with CATs when pairing devices (project-…
9b3063d 
…chip#24774)

* controller: Add interface for setting CATs in ExampleOperationalCredentialsIssuer

* chiptool: Add option to set CATs encoded in device's NOC for pairing command

* Update examples/chip-tool/commands/common/CredentialIssuerCommands.h

Co-authored-by: Boris Zbarsky <[email protected]>

---------

Co-authored-by: Boris Zbarsky <[email protected]>
@wqx6 wqx6 mentioned this pull request Apr 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@amitnj amitnj Awaiting requested review from amitnj

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
controller examples review - approved tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wqx6 @yufengwangca @bzbarsky-apple