-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Andriod] Remove extra sub-interface layer from DeviceAttestationDelegate interface #24771
[Andriod] Remove extra sub-interface layer from DeviceAttestationDelegate interface #24771
Conversation
PR #24771: Size comparison from 34332ce to 1c1ea4f Increases (8 builds for bl602, bl702, esp32, nrfconnect, telink)
Decreases (5 builds for bl702, cc13x2_26x2, psoc6, qpg)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24771: Size comparison from 8dc9323 to 0bd10ad Increases (5 builds for bl702, esp32, psoc6, telink)
Decreases (6 builds for bl602, bl702, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24771: Size comparison from a8483eb to de5862d Increases (5 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (6 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24771: Size comparison from 1334f3a to 5c1febb Increases (5 builds for esp32, nrfconnect, qpg, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
...IPTool/app/src/main/java/com/google/chip/chiptool/provisioning/DeviceProvisioningFragment.kt
Outdated
Show resolved
Hide resolved
...IPTool/app/src/main/java/com/google/chip/chiptool/provisioning/DeviceProvisioningFragment.kt
Outdated
Show resolved
Hide resolved
...IPTool/app/src/main/java/com/google/chip/chiptool/provisioning/DeviceProvisioningFragment.kt
Outdated
Show resolved
Hide resolved
...IPTool/app/src/main/java/com/google/chip/chiptool/provisioning/DeviceProvisioningFragment.kt
Outdated
Show resolved
Hide resolved
...IPTool/app/src/main/java/com/google/chip/chiptool/provisioning/DeviceProvisioningFragment.kt
Outdated
Show resolved
Hide resolved
...IPTool/app/src/main/java/com/google/chip/chiptool/provisioning/DeviceProvisioningFragment.kt
Outdated
Show resolved
Hide resolved
PR #24771: Size comparison from 836390e to 2b40a94 Increases (8 builds for esp32, nrfconnect, psoc6, qpg, telink)
Decreases (2 builds for bl602)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Hi Yufeng, DeviceAttestationCompletionCallback is to align with the iOS implementation, if there is a better implementation that can be provided, I personally do not recommend deleting it iOS implementation: |
…reCallback sub-interfaces from DeviceAttestationDelegate
|
PR #24771: Size comparison from 17d7f00 to 38889f4 Increases (10 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24771: Size comparison from 17d7f00 to e0acfbc Increases (5 builds for bl602, nrfconnect, telink)
Decreases (8 builds for bl702, efr32, esp32, nrfconnect, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24771: Size comparison from 38f510c to d577c7b Increases (9 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24771: Size comparison from 655d134 to 4d010a5 Increases (7 builds for bl602, bl702, efr32, psoc6, qpg, telink)
Decreases (4 builds for bl702, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
...IPTool/app/src/main/java/com/google/chip/chiptool/provisioning/DeviceProvisioningFragment.kt
Outdated
Show resolved
Hide resolved
…gate interface (project-chip#24771) * Remove DeviceAttestationCompletionCallback and DeviceAttestationFailureCallback sub-interfaces from DeviceAttestationDelegate * Address review comments * Move DeviceController init from onCreateView() to onCreate()
Currently, there are two sub-interfaces (DeviceAttestationCompletionCallback and DeviceAttestationFailureCallback) within interface DeviceAttestationDelegate and only one of them could be implemented.
The prototype of sub-interface DeviceAttestationCompletionCallback and DeviceAttestationFailureCallback are similar, and DeviceAttestationCompletionCallback is always called if implemented and DeviceAttestationFailureCallback is only triggered when attestation failed
This design is really confusing, since DeviceAttestationCompletionCallback already contains the error code parameter which could be used to indicate attestation failure, we could simplify DeviceAttestationDelegate interface by removing the sub-interface layer