-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for default pseudo cluster for chip-repl based yamltests #24669
Merged
tehampson
merged 4 commits into
project-chip:master
from
tehampson:integrate-pseudo-cluster-01-25
Jan 30, 2023
Merged
Add support for default pseudo cluster for chip-repl based yamltests #24669
tehampson
merged 4 commits into
project-chip:master
from
tehampson:integrate-pseudo-cluster-01-25
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
January 26, 2023 20:11
pullapprove
bot
requested review from
pjzander-signify,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 26, 2023 20:11
andy31415
approved these changes
Jan 26, 2023
PR #24669: Size comparison from d65d147 to bfcecfe Increases (9 builds for bl602, bl702, psoc6, telink)
Decreases (5 builds for cyw30739, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24669: Size comparison from 4f24db4 to 18ba38c Increases (10 builds for bl602, bl702, psoc6, telink)
Decreases (4 builds for cyw30739, esp32, qpg)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 30, 2023
PR #24669: Size comparison from 4f24db4 to 5a723a5 Increases above 0.2%:
Increases (21 builds for bl602, bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6)
Decreases (31 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, nrfconnect, qpg, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
21 tasks
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…roject-chip#24669) * Add support for default pseudo cluster * Address PR comment * Address PR comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By supporting basic default pseudo cluster there are more yaml test that start passing. Updating CI to run those test will come in a separate PR as there are a few PRs in flight to modify that file