-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[matter_yamltests] Add try_apply_float_to_integer_fix since Test_TC_C… #24658
Merged
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_Add_try_apply_float_to_integer_fix
Jan 26, 2023
Merged
[matter_yamltests] Add try_apply_float_to_integer_fix since Test_TC_C… #24658
vivien-apple
merged 1 commit into
project-chip:master
from
vivien-apple:YamlTests_Add_try_apply_float_to_integer_fix
Jan 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…C_6_2 makes math operation to configure a value that ends up as a float while a int is expected
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
msandstedt
January 26, 2023 15:16
pullapprove
bot
requested review from
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 26, 2023 15:16
tehampson
approved these changes
Jan 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
jtung-apple
approved these changes
Jan 26, 2023
PR #24658: Size comparison from dfa7c9d to 16779c2 Increases (4 builds for bl602, cc13x2_26x2, esp32, nrfconnect)
Decreases (11 builds for cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 26, 2023
bzbarsky-apple
approved these changes
Jan 26, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…C_6_2 makes math operation to configure a value that ends up as a float while a int is expected (project-chip#24658)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…C_6_2 makes math operation to configure a value that ends up as a float while a int is expected
Problem
When running tests with
matter_yamltests
andchip-tool
locally I found out that some dynamic values are ending up as float when they should ends up as an integer. In C++ this was sort of automatic but we need to make it manually now.