Validate target names passed to build_examples.py #24644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
approved these changes
Jan 25, 2023
pullapprove
bot
requested review from
amitnj,
andy31415,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
robszewczyk,
saurabhst,
selissia and
tcarmelveilleux
pullapprove
bot
requested review from
tecimovic,
tehampson,
vijs,
xylophone21,
yufengwangca and
yunhanw-google
Damian-Nordic
approved these changes
Jan 25, 2023
yufengwangca
approved these changes
Jan 25, 2023
andy31415
reviewed
Jan 25, 2023
andy31415
approved these changes
Jan 25, 2023
|
PR #24644: Size comparison from d80211c to c325cfe Increases (8 builds for bl602, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (8 builds for bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Skipping invalid target names might lead to false positive CI passes in case when target name is invalid. In such case test was never executed.
arkq
force-pushed
the
build-examples-validate-target
branch
from
c325cfe to
403bea3
Compare
|
PR #24644: Size comparison from 0620f27 to 403bea3 Increases (7 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (9 builds for bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #24644: Size comparison from 0620f27 to f07aa18 Increases (5 builds for bl602, esp32, psoc6, telink)
Decreases (11 builds for bl602, bl702, cyw30739, esp32, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Validate target names passed to build_examples.py Skipping invalid target names might lead to false positive CI passes in case when target name is invalid. In such case test was never executed. * Fix target names for Tizen examples CI checks * Restyled by isort * Add libwebsockets submodule to Tizen platform Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Skipping invalid target names might lead to false positive CI passes in case when target name is invalid. In such case test was never executed. Related to #24643
Changes
--targetoption in./scripts/build/build_examples.py --target XXX buildscriptTesting
CI will test if there are some other incorrect names in CI workflows. Tested manually: