-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Introduce BLE advertising arbiter #24637
Merged
andy31415
merged 2 commits into
project-chip:master
from
Damian-Nordic:ble-adv-upstream
Jan 30, 2023
Merged
[nrfconnect] Introduce BLE advertising arbiter #24637
andy31415
merged 2 commits into
project-chip:master
from
Damian-Nordic:ble-adv-upstream
Jan 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a class that enables easier coexistence of Matter and custom BLE services. Signed-off-by: Damian Krolik <[email protected]>
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple and
ksperling-apple
January 25, 2023 12:23
pullapprove
bot
requested review from
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pjzander-signify,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 25, 2023 12:23
PR #24637: Size comparison from 612fc1c to a364d00 Increases (20 builds for cyw30739, nrfconnect, psoc6, telink)
Decreases (19 builds for esp32, nrfconnect, psoc6, telink)
Full report (50 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
LuDuda
approved these changes
Jan 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you 👍 (reviewed already internally).
andy31415
approved these changes
Jan 30, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [nrfconnect] Introduce BLE advertising arbiter Add a class that enables easier coexistence of Matter and custom BLE services. Signed-off-by: Damian Krolik <[email protected]> * Restyled by clang-format --------- Signed-off-by: Damian Krolik <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a class that enables easier coexistence of Matter and custom BLE services.
Use the new class to simplify nRF Connect examples that enable DFU over BLE SMP besides Matter OTA.