Align naming in Thermostat cluster XML with the spec. #24622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #24622: Size comparison from 95c1888 to a840cba Increases (7 builds for bl702, psoc6, qpg)
Decreases (13 builds for bl702, linux, nrfconnect, psoc6, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-thermostat
branch
from
a840cba to
a7cb154
Compare
pullapprove
bot
requested review from
amitnj,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy and
jtung-apple
pullapprove
bot
requested review from
mlepage-google,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
|
PR #24622: Size comparison from d1f5f1a to a7cb154 Increases (12 builds for bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (13 builds for bl602, bl702, esp32, linux, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
woody-apple
approved these changes
Jan 24, 2023
andy31415
reviewed
Jan 24, 2023
There was a problem hiding this comment.
@bzbarsky-apple should we have a GetRelayStatusLog command somewhere in commants? I seem to have it in my spec but I do not see it in the xml definition.
andy31415
reviewed
Jan 24, 2023
There was a problem hiding this comment.
@bzbarsky-apple AlarmMask / map8 / 0x001d does not seem to be in the XML
andy31415
reviewed
Jan 24, 2023
There was a problem hiding this comment.
@bzbarsky-apple SetpointChangeSourceTimeStamp is marked epoch_s here, however in the spec it is UTC.
It's in the spec, but it's Zigbee-only in the spec, so should not be here, no. See "9.2.5. Element Requirements" in the device library spec.
Zigbee-only.
utc is a deprecated alias for epoch_s in the spec. Our support for this deprecated alias was broken and we no longer support it to avoid that problem. See #23985. |
andy31415
approved these changes
Jan 24, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…4622) * Align naming in Thermostat cluster XML with the spec. * Regenerate generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.