Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NS_SWIFT_UNAVAILABLE to deprecated APIs that only differ in completionHandler: vs completion:. #24590

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Add NS_SWIFT_UNAVAILABLE to deprecated APIs that only differ in completionHandler: vs completion:. #24590

merged 1 commit into from
Jan 23, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

This causes the APIs to be ambiguous when used from Swift with the normal Swift trailing closure or async syntaxes.

Fixes #24359

@bzbarsky-apple
Add NS_SWIFT_UNAVAILABLE to deprecated APIs that only differ in compl…
dcb5f20 
…etionHandler: vs completion:.

This causes the APIs to be ambiguous when used from Swift with the
normal Swift trailing closure or async syntaxes.

Fixes project-chip#24359
@github-actions
Copy link

github-actions bot commented Jan 23, 2023 •
edited
Loading

PR #24590: Size comparison from 7904f18 to dcb5f20

Increases (7 builds for cc13x2_26x2, esp32, psoc6, telink)
platform target config section 7904f18 dcb5f20 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 184792 184800 8 0.0
esp32 all-clusters-app c3devkit (read only) 1040894 1040896 2 0.0
.flash.text 1040894 1040896 2 0.0
m5stack (read/write) 497307 497311 4 0.0
.flash.rodata 248512 248516 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27390277 27390278 1 0.0
telink all-clusters-app tlsr9518adk80d text 688082 688084 2 0.0
contact-sensor-app tlsr9518adk80d text 581858 581860 2 0.0
lighting-app tlsr9518adk80d text 662464 662466 2 0.0
Decreases (4 builds for cc13x2_26x2, telink)
platform target config section 7904f18 dcb5f20 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 659799 659791 -8 -0.0
.text 556752 556744 -8 -0.0
telink all-clusters-minimal-app tlsr9518adk80d text 651388 651386 -2 -0.0
light-switch-app tlsr9518adk80d text 596464 596462 -2 -0.0
ota-requestor-app tlsr9518adk80d text 607560 607558 -2 -0.0
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 7904f18 dcb5f20 change % change
bl602 lighting-app bl602 (read/write) 1344590 1344590 0 0.0
.bss 94858 94858 0 0.0
.data 9736 9736 0 0.0
.text 1021794 1021794 0 0.0
bl602+rpc (read/write) 1390014 1390014 0 0.0
.bss 102906 102906 0 0.0
.data 10120 10120 0 0.0
.text 1052726 1052726 0 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1184471 1184471 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 70701 70701 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1546669 1546669 0 0.0
.debug_aranges 134000 134000 0 0.0
.debug_frame 490744 490744 0 0.0
.debug_info 40127918 40127918 0 0.0
.debug_line 5261288 5261288 0 0.0
.debug_loc 3398303 3398303 0 0.0
.debug_ranges 371544 371544 0 0.0
.debug_str 3531443 3531443 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106544 106544 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 570983 570983 0 0.0
.symtab 173120 173120 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
952036 952036 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1276907 1276907 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 78749 78749 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1694916 1694916 0 0.0
.debug_aranges 142216 142216 0 0.0
.debug_frame 518408 518408 0 0.0
.debug_info 44524403 44524403 0 0.0
.debug_line 5659342 5659342 0 0.0
.debug_loc 3594204 3594204 0 0.0
.debug_ranges 395240 395240 0 0.0
.debug_str 3934621 3934621 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121024 121024 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 631457 631457 0 0.0
.symtab 191440 191440 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028876 1028876 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676375 676375 0 0.0
(read/write) 175480 175480 0 0.0
.bss 81548 81548 0 0.0
.data 3384 3384 0 0.0
.rodata 87303 87303 0 0.0
.text 588760 588760 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 639871 639871 0 0.0
(read/write) 158240 158240 0 0.0
.bss 80740 80740 0 0.0
.data 3384 3384 0 0.0
.rodata 77255 77255 0 0.0
.text 562292 562292 0 0.0
lock-ftd LP_CC2652R7 (read only) 673803 673803 0 0.0
(read/write) 175524 175524 0 0.0
.bss 79108 79108 0 0.0
.data 3308 3308 0 0.0
.rodata 76099 76099 0 0.0
.text 597224 597224 0 0.0
lock-mtd LP_CC2652R7 (read only) 659799 659791 -8 -0.0
(read/write) 184792 184800 8 0.0
.bss 74372 74372 0 0.0
.data 3308 3308 0 0.0
.rodata 102567 102567 0 0.0
.text 556752 556744 -8 -0.0
pump-app LP_CC2652R7 (read only) 686803 686803 0 0.0
(read/write) 163252 163252 0 0.0
.bss 79068 79068 0 0.0
.data 3272 3272 0 0.0
.rodata 90227 90227 0 0.0
.text 596096 596096 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672251 672251 0 0.0
(read/write) 177916 177916 0 0.0
.bss 79180 79180 0 0.0
.data 3296 3296 0 0.0
.rodata 86307 86307 0 0.0
.text 585464 585464 0 0.0
shell LP_CC2652R7 (read only) 667638 667638 0 0.0
(read/write) 186288 186288 0 0.0
.bss 83620 83620 0 0.0
.data 3380 3380 0 0.0
.rodata 84038 84038 0 0.0
.text 583284 583284 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585202 585202 0 0.0
.app_xip_area 461220 461220 0 0.0
.bss 66432 66432 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588918 588918 0 0.0
.app_xip_area 459640 459640 0 0.0
.bss 71720 71720 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550062 550062 0 0.0
.app_xip_area 431576 431576 0 0.0
.bss 60984 60984 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 973444 973444 0 0.0
.bss 147144 147144 0 0.0
.data 2192 2192 0 0.0
.text 824088 824088 0 0.0
BRD4161A+rs911x (read/write) 1036400 1036400 0 0.0
.bss 181632 181632 0 0.0
.data 2036 2036 0 0.0
.text 852712 852712 0 0.0
BRD4187C (read/write) 1150420 1150420 0 0.0
.bss 133644 133644 0 0.0
.data 2540 2540 0 0.0
.text 989640 989640 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064368 1064368 0 0.0
.bss 153152 153152 0 0.0
.data 2044 2044 0 0.0
.text 909152 909152 0 0.0
window-app BRD4187C (read/write) 1143120 1143120 0 0.0
.bss 135060 135060 0 0.0
.data 2564 2564 0 0.0
.text 980900 980900 0 0.0
esp32 all-clusters-app c3devkit (read only) 1040894 1040896 2 0.0
(read/write) 1515634 1515634 0 0.0
.dram0.bss 75904 75904 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 219720 219720 0 0.0
.flash.text 1040894 1040896 2 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1093027 1093027 0 0.0
(read/write) 497307 497311 4 0.0
.dram0.bss 80952 80952 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248512 248516 4 0.0
.flash.text 1087643 1087643 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660328 660328 0 0.0
.bss 77360 77360 0 0.0
.data 2108 2108 0 0.0
.text 561748 561748 0 0.0
light k32w0+release (read/write) 672044 672044 0 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592108 592108 0 0.0
lock k32w0+release (read/write) 631712 631712 0 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 550988 550988 0 0.0
linux all-clusters-app debug (read only) 3145321 3145321 0 0.0
(read/write) 154736 154736 0 0.0
.bss 63616 63616 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 82248 82248 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 283179 283179 0 0.0
.text 2676722 2676722 0 0.0
all-clusters-minimal-app debug (read only) 2957497 2957497 0 0.0
(read/write) 147952 147952 0 0.0
.bss 62752 62752 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76472 76472 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 281867 281867 0 0.0
.text 2493538 2493538 0 0.0
bridge-app debug (read only) 2521449 2521449 0 0.0
(read/write) 132320 132320 0 0.0
.bss 53632 53632 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68952 68952 0 0.0
.dynamic 608 608 0 0.0
.got 4616 4616 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 213760 213760 0 0.0
.text 2135298 2135298 0 0.0
chip-tool debug (read only) 11489841 11489841 0 0.0
(read/write) 644144 644144 0 0.0
.bss 26168 26168 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 608176 608176 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 638693 638693 0 0.0
.text 9358788 9358788 0 0.0
chip-tool-ipv6only arm64 (read only) 10883252 10883252 0 0.0
(read/write) 693432 693432 0 0.0
.bss 34184 34184 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 636976 636976 0 0.0
.dynamic 560 560 0 0.0
.got 14064 14064 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 565316 565316 0 0.0
.text 8675860 8675860 0 0.0
lighting-app debug+rpc (read only) 2688993 2688993 0 0.0
(read/write) 131688 131688 0 0.0
.bss 51104 51104 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 72088 72088 0 0.0
.dynamic 608 608 0 0.0
.got 4648 4648 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 229696 229696 0 0.0
.text 2281938 2281938 0 0.0
lock-app debug (read only) 2647753 2647753 0 0.0
(read/write) 126736 126736 0 0.0
.bss 49536 49536 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 69064 69064 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 245896 245896 0 0.0
.text 2229346 2229346 0 0.0
ota-provider-app debug (read only) 2221713 2221713 0 0.0
(read/write) 106480 106480 0 0.0
.bss 47712 47712 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51560 51560 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 197288 197288 0 0.0
.text 1883906 1883906 0 0.0
ota-requestor-app debug (read only) 2382849 2382849 0 0.0
(read/write) 114176 114176 0 0.0
.bss 50176 50176 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 56328 56328 0 0.0
.dynamic 608 608 0 0.0
.got 3744 3744 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 203984 203984 0 0.0
.text 2029346 2029346 0 0.0
shell debug (read only) 2677857 2677857 0 0.0
(read/write) 139232 139232 0 0.0
.bss 59016 59016 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 73128 73128 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 241330 241330 0 0.0
.text 2276082 2276082 0 0.0
thermostat-no-ble arm64 (read only) 2500644 2500644 0 0.0
(read/write) 144632 144632 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76920 76920 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150656 150656 0 0.0
.text 2088208 2088208 0 0.0
tv-app debug (read only) 3310961 3310961 0 0.0
(read/write) 259568 259568 0 0.0
.bss 170872 170872 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 78096 78096 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 270360 270360 0 0.0
.text 2845874 2845874 0 0.0
tv-casting-app debug (read only) 5662401 5662401 0 0.0
(read/write) 162168 162168 0 0.0
.bss 53496 53496 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 100120 100120 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 362745 362745 0 0.0
.text 5021090 5021090 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2462256 2462256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1424900 1424900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164132 1164132 0 0.0
bss 147118 147118 0 0.0
rodata 133068 133068 0 0.0
text 803716 803716 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1365752 1365752 0 0.0
bss 106418 106418 0 0.0
rodata 210552 210552 0 0.0
text 762944 762944 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1109696 1109696 0 0.0
bss 146274 146274 0 0.0
rodata 110216 110216 0 0.0
text 773108 773108 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 840944 840944 0 0.0
(read/write) 1749076 1749076 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189736 189736 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1248036 1248036 0 0.0
.debug_aranges 111232 111232 0 0.0
.debug_frame 373520 373520 0 0.0
.debug_info 27390277 27390278 1 0.0
.debug_line 3761667 3761667 0 0.0
.debug_loc 3647011 3647011 0 0.0
.debug_ranges 356616 356616 0 0.0
.debug_str 3481265 3481265 0 0.0
.heap 840944 840944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575227 575227 0 0.0
.symtab 423248 423248 0 0.0
.text 1548288 1548288 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841752 841752 0 0.0
(read/write) 1690332 1690332 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188928 188928 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1233843 1233843 0 0.0
.debug_aranges 110496 110496 0 0.0
.debug_frame 375964 375964 0 0.0
.debug_info 26947864 26947864 0 0.0
.debug_line 3769759 3769759 0 0.0
.debug_loc 3630411 3630411 0 0.0
.debug_ranges 354584 354584 0 0.0
.debug_str 3466071 3466071 0 0.0
.heap 841752 841752 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535607 535607 0 0.0
.symtab 408208 408208 0 0.0
.text 1490352 1490352 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1610236 1610236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1069057 1069057 0 0.0
.debug_aranges 102776 102776 0 0.0
.debug_frame 346524 346524 0 0.0
.debug_info 22418874 22418874 0 0.0
.debug_line 3334595 3334595 0 0.0
.debug_loc 3332192 3332192 0 0.0
.debug_ranges 318800 318800 0 0.0
.debug_str 3271698 3271698 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473496 473496 0 0.0
.symtab 377408 377408 0 0.0
.text 1418448 1418448 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1644300 1644300 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1070405 1070405 0 0.0
.debug_aranges 103160 103160 0 0.0
.debug_frame 348324 348324 0 0.0
.debug_info 22641066 22641066 0 0.0
.debug_line 3336396 3336396 0 0.0
.debug_loc 3353751 3353751 0 0.0
.debug_ranges 320656 320656 0 0.0
.debug_str 3288105 3288105 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476431 476431 0 0.0
.symtab 379232 379232 0 0.0
.text 1447528 1447528 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147908 1147908 0 0.0
.bss 100668 100668 0 0.0
.data 844 844 0 0.0
.text 595004 595004 0 0.0
lock-app qpg6105+debug (read/write) 1115276 1115276 0 0.0
.bss 97188 97188 0 0.0
.data 856 856 0 0.0
.text 562376 562376 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1025724 1025724 0 0.0
bss 98552 98552 0 0.0
text 688082 688084 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 963904 963904 0 0.0
bss 97696 97696 0 0.0
text 651388 651386 -2 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868352 868352 0 0.0
bss 89844 89844 0 0.0
text 581858 581860 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884816 884816 0 0.0
bss 89940 89940 0 0.0
text 596464 596462 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 963160 963160 0 0.0
bss 97996 97996 0 0.0
text 662464 662466 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898624 898624 0 0.0
bss 90888 90888 0 0.0
text 607560 607558 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888032 888032 0 0.0
bss 91328 91328 0 0.0
text 597226 597226 0 0.0

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific change with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit de35f88 into project-chip:master Jan 23, 2023
@bzbarsky-apple bzbarsky-apple deleted the add-swift-unavailable branch January 23, 2023 19:31
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Add NS_SWIFT_UNAVAILABLE to deprecated APIs that only differ in compl…
e72db70 
…etionHandler: vs completion:. (project-chip#24590)

This causes the APIs to be ambiguous when used from Swift with the
normal Swift trailing closure or async syntaxes.

Fixes project-chip#24359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

Assignees
No one assigned
Labels
fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out what to do with deprecated APIs that only differ by completion: vs completionHandler:
2 participants
@bzbarsky-apple @jtung-apple