-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Changes to support esp-idf v5.0 in lighting-app #24589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In idf v4.4.3 spi_flash is pulled in through nvs_flash but in v5.0 is is not, so need to add it explicitly. Also, v4.4.3 have mdns component present in repository but in v5.0 it is moved out to idf component registry and needs to be pulled in using idf component manager
Using the older version of led_strip, v1.0.0-alpha, which is present in idf v4.4.3 to avoid putting in more ifdefs in the code. Fixed few format specifiers in the logs
the error codes where it would have been uninitialized
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928 and
Damian-Nordic
January 23, 2023 13:33
pullapprove
bot
requested review from
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst and
selissia
January 23, 2023 13:33
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 23, 2023 13:33
PR #24589: Size comparison from 43dd327 to 2955b0a Increases (10 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Decreases (6 builds for esp32, nrfconnect, qpg, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Jan 23, 2023
src/app/clusters/fault-injection-server/fault-injection-server.cpp
Outdated
Show resolved
Hide resolved
bzbarsky-apple
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, the format changes look much better now!
dhrishi
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment given. LGTM overall
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…#24589) * [ESP32] Add spi_flash dependency and fixed a typo In idf v4.4.3 spi_flash is pulled in through nvs_flash but in v5.0 is is not, so need to add it explicitly. Also, v4.4.3 have mdns component present in repository but in v5.0 it is moved out to idf component registry and needs to be pulled in using idf component manager * [ESP32] Changes in lighting-app for esp-idf v5.0 support Using the older version of led_strip, v1.0.0-alpha, which is present in idf v4.4.3 to avoid putting in more ifdefs in the code. Fixed few format specifiers in the logs * Fixed format specifiers in logs in common code * [ESP32] esp-idf v5.0 support changes, fixed format specifiers and fixed the error codes where it would have been uninitialized * Fix linter errors * restyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change Overview
This PR adds changes to support esp-idf v5.0 support in lighting-app. Changes are:
spi_flash
as an explicit dependency.mdns
component is moved to idf-component-registry to pulling through idf-component-manager in when using idf v5.0led_strip
version1.0.0-alpha
for idfv5.0
andv4.4.3
Tests
Manually compiled, flashed and verified commissioning and control of
lighting-app/esp32
forJust compiled for Target ESP32H2 on IDF v5.0