Fix a startup crash when a node wants to advertise as a commissioner but not as commissionable. #24565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but not as commissionable. In DnssdServer::Advertise we were trying to get things like a discriminator and other commissionee information even if we were just advertising as a commissioner (commissionableNode was false). This could lead to crashes due to calling things like GetCommissionableDataProvider() when we are not in fact commissionable and don't have one. The fix is to reorder things a bit so we set up all the advertiseParameters state that both commissioners and commissionable share, and then condition all the commissionable-only bits on commissionableNode.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt and
pjzander-signify
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
|
PR #24565: Size comparison from aedd1de to 4e76323 Increases (36 builds for bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, esp32, linux)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
msandstedt
approved these changes
Jan 21, 2023
andy31415
approved these changes
Jan 23, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…but not as commissionable. (project-chip#24565) In DnssdServer::Advertise we were trying to get things like a discriminator and other commissionee information even if we were just advertising as a commissioner (commissionableNode was false). This could lead to crashes due to calling things like GetCommissionableDataProvider() when we are not in fact commissionable and don't have one. The fix is to reorder things a bit so we set up all the advertiseParameters state that both commissioners and commissionable share, and then condition all the commissionable-only bits on commissionableNode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In DnssdServer::Advertise we were trying to get things like a discriminator and other commissionee information even if we were just advertising as a commissioner (commissionableNode was false). This could lead to crashes due to calling things like GetCommissionableDataProvider() when we are not in fact commissionable and don't have one.
The fix is to reorder things a bit so we set up all the advertiseParameters state that both commissioners and commissionable share, and then condition all the commissionable-only bits on commissionableNode.