Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ZAP to tip. #24541

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Update ZAP to tip. #24541

merged 1 commit into from
Jan 20, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

Fixes bug in determining response commands when two clusters have the same response command name.

@bzbarsky-apple
Update ZAP to tip.
824fc6b 
Fixes bug in determining response commands when two clusters have
the same response command name.
@github-actions
Copy link

github-actions bot commented Jan 20, 2023 •
edited
Loading

PR #24541: Size comparison from 6648ef2 to 824fc6b

Increases (3 builds for nrfconnect, psoc6, telink)
platform target config section 6648ef2 824fc6b change % change
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1108968 1108984 16 0.0
text 772948 772952 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22580917 22580918 1 0.0
telink thermostat tlsr9518adk80d text 597086 597088 2 0.0
Decreases (4 builds for psoc6, telink)
platform target config section 6648ef2 824fc6b change % change
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27325031 27325029 -2 -0.0
light cy8ckit_062s2_43012 .debug_info 22362517 22362516 -1 -0.0
telink light-switch-app tlsr9518adk80d (read/write) 884180 884172 -8 -0.0
text 596326 596324 -2 -0.0
ota-requestor-app tlsr9518adk80d text 607444 607442 -2 -0.0
Full report (35 builds for cyw30739, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 6648ef2 824fc6b change % change
cyw30739 light cyw930739m2evb_01 (read/write) 584786 584786 0 0.0
.app_xip_area 461132 461132 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588518 588518 0 0.0
.app_xip_area 459568 459568 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549486 549486 0 0.0
.app_xip_area 431320 431320 0 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
esp32 all-clusters-app c3devkit (read only) 1220280 1220280 0 0.0
(read/write) 1786730 1786730 0 0.0
.dram0.bss 75824 75824 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 245256 245256 0 0.0
.flash.text 1220280 1220280 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1234167 1234167 0 0.0
(read/write) 559979 559979 0 0.0
.dram0.bss 80976 80976 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 311060 311060 0 0.0
.flash.text 1228783 1228783 0 0.0
.iram0.text 124803 124803 0 0.0
linux all-clusters-app debug (read only) 3121393 3121393 0 0.0
(read/write) 153008 153008 0 0.0
.bss 62464 62464 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 81688 81688 0 0.0
.dynamic 608 608 0 0.0
.got 4776 4776 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 281835 281835 0 0.0
.text 2654690 2654690 0 0.0
all-clusters-minimal-app debug (read only) 2933585 2933585 0 0.0
(read/write) 146416 146416 0 0.0
.bss 61600 61600 0 0.0
.data 2240 2240 0 0.0
.data.rel.ro 76104 76104 0 0.0
.dynamic 608 608 0 0.0
.got 4688 4688 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 280491 280491 0 0.0
.text 2471506 2471506 0 0.0
bridge-app debug (read only) 2497233 2497233 0 0.0
(read/write) 130976 130976 0 0.0
.bss 52512 52512 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68712 68712 0 0.0
.dynamic 608 608 0 0.0
.got 4608 4608 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 212544 212544 0 0.0
.text 2112818 2112818 0 0.0
chip-tool debug (read only) 11483729 11483729 0 0.0
(read/write) 646256 646256 0 0.0
.bss 26168 26168 0 0.0
.data 3042 3042 0 0.0
.data.rel.ro 610288 610288 0 0.0
.dynamic 608 608 0 0.0
.got 5352 5352 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 637157 637157 0 0.0
.text 9349316 9349316 0 0.0
chip-tool-ipv6only arm64 (read only) 10877428 10877428 0 0.0
(read/write) 695576 695576 0 0.0
.bss 34168 34168 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 639104 639104 0 0.0
.dynamic 560 560 0 0.0
.got 14104 14104 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 564084 564084 0 0.0
.text 8666260 8666260 0 0.0
lighting-app debug+rpc (read only) 2664809 2664809 0 0.0
(read/write) 130312 130312 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 71848 71848 0 0.0
.dynamic 608 608 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228512 228512 0 0.0
.text 2259458 2259458 0 0.0
lock-app debug (read only) 2623537 2623537 0 0.0
(read/write) 125360 125360 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 68824 68824 0 0.0
.dynamic 608 608 0 0.0
.got 4672 4672 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244680 244680 0 0.0
.text 2206866 2206866 0 0.0
ota-provider-app debug (read only) 2197433 2197433 0 0.0
(read/write) 105104 105104 0 0.0
.bss 46592 46592 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51320 51320 0 0.0
.dynamic 608 608 0 0.0
.got 3736 3736 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 196008 196008 0 0.0
.text 1861426 1861426 0 0.0
ota-requestor-app debug (read only) 2358913 2358913 0 0.0
(read/write) 112800 112800 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 56088 56088 0 0.0
.dynamic 608 608 0 0.0
.got 3736 3736 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202736 202736 0 0.0
.text 2007186 2007186 0 0.0
shell debug (read only) 2653961 2653961 0 0.0
(read/write) 137504 137504 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 72568 72568 0 0.0
.dynamic 608 608 0 0.0
.got 4136 4136 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 240018 240018 0 0.0
.text 2254050 2254050 0 0.0
thermostat-no-ble arm64 (read only) 2479452 2479452 0 0.0
(read/write) 143016 143016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149832 149832 0 0.0
.text 2069024 2069024 0 0.0
tv-app debug (read only) 3287857 3287857 0 0.0
(read/write) 259344 259344 0 0.0
.bss 170776 170776 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 77952 77952 0 0.0
.dynamic 608 608 0 0.0
.got 5008 5008 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 269464 269464 0 0.0
.text 2823954 2823954 0 0.0
tv-casting-app debug (read only) 5639409 5639409 0 0.0
(read/write) 160792 160792 0 0.0
.bss 52344 52344 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 99880 99880 0 0.0
.dynamic 608 608 0 0.0
.got 4928 4928 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 361369 361369 0 0.0
.text 4999906 4999906 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2461952 2461952 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1424596 1424596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1163144 1163144 0 0.0
bss 146736 146736 0 0.0
rodata 132632 132632 0 0.0
text 803556 803556 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1364784 1364784 0 0.0
bss 106036 106036 0 0.0
rodata 210116 210116 0 0.0
text 762796 762796 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108968 1108984 16 0.0
bss 145939 145939 0 0.0
rodata 109912 109912 0 0.0
text 772948 772952 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842032 842032 0 0.0
(read/write) 1747380 1747380 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188648 188648 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1247001 1247001 0 0.0
.debug_aranges 111184 111184 0 0.0
.debug_frame 373384 373384 0 0.0
.debug_info 27325031 27325029 -2 -0.0
.debug_line 3753075 3753075 0 0.0
.debug_loc 3642680 3642680 0 0.0
.debug_ranges 356400 356400 0 0.0
.debug_str 3470057 3470057 0 0.0
.heap 842032 842032 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575120 575120 0 0.0
.symtab 423200 423200 0 0.0
.text 1547680 1547680 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842800 842800 0 0.0
(read/write) 1688812 1688812 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187888 187888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1232808 1232808 0 0.0
.debug_aranges 110448 110448 0 0.0
.debug_frame 375828 375828 0 0.0
.debug_info 26886603 26886603 0 0.0
.debug_line 3761872 3761872 0 0.0
.debug_loc 3626080 3626080 0 0.0
.debug_ranges 354368 354368 0 0.0
.debug_str 3454863 3454863 0 0.0
.heap 842800 842800 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535500 535500 0 0.0
.symtab 408160 408160 0 0.0
.text 1489880 1489880 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1608924 1608924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1067806 1067806 0 0.0
.debug_aranges 102736 102736 0 0.0
.debug_frame 346404 346404 0 0.0
.debug_info 22362517 22362516 -1 -0.0
.debug_line 3328379 3328379 0 0.0
.debug_loc 3327954 3327954 0 0.0
.debug_ranges 318592 318592 0 0.0
.debug_str 3260660 3260660 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473441 473441 0 0.0
.symtab 377392 377392 0 0.0
.text 1418168 1418168 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1642956 1642956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1069852 1069852 0 0.0
.debug_aranges 103120 103120 0 0.0
.debug_frame 348204 348204 0 0.0
.debug_info 22580917 22580918 1 0.0
.debug_line 3329481 3329481 0 0.0
.debug_loc 3349469 3349469 0 0.0
.debug_ranges 320448 320448 0 0.0
.debug_str 3277067 3277067 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476376 476376 0 0.0
.symtab 379216 379216 0 0.0
.text 1447208 1447208 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147676 1147676 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 594776 594776 0 0.0
lock-app qpg6105+debug (read/write) 1115020 1115020 0 0.0
.bss 96868 96868 0 0.0
.data 852 852 0 0.0
.text 562116 562116 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1024752 1024752 0 0.0
bss 98172 98172 0 0.0
text 687932 687932 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 963092 963092 0 0.0
bss 97360 97360 0 0.0
text 651224 651224 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867724 867724 0 0.0
bss 89524 89524 0 0.0
text 581720 581720 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884180 884172 -8 -0.0
bss 89620 89620 0 0.0
text 596326 596324 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 962532 962532 0 0.0
bss 97676 97676 0 0.0
text 662338 662338 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898020 898020 0 0.0
bss 90568 90568 0 0.0
text 607444 607442 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887404 887404 0 0.0
bss 91008 91008 0 0.0
text 597086 597088 2 0.0

@Damian-Nordic Damian-Nordic merged commit 6ee19a3 into project-chip:master Jan 20, 2023
@bzbarsky-apple bzbarsky-apple deleted the update-zap branch January 20, 2023 14:12
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Update ZAP to tip. (project-chip#24541)
a68a855 
Fixes bug in determining response commands when two clusters have
the same response command name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmeg-sfy jmeg-sfy jmeg-sfy approved these changes

@ReneJosefsen ReneJosefsen ReneJosefsen approved these changes

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bzbarsky-apple @Damian-Nordic @ReneJosefsen @jmeg-sfy