-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Audio Output cluster XML with the spec. #24512
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-audio-output
Jan 21, 2023
Merged
Align naming in Audio Output cluster XML with the spec. #24512
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-audio-output
Jan 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
pjzander-signify
January 19, 2023 05:14
pullapprove
bot
requested review from
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 19, 2023 05:14
PR #24512: Size comparison from ddb21fe to 8cc19f5 Increases (12 builds for bl602, bl702, k32w, psoc6, qpg, telink)
Decreases (3 builds for esp32, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Jan 19, 2023
yufengwangca
approved these changes
Jan 20, 2023
bzbarsky-apple
force-pushed
the
rename-audio-output
branch
from
January 20, 2023 04:39
8cc19f5
to
7809c1c
Compare
PR #24512: Size comparison from cbc8fc4 to 7809c1c Increases (15 builds for bl702, cc13x2_26x2, linux, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, cc13x2_26x2, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-audio-output
branch
from
January 20, 2023 13:52
7809c1c
to
acdeb1d
Compare
PR #24512: Size comparison from f683392 to acdeb1d Increases (11 builds for bl602, bl702, psoc6, telink)
Decreases (3 builds for bl702, esp32, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-audio-output
branch
from
January 20, 2023 18:06
acdeb1d
to
b4bc344
Compare
PR #24512: Size comparison from 8517156 to b4bc344 Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Decreases (15 builds for bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-audio-output
branch
from
January 20, 2023 20:50
b4bc344
to
7874136
Compare
PR #24512: Size comparison from 63ee965 to 7874136 Increases (13 builds for bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…#24512) * Align naming in Audio Output cluster XML with the spec. * Regenerate generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.