-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-namespaced command ids. #24511
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-command-ids
Jan 19, 2023
Merged
Remove non-namespaced command ids. #24511
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-command-ids
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarmelveilleux
approved these changes
Jan 19, 2023
Those fail to compile when two clusters have a command with the same name, which is preventing us from aligning XML to the spec.
bzbarsky-apple
force-pushed
the
remove-command-ids
branch
from
January 19, 2023 04:05
c19539d
to
5a7819a
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt and
pjzander-signify
January 19, 2023 04:05
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
woody-apple and
xylophone21
January 19, 2023 04:05
jtung-apple
approved these changes
Jan 19, 2023
PR #24511: Size comparison from 57de760 to 5a7819a Increases (6 builds for bl702, cc13x2_26x2, esp32, psoc6, qpg)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
Those fail to compile when two clusters have a command with the same name, which is preventing us from aligning XML to the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those fail to compile when two clusters have a command with the same name, which is preventing us from aligning XML to the spec.