-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some typos in src/app/tests/suites/TestLevelControlWithOnOffDepen… #24476
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:Typos_TestLevelControlWithOnOffDependency
Jan 17, 2023
Merged
Fix some typos in src/app/tests/suites/TestLevelControlWithOnOffDepen… #24476
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:Typos_TestLevelControlWithOnOffDependency
Jan 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
January 17, 2023 18:44
pullapprove
bot
requested review from
mlepage-google,
msandstedt,
mspang,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
woody-apple,
xylophone21 and
yufengwangca
January 17, 2023 18:44
PR #24476: Size comparison from 59ab3ad to 4f3e709 Increases (7 builds for bl602, bl702, cyw30739, esp32, telink)
Decreases (7 builds for bl602, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When working on running yaml tests with the python parser I have found that
TestLevelControlWithOnOffDependency.yaml
tests contains some typos. While I can fix the parser to be fine with those I prefer to keeps is stricter.