-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tv-casting-app: Fixes for #24399 and #24400 #24401
Merged
chrisdecenzo
merged 4 commits into
project-chip:master
from
sharadb-amazon:fixes-20230112
Jan 25, 2023
Merged
tv-casting-app: Fixes for #24399 and #24400 #24401
chrisdecenzo
merged 4 commits into
project-chip:master
from
sharadb-amazon:fixes-20230112
Jan 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang and
rgoliver
January 12, 2023 23:52
sharadb-amazon
changed the title
Fixes 20230112
tv-casting-app: Fixes for #24399 and #24400
Jan 12, 2023
PR #24401: Size comparison from b36439e to 22ebf95 Increases (7 builds for bl702, cc13x2_26x2, k32w, nrfconnect, psoc6, qpg)
Decreases (4 builds for bl602, cc13x2_26x2, nrfconnect, psoc6)
Full report (29 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
sharadb-amazon
force-pushed
the
fixes-20230112
branch
from
January 13, 2023 00:49
22ebf95
to
89d640f
Compare
PR #24401: Size comparison from b36439e to 89d640f Increases (12 builds for cc13x2_26x2, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
chrisdecenzo
approved these changes
Jan 13, 2023
sharadb-amazon
force-pushed
the
fixes-20230112
branch
from
January 13, 2023 18:17
89d640f
to
08b6f11
Compare
PR #24401: Size comparison from a25af90 to 08b6f11 Increases (6 builds for bl702, cc13x2_26x2, linux, psoc6, telink)
Decreases (4 builds for cc13x2_26x2, esp32, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
fixes-20230112
branch
from
January 13, 2023 22:29
08b6f11
to
2814a74
Compare
PR #24401: Size comparison from cae6319 to 2814a74 Increases (9 builds for cc13x2_26x2, efr32, esp32, linux, psoc6, telink)
Decreases (9 builds for bl702, cc13x2_26x2, esp32, nrfconnect, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jan 16, 2023
examples/tv-casting-app/android/App/app/src/main/jni/cpp/TvCastingApp-JNI.cpp
Outdated
Show resolved
Hide resolved
sharadb-amazon
force-pushed
the
fixes-20230112
branch
from
January 17, 2023 18:00
2814a74
to
8c84893
Compare
PR #24401: Size comparison from 59ab3ad to 8c84893 Increases (10 builds for bl702, cc13x2_26x2, cyw30739, linux, psoc6, telink)
Decreases (5 builds for cc13x2_26x2, k32w, nrfconnect, psoc6, telink)
Full report (52 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
sharadb-amazon
force-pushed
the
fixes-20230112
branch
from
January 17, 2023 19:14
8c84893
to
6b6fea1
Compare
PR #24401: Size comparison from af3aa1a to fd56aad Increases (4 builds for bl602, bl702, esp32, nrfconnect)
Decreases (8 builds for cyw30739, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
… before- Matter server is initialized iOS tv-casting-app: Changed initApp to initializeApp and added return value
sharadb-amazon
force-pushed
the
fixes-20230112
branch
from
January 17, 2023 23:17
fd56aad
to
d0748e9
Compare
PR #24401: Size comparison from 808b9fe to d0748e9 Increases (14 builds for bl602, bl702, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (4 builds for cyw30739, esp32, telink)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
hawk248
approved these changes
Jan 25, 2023
sharadb-amazon
added a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Jan 25, 2023
…roject-chip#24401) * iOS tv-casting-app: Re-init binding handlers in startMatterServer API * tv-casting-app: Disconnecting from previous video player before connecting to the new one * Moving SetRotatingDeviceIdUniqueId to preInitApp so it always happens before- Matter server is initialized iOS tv-casting-app: Changed initApp to initializeApp and added return value * Addressing andy31415@'s feedback
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…roject-chip#24401) * iOS tv-casting-app: Re-init binding handlers in startMatterServer API * tv-casting-app: Disconnecting from previous video player before connecting to the new one * Moving SetRotatingDeviceIdUniqueId to preInitApp so it always happens before- Matter server is initialized iOS tv-casting-app: Changed initApp to initializeApp and added return value * Addressing andy31415@'s feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24399 and #24400
Change Summary
Testing
Tested using the Android/iOS tv-casting-apps running against the Linux tv-app