-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix java test CI #24396
Merged
yunhanw-google
merged 5 commits into
project-chip:master
from
yunhanw-google:feature/quick_fix_java_test
Jan 13, 2023
Merged
Fix java test CI #24396
yunhanw-google
merged 5 commits into
project-chip:master
from
yunhanw-google:feature/quick_fix_java_test
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24396: Size comparison from b36439e to d273f9d Increases (14 builds for bl702, cc13x2_26x2, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (4 builds for bl602, cc13x2_26x2, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
-- Initialize real result with optional empty so that test can wait for right result and pass.
yunhanw-google
force-pushed
the
feature/quick_fix_java_test
branch
from
January 12, 2023 22:57
d273f9d
to
9c940d1
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo and
chshu
January 12, 2023 22:57
pullapprove
bot
requested review from
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
ksperling-apple
January 12, 2023 22:57
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 12, 2023 22:57
PR #24396: Size comparison from b36439e to 9c940d1 Increases (13 builds for bl702, cc13x2_26x2, esp32, k32w, psoc6, qpg, telink)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24396: Size comparison from b36439e to 411a77f Increases (12 builds for bl602, cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, telink)
Decreases (6 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24396: Size comparison from b36439e to 2d83418 Increases (10 builds for bl602, bl702, cc13x2_26x2, k32w, psoc6, qpg, telink)
Decreases (6 builds for cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/quick_fix_java_test
branch
from
January 13, 2023 17:37
332ec7a
to
3c2f2bc
Compare
andy31415
approved these changes
Jan 13, 2023
PR #24396: Size comparison from a25af90 to 3c2f2bc Increases (5 builds for bl602, cc13x2_26x2, psoc6, telink)
Decreases (7 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/quick_fix_java_test
branch
from
January 13, 2023 18:59
3c2f2bc
to
6f61fd9
Compare
PR #24396: Size comparison from a25af90 to fc67ef9 Increases (9 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (11 builds for bl602, cc13x2_26x2, efr32, esp32, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* make CI failure with unexpected result -- Initialize real result with optional empty so that test can wait for right result and pass. * Fix unitialized optional result * disable discovery test * temporarily disable java discovery test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Java CI cannot detect the failure from java example test. we need to return the failure status code so that CI can detect it.
Previous PR #24311 fails the test, we need to correctly initialize the realResult so that test would wait for the realResult to be set and pass if everything is fine.
Previous PR #24007 the discovery test is failing, disable it temporarily.