[ICD] Initial Impl Active Threshold #24394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
pullapprove
bot
requested review from
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
jmartinez-silabs
approved these changes
Jan 12, 2023
|
PR #24394: Size comparison from b36439e to fa239ed Increases (15 builds for bl702, cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
jepenven-silabs
force-pushed
the
icd_active_threshold
branch
from
fa239ed to
dc8ccce
Compare
Damian-Nordic
approved these changes
Jan 13, 2023
|
PR #24394: Size comparison from 58e20ec to dc8ccce Increases (13 builds for cc13x2_26x2, cyw30739, k32w, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, esp32, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
| * Spec section 2.12.5 | ||
| */ | ||
| #ifndef CHIP_DEVICE_CONFIG_SED_ACTIVE_THRESHOLD | ||
| #define CHIP_DEVICE_CONFIG_SED_ACTIVE_THRESHOLD System::Clock::Milliseconds32(4000) |
There was a problem hiding this comment.
Any reason this wasn't 4000_ms32 like other things in this file?
| { | ||
| if (apAppState != nullptr) | ||
| { | ||
| static_cast<GenericThreadStackManagerImpl_OpenThread *>(apAppState)->SEDChangeMode(); |
There was a problem hiding this comment.
This looks wrong to me.
Let's say we go into active mode for an exchange, and then the exchange completes. We will start a timer to call this function.
If, before the timer fires, we enter active mode for some reason other than an exchange and then exit active mode, we will exit immediately, without waiting for this timer to fire.
What I think we need to do is that the timer starting successfully, if there was no timer so far, should count as an active mode consumer (and increase mActiveModeConsumers by 1). When the timer fires it should then decrement mActiveModeConsumers by 1.
Or something else to deal with this problem.
There was a problem hiding this comment.
@bzbarsky-apple It's not a problem as per the spec. section 2.12.5 specify SHOULD stay active, the case you've described is a possible corner case that doesn't go against this implementation. However this would have to be address when the Client Monitoring cluster will fully be implemented.
There was a problem hiding this comment.
This behavior is allowed by the spec, but it's still not the intended behavior of this implementation as far as I can tell...
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Initial Impl Active Threshold * Apply comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix of #24260
Implement sections 2.12.5 which is in direct contradiction with section 11.24.5.3 of the same spec (Global constant vs cluster attribute).
Main differences are that current implementation is based on a hard coded threshold value and respect the SHOULD instead of the SHALL. Meaning that in the rare corner case where no timer are available to postponed the Idle mode, a device COULD go to Idle mode immediately which is in accordance with section 2.12.5.
Tested on Silabs EFR32 platform