-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Initial Active Threshold time #24393
Closed
jepenven-silabs
wants to merge
1
commit into
project-chip:master
from
jepenven-silabs:icd_active_threshold
Closed
[ICD] Initial Active Threshold time #24393
jepenven-silabs
wants to merge
1
commit into
project-chip:master
from
jepenven-silabs:icd_active_threshold
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepenven-silabs
force-pushed
the
icd_active_threshold
branch
from
January 12, 2023 20:33
d7ffa32
to
140d978
Compare
PR #24393: Size comparison from b36439e to 140d978 Increases (14 builds for bl602, bl702, cc13x2_26x2, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (11 builds for bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, qpg)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix of #24260
Implement sections 2.12.5 which is in direct contradiction with section 11.24.5.3 of the same spec (Global constant vs cluster attribute).
Main differences are that current implementation is based on a hard coded threshold value and respect the
SHOULD
instead of theSHALL
. Meaning that in the rare corner case where no timer are available to postponed the Idle mode, a deviceCOULD
go to Idle mode immediately which is in accordance with section 2.12.5.Tested on Silabs EFR32 platform