-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Occupancy Sensing cluster XML with the spec. #24392
Merged
jmartinez-silabs
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-occupancy-sensing
Jan 18, 2023
Merged
Align naming in Occupancy Sensing cluster XML with the spec. #24392
jmartinez-silabs
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-occupancy-sensing
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
rgoliver and
saurabhst
January 12, 2023 19:49
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 12, 2023 19:49
PR #24392: Size comparison from b36439e to 2563d51 Increases (11 builds for bl702, cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (16 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, linux, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
approved these changes
Jan 13, 2023
jmartinez-silabs
approved these changes
Jan 13, 2023
bzbarsky-apple
force-pushed
the
rename-occupancy-sensing
branch
from
January 18, 2023 02:55
2563d51
to
e708807
Compare
PR #24392: Size comparison from 89c6fb6 to e708807 Increases (9 builds for cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Decreases (12 builds for bl602, bl702, linux, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-occupancy-sensing
branch
from
January 18, 2023 12:01
e708807
to
b5b3dfc
Compare
PR #24392: Size comparison from c5cb0dd to b5b3dfc Increases (9 builds for bl602, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (10 builds for bl602, bl702, esp32, linux, psoc6, telink)
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 18, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…-chip#24392) * Align naming in Occupancy Sensing cluster XML with the spec. * Auto-update ZAP files. * Regenerate generated code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.