[scripts] Reduce number of submodules checked out on boostrap #24383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When bootstrap.sh is run on a respository that has pigweed submodule already checked out, only update user-initialized submodules but do not initialize new ones. When checkout_submodules.py script is called without specifying platforms, by default only checkout common submodules, not associated with any specific platform. By the way, reduce the number of debug logs in the script. Signed-off-by: Damian Krolik <[email protected]>
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
Damian-Nordic
changed the title
|
PR #24383: Size comparison from dacb056 to caa47da Increases (6 builds for cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (13 builds for bl702, k32w, nrfconnect, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Jan 12, 2023
andy31415
approved these changes
Jan 12, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
When bootstrap.sh is run on a respository that has pigweed submodule already checked out, only update user-initialized submodules but do not initialize new ones. When checkout_submodules.py script is called without specifying platforms, by default only checkout common submodules, not associated with any specific platform. By the way, reduce the number of debug logs in the script. Signed-off-by: Damian Krolik <[email protected]> Signed-off-by: Damian Krolik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bootstrap.sh is run on a respository that has pigweed submodule already checked out, only update user-initialized submodules but do not initialize new ones. This is to respect user's choice not to import gigabytes of unnecessary submodules.
When checkout_submodules.py script is called without specifying platforms, by default only checkout common submodules, not associated with any specific platform. By the way, reduce the number of debug logs in the script.