Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] Do not log binary buffer with %s #24380

Merged
merged 1 commit into from
Jan 12, 2023
Merged

[Tizen] Do not log binary buffer with %s #24380

merged 1 commit into from
Jan 12, 2023

Conversation

arkq
Copy link
Contributor

@arkq arkq commented Jan 12, 2023

Problem

Printing binary buffer with %s might lead to Tizen logger corruption, so no more logs will be readable after such accident, e.g.:

INFO    I/CHIP    (  819): FP: Metadata for Fabric 0x1 persisted to storage.
INFO    I/CHIP    (  819): DL: Save data [f/1/o:$]
INFO    I/CHIP    (  819): DL: Save data [f/1/n:0$7$&Ç"ü'&Ç%M:7$$$0     A0ø├.▓ÿ¨Zõd=éWÚEù±¯­¾▀àÿµ▒╩╦MÚÝ*súÏR`»W¤p´6Þ»Q!╬r╦3î·¦+*Î7
INFO    I/CHIP    (  819): 5($60!¹)(=V■"-KÅ(Yö W▮╗×Í°┌1IÑ⎽î§␌ðA└▮1³¯▮
                                                                     @⎼¦┘!$È5Î╬ı↑E┴
INFO    I/CHIP    (  819): V┘ûØ4>ıûá←$¦├¨Ù
                                          ²öÇØ¢┘ºÁ◆▓<┼I%¼↑ÑU┼ÃÝ░WìK
INFO    I/CHIP    (  819): DL: S▒┴␊ ␍▒├▒ [°/1/␋:▮$7$&Ç"ü'&Ç%M:7$$▮      A^¢Û^▄çX╠Ë©I£┌E╣à␊(┌BÐø%Ì#6┴7]
INFO    I/CHIP    (  819): DL: S▒┴␊ ␍▒├▒ [°/1/⎼:▮$7$&Ç"ü'&Ç%M:7$$▮      AÆ*º[5[Ì*␍Îð┐LÈ■SþJΰï¤↓≠L1┐≥¨#NW¨EüB

Changes

  • print binary data with ChipLogByteSpan

Testing

Tested locally. After this patch Tizen logger no longer gets corrupted.

@arkq
[Tizen] Do not log binary buffer with %s
e8993d6 
Printing binary buffer with `%s` might lead to Tizen logger corruption,
so no more logs will be readable after such accident. Use dedicated byte
span logger for logging preferences data.
@github-actions github-actions bot added platform tizen For Tizen platform labels Jan 12, 2023
@pullapprove pullapprove bot added review - pending and removed platform tizen For Tizen platform labels Jan 12, 2023
@github-actions
Copy link

github-actions bot commented Jan 12, 2023 •
edited
Loading

PR #24380: Size comparison from dacb056 to e8993d6

Increases (7 builds for bl602, cc13x2_26x2, cyw30739, nrfconnect, telink)
platform target config section dacb056 e8993d6 change % change
bl602 lighting-app bl602 .text 1016646 1016648 2 0.0
bl602+rpc .text 1047634 1047636 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174404 174412 8 0.0
lock-ftd LP_CC2652R7 (read only) 674503 674511 8 0.0
.text 597664 597672 8 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585666 585674 8 0.0
.app_xip_area 462012 462020 8 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 804544 804548 4 0.0
telink ota-requestor-app tlsr9518adk80d text 607286 607288 2 0.0
Decreases (9 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
platform target config section dacb056 e8993d6 change % change
bl702 lighting-app bl702 .debug_info 39900397 39900395 -2 -0.0
.text 956874 956870 -4 -0.0
bl702+rpc .debug_info 44286220 44286219 -1 -0.0
.text 1033764 1033762 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677075 677067 -8 -0.0
.text 589460 589452 -8 -0.0
lock-ftd LP_CC2652R7 (read/write) 174504 174496 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 560335 560331 -4 -0.0
.flash.rodata 311408 311404 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26903755 26903754 -1 -0.0
telink contact-sensor-app tlsr9518adk80d (read/write) 867580 867572 -8 -0.0
text 581574 581570 -4 -0.0
lighting-app tlsr9518adk80d text 661890 661888 -2 -0.0
thermostat tlsr9518adk80d (read/write) 887128 887120 -8 -0.0
text 596814 596812 -2 -0.0
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section dacb056 e8993d6 change % change
bl602 lighting-app bl602 (read/write) 1329406 1329406 0 0.0
.bss 86926 86926 0 0.0
.data 9576 9576 0 0.0
.text 1016646 1016648 2 0.0
bl602+rpc (read/write) 1374902 1374902 0 0.0
.bss 94966 94966 0 0.0
.data 9976 9976 0 0.0
.text 1047634 1047636 2 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1194735 1194735 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1533431 1533431 0 0.0
.debug_aranges 132656 132656 0 0.0
.debug_frame 486996 486996 0 0.0
.debug_info 39900397 39900395 -2 -0.0
.debug_line 5228552 5228552 0 0.0
.debug_loc 3394501 3394501 0 0.0
.debug_ranges 372192 372192 0 0.0
.debug_str 3508116 3508116 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 115312 115312 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569337 569337 0 0.0
.symtab 172016 172016 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956874 956870 -4 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1286899 1286899 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1681901 1681901 0 0.0
.debug_aranges 140880 140880 0 0.0
.debug_frame 514708 514708 0 0.0
.debug_info 44286220 44286219 -1 -0.0
.debug_line 5626141 5626141 0 0.0
.debug_loc 3590508 3590508 0 0.0
.debug_ranges 395896 395896 0 0.0
.debug_str 3910726 3910726 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129776 129776 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629852 629852 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033764 1033762 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 677075 677067 -8 -0.0
(read/write) 174404 174412 8 0.0
.bss 81172 81172 0 0.0
.data 3380 3380 0 0.0
.rodata 87299 87299 0 0.0
.text 589460 589452 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640691 640691 0 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 77387 77387 0 0.0
.text 562984 562984 0 0.0
lock-ftd LP_CC2652R7 (read only) 674503 674511 8 0.0
(read/write) 174504 174496 -8 -0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 76359 76359 0 0.0
.text 597664 597672 8 0.0
lock-mtd LP_CC2652R7 (read only) 659563 659563 0 0.0
(read/write) 184708 184708 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 102443 102443 0 0.0
.text 556640 556640 0 0.0
pump-app LP_CC2652R7 (read only) 688215 688215 0 0.0
(read/write) 161528 161528 0 0.0
.bss 78756 78756 0 0.0
.data 3268 3268 0 0.0
.rodata 90431 90431 0 0.0
.text 597300 597300 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672235 672235 0 0.0
(read/write) 177612 177612 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86139 86139 0 0.0
.text 585616 585616 0 0.0
shell LP_CC2652R7 (read only) 668298 668298 0 0.0
(read/write) 185508 185508 0 0.0
.bss 83500 83500 0 0.0
.data 3376 3376 0 0.0
.rodata 84034 84034 0 0.0
.text 583952 583952 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585666 585674 8 0.0
.app_xip_area 462012 462020 8 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 589398 589398 0 0.0
.app_xip_area 460448 460448 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550022 550022 0 0.0
.app_xip_area 431856 431856 0 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974108 974108 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 819748 819748 0 0.0
BRD4161A+rs911x (read/write) 1037256 1037256 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 848576 848576 0 0.0
BRD4187C (read/write) 1147924 1147924 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 982244 982244 0 0.0
lock-app BRD4161A+wf200 (read/write) 1066792 1066792 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 906564 906564 0 0.0
window-app BRD4187C (read/write) 1140600 1140600 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 973480 973480 0 0.0
esp32 all-clusters-app c3devkit (read only) 1221430 1221430 0 0.0
(read/write) 1787114 1787114 0 0.0
.dram0.bss 75832 75832 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 245624 245624 0 0.0
.flash.text 1221430 1221430 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1235007 1235007 0 0.0
(read/write) 560335 560331 -4 -0.0
.dram0.bss 80984 80984 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 311408 311404 -4 -0.0
.flash.text 1229623 1229623 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 660316 660316 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 562068 562068 0 0.0
light k32w0+release (read/write) 671408 671408 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 591796 591796 0 0.0
lock k32w0+release (read/write) 631700 631700 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 551308 551308 0 0.0
linux all-clusters-app debug (read only) 3124817 3124817 0 0.0
(read/write) 153104 153104 0 0.0
.bss 62496 62496 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 81704 81704 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1192 1192 0 0.0
.rodata 282507 282507 0 0.0
.text 2657410 2657410 0 0.0
all-clusters-minimal-app debug (read only) 2937065 2937065 0 0.0
(read/write) 146480 146480 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 76120 76120 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 281195 281195 0 0.0
.text 2474226 2474226 0 0.0
bridge-app debug (read only) 2496489 2496489 0 0.0
(read/write) 130944 130944 0 0.0
.bss 52512 52512 0 0.0
.data 3632 3632 0 0.0
.data.rel.ro 68712 68712 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 212480 212480 0 0.0
.text 2112226 2112226 0 0.0
chip-tool debug (read only) 11289329 11289329 0 0.0
(read/write) 642416 642416 0 0.0
.bss 25880 25880 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 607168 607168 0 0.0
.dynamic 608 608 0 0.0
.got 5192 5192 0 0.0
.init 27 27 0 0.0
.init_array 752 752 0 0.0
.rodata 623365 623365 0 0.0
.text 9177396 9177396 0 0.0
chip-tool-ipv6only arm64 (read only) 10688460 10688460 0 0.0
(read/write) 691864 691864 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 636168 636168 0 0.0
.dynamic 560 560 0 0.0
.got 13960 13960 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 551068 551068 0 0.0
.text 8499076 8499076 0 0.0
lighting-app debug+rpc (read only) 2663953 2663953 0 0.0
(read/write) 130280 130280 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 71848 71848 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228448 228448 0 0.0
.text 2258754 2258754 0 0.0
lock-app debug (read only) 2622825 2622825 0 0.0
(read/write) 125328 125328 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 68824 68824 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244648 244648 0 0.0
.text 2206274 2206274 0 0.0
ota-provider-app debug (read only) 2196745 2196745 0 0.0
(read/write) 105072 105072 0 0.0
.bss 46560 46560 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 51320 51320 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 196008 196008 0 0.0
.text 1860834 1860834 0 0.0
ota-requestor-app debug (read only) 2358201 2358201 0 0.0
(read/write) 112800 112800 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 56088 56088 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202704 202704 0 0.0
.text 2006594 2006594 0 0.0
shell debug (read only) 2657481 2657481 0 0.0
(read/write) 137568 137568 0 0.0
.bss 57896 57896 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 72600 72600 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 240754 240754 0 0.0
.text 2256802 2256802 0 0.0
thermostat-no-ble arm64 (read only) 2478500 2478500 0 0.0
(read/write) 143016 143016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149792 149792 0 0.0
.text 2068112 2068112 0 0.0
tv-app debug (read only) 3286601 3286601 0 0.0
(read/write) 259344 259344 0 0.0
.bss 170776 170776 0 0.0
.data 3904 3904 0 0.0
.data.rel.ro 77952 77952 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1072 1072 0 0.0
.rodata 269400 269400 0 0.0
.text 2822850 2822850 0 0.0
tv-casting-app debug (read only) 5638697 5638697 0 0.0
(read/write) 160696 160696 0 0.0
.bss 52280 52280 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 99880 99880 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 361433 361433 0 0.0
.text 4999218 4999218 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2461848 2461848 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1424492 1424492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1165324 1165324 0 0.0
bss 146748 146748 0 0.0
rodata 133820 133820 0 0.0
text 804544 804548 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366968 1366968 0 0.0
bss 106048 106048 0 0.0
rodata 211308 211308 0 0.0
text 763788 763788 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1111168 1111168 0 0.0
bss 145947 145947 0 0.0
rodata 111104 111104 0 0.0
text 773944 773944 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842024 842024 0 0.0
(read/write) 1748716 1748716 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188656 188656 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1247585 1247585 0 0.0
.debug_aranges 111144 111144 0 0.0
.debug_frame 373232 373232 0 0.0
.debug_info 27342471 27342471 0 0.0
.debug_line 3753868 3753868 0 0.0
.debug_loc 3643136 3643136 0 0.0
.debug_ranges 356360 356360 0 0.0
.debug_str 3465988 3465988 0 0.0
.heap 842024 842024 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 576216 576216 0 0.0
.symtab 423744 423744 0 0.0
.text 1549008 1549008 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1690156 1690156 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1233392 1233392 0 0.0
.debug_aranges 110408 110408 0 0.0
.debug_frame 375676 375676 0 0.0
.debug_info 26903755 26903754 -1 -0.0
.debug_line 3762657 3762657 0 0.0
.debug_loc 3626536 3626536 0 0.0
.debug_ranges 354328 354328 0 0.0
.debug_str 3450852 3450852 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536706 536706 0 0.0
.symtab 408704 408704 0 0.0
.text 1491208 1491208 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1608844 1608844 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1067785 1067785 0 0.0
.debug_aranges 102608 102608 0 0.0
.debug_frame 346008 346008 0 0.0
.debug_info 22365996 22365996 0 0.0
.debug_line 3327851 3327851 0 0.0
.debug_loc 3326717 3326717 0 0.0
.debug_ranges 318464 318464 0 0.0
.debug_str 3256384 3256384 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473013 473013 0 0.0
.symtab 377200 377200 0 0.0
.text 1418088 1418088 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1642876 1642876 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1069831 1069831 0 0.0
.debug_aranges 102992 102992 0 0.0
.debug_frame 347808 347808 0 0.0
.debug_info 22584687 22584687 0 0.0
.debug_line 3328951 3328951 0 0.0
.debug_loc 3348305 3348305 0 0.0
.debug_ranges 320320 320320 0 0.0
.debug_str 3272218 3272218 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475730 475730 0 0.0
.symtab 379024 379024 0 0.0
.text 1447128 1447128 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1148044 1148044 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 595144 595144 0 0.0
lock-app qpg6105+debug (read/write) 1115036 1115036 0 0.0
.bss 96868 96868 0 0.0
.data 852 852 0 0.0
.text 562132 562132 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026288 1026288 0 0.0
bss 98184 98184 0 0.0
text 689096 689096 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964628 964628 0 0.0
bss 97368 97368 0 0.0
text 652386 652386 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867580 867572 -8 -0.0
bss 89524 89524 0 0.0
text 581574 581570 -4 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883888 883888 0 0.0
bss 89616 89616 0 0.0
text 596038 596038 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961860 961860 0 0.0
bss 97676 97676 0 0.0
text 661890 661888 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 897860 897860 0 0.0
bss 90568 90568 0 0.0
text 607286 607288 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887128 887120 -8 -0.0
bss 91004 91004 0 0.0
text 596814 596812 -2 -0.0

@andy31415 andy31415 enabled auto-merge (squash) January 12, 2023 14:06
@andy31415 andy31415 merged commit 361f324 into project-chip:master Jan 12, 2023
@arkq arkq deleted the tizen-log-byte-span branch January 12, 2023 14:07
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@arkq
[Tizen] Do not log binary buffer with %s (project-chip#24380)
a7bd446 
Printing binary buffer with `%s` might lead to Tizen logger corruption,
so no more logs will be readable after such accident. Use dedicated byte
span logger for logging preferences data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkq @andy31415 @Damian-Nordic