-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Darwin: Add vendorID and productID properties to MTRDeviceAttestationDeviceInfo #24335
Merged
andy31415
merged 2 commits into
project-chip:master
from
ksperling-apple:mtr-extract-vid-pid
Jan 10, 2023
Merged
Darwin: Add vendorID and productID properties to MTRDeviceAttestationDeviceInfo #24335
andy31415
merged 2 commits into
project-chip:master
from
ksperling-apple:mtr-extract-vid-pid
Jan 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex and
harsha-rajendran
January 10, 2023 01:51
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 10, 2023 01:51
ksperling-apple
changed the title
Add vendorID and productID properties to MTRDeviceAttestationDeviceInfo
Darwin: Add vendorID and productID properties to MTRDeviceAttestationDeviceInfo
Jan 10, 2023
PR #24335: Size comparison from 82bfcd5 to f93afb6 Increases (4 builds for cc13x2_26x2, esp32, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 10, 2023
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jan 14, 2023
These were just added in project-chip#24335
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Jan 14, 2023
These were just added in project-chip#24335
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this pull request
Mar 15, 2023
…Is. (#24426) These were just added in project-chip/connectedhomeip#24335
kkasperczyk-no
pushed a commit
to kkasperczyk-no/sdk-connectedhomeip
that referenced
this pull request
Mar 15, 2023
…Is. (#24426) These were just added in project-chip/connectedhomeip#24335
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…DeviceInfo (project-chip#24335) * Add Xcode file header templates * Add vendorID and productID properties to MTRDeviceAttestationDeviceInfo Fixes project-chip#23338
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…Is. (project-chip#24426) These were just added in project-chip#24335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23338
Also add Xcode header templates for new files (due to an Xcode bug an extra
//
ends up at the top of the file that needs to be manually removed.)