-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrfconnect] Added LOG dependency for CHIP_APP_LOG_LEVEL #24279
Merged
andy31415
merged 1 commit into
project-chip:master
from
kkasperczyk-no:release_build_fix
Jan 6, 2023
Merged
[nrfconnect] Added LOG dependency for CHIP_APP_LOG_LEVEL #24279
andy31415
merged 1 commit into
project-chip:master
from
kkasperczyk-no:release_build_fix
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHIP_APP_LOG_LEVEL tries to set default to LOG_DEFAULT_LEVEL, but if LOG is disabled for release build the assembler will fail to process it. Added LOG dependency to make sure that LOG_DEFAULT_LEVEL exists before using it.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
January 5, 2023 13:01
pullapprove
bot
requested review from
mspang,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 5, 2023 13:01
arkq
approved these changes
Jan 5, 2023
Damian-Nordic
approved these changes
Jan 5, 2023
PR #24279: Size comparison from 191b0b5 to 045716c Increases (8 builds for esp32, nrfconnect, psoc6, telink)
Decreases (12 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Full report (64 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 5, 2023
cletnick
pushed a commit
to cletnick/connectedhomeip
that referenced
this pull request
Jan 10, 2023
…p#24279) CHIP_APP_LOG_LEVEL tries to set default to LOG_DEFAULT_LEVEL, but if LOG is disabled for release build the assembler will fail to process it. Added LOG dependency to make sure that LOG_DEFAULT_LEVEL exists before using it.
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…p#24279) CHIP_APP_LOG_LEVEL tries to set default to LOG_DEFAULT_LEVEL, but if LOG is disabled for release build the assembler will fail to process it. Added LOG dependency to make sure that LOG_DEFAULT_LEVEL exists before using it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHIP_APP_LOG_LEVEL tries to set default to LOG_DEFAULT_LEVEL, but if LOG is disabled for release build the assembler will fail to process it.
Added LOG dependency to make sure that LOG_DEFAULT_LEVEL exists before using it.