Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tv-casting-app: On kBindingsChangedViaCluster, connect to VideoPlayer if already commissioned with it #24268

Merged
merged 3 commits into from
Jan 5, 2023
Merged

tv-casting-app: On kBindingsChangedViaCluster, connect to VideoPlayer if already commissioned with it #24268

merged 3 commits into from
Jan 5, 2023

Conversation

sharadb-amazon
Copy link
Contributor

Fixes #24267

Change summary

  1. Added a flag udcInProgress to CastingServer to track if UDC is in progress
  2. On kBindingsChangedViaCluster, if we find UDC is in progress, we select the video player (find its nodeId and fabricIndex) from the cache which matches the one we were trying to commission with now (based on IP addresses and device names)
  3. Then we connect to the video player found above and call the commissioningCompleteCallback.

Testing

Tested with the Android tv-casting-app and the Linux tv-app as per the instructions in #24267

@github-actions
Copy link

github-actions bot commented Jan 4, 2023 •
edited
Loading

PR #24268: Size comparison from b921798 to 604dafe

Decreases (1 build for qpg)
platform target config section b921798 604dafe change % change
qpg lighting-app qpg6105+debug (read/write) 1150868 1150860 -8 -0.0
.text 597968 597960 -8 -0.0
Full report (9 builds for k32w, mbed, nrfconnect, qpg)
platform target config section b921798 604dafe change % change
k32w contact k32w0+release (read/write) 662652 662652 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 564404 564404 0 0.0
light k32w0+release (read/write) 673352 673352 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 593740 593740 0 0.0
lock k32w0+release (read/write) 634196 634196 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 553804 553804 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464000 2464000 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1426644 1426644 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1169987 1169987 0 0.0
bss 143621 143621 0 0.0
rodata 136368 136368 0 0.0
text 810132 810132 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1349118 1349118 0 0.0
bss 105132 105132 0 0.0
rodata 204292 204292 0 0.0
text 755184 755184 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1115615 1115615 0 0.0
bss 142856 142856 0 0.0
rodata 112684 112684 0 0.0
text 780288 780288 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150868 1150860 -8 -0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 597968 597960 -8 -0.0
lock-app qpg6105+debug (read/write) 1117476 1117476 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 564572 564572 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 4, 2023 •
edited
Loading

PR #24268: Size comparison from 715a2bc to e7a9b88

Increases above 0.2%:

platform target config section 715a2bc e7a9b88 change % change
linux tv-casting-app debug .rodata 360345 361081 736 0.2
Increases (5 builds for bl602, linux, psoc6, telink)
platform target config section 715a2bc e7a9b88 change % change
bl602 lighting-app bl602 .text 1021342 1021344 2 0.0
bl602+rpc .text 1052294 1052296 2 0.0
linux tv-casting-app debug (read only) 5610849 5613025 2176 0.0
.rodata 360345 361081 736 0.2
.text 4972914 4974354 1440 0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22287803 22287804 1 0.0
telink thermostat tlsr9518adk80d text 637260 637262 2 0.0
Decreases (9 builds for bl702, cyw30739, nrfconnect, psoc6, telink)
platform target config section 715a2bc e7a9b88 change % change
bl702 lighting-app bl702 .debug_info 39729775 39729773 -2 -0.0
.text 956188 956184 -4 -0.0
bl702+rpc .debug_info 44096679 44096678 -1 -0.0
.text 1032986 1032984 -2 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 592118 592110 -8 -0.0
.app_xip_area 463168 463160 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1115775 1115759 -16 -0.0
text 780434 780430 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27094289 27094288 -1 -0.0
all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26830725 26830724 -1 -0.0
telink all-clusters-app tlsr9518adk80d text 724800 724798 -2 -0.0
light-switch-app tlsr9518adk80d text 636564 636562 -2 -0.0
ota-requestor-app tlsr9518adk80d text 647820 647816 -4 -0.0
Full report (44 builds for bl602, bl702, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 715a2bc e7a9b88 change % change
bl602 lighting-app bl602 (read/write) 1343802 1343802 0 0.0
.bss 86510 86510 0 0.0
.data 9584 9584 0 0.0
.text 1021342 1021344 2 0.0
bl602+rpc (read/write) 1389250 1389250 0 0.0
.bss 94550 94550 0 0.0
.data 9976 9976 0 0.0
.text 1052294 1052296 2 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195135 1195135 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1532720 1532720 0 0.0
.debug_aranges 132536 132536 0 0.0
.debug_frame 486552 486552 0 0.0
.debug_info 39729775 39729773 -2 -0.0
.debug_line 5208746 5208746 0 0.0
.debug_loc 3387909 3387909 0 0.0
.debug_ranges 363864 363864 0 0.0
.debug_str 3503627 3503627 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 116400 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569359 569359 0 0.0
.symtab 172000 172000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956188 956184 -4 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1287187 1287187 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1680670 1680670 0 0.0
.debug_aranges 140664 140664 0 0.0
.debug_frame 514084 514084 0 0.0
.debug_info 44096679 44096678 -1 -0.0
.debug_line 5605279 5605279 0 0.0
.debug_loc 3583174 3583174 0 0.0
.debug_ranges 387472 387472 0 0.0
.debug_str 3906162 3906162 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130848 130848 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629948 629948 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1032986 1032984 -2 -0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588290 588290 0 0.0
.app_xip_area 464636 464636 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592118 592110 -8 -0.0
.app_xip_area 463168 463160 -8 -0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551982 551982 0 0.0
.app_xip_area 433816 433816 0 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976612 976612 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 822252 822252 0 0.0
BRD4161A+rs911x (read/write) 1039344 1039344 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 850664 850664 0 0.0
BRD4187C (read/write) 1150212 1150212 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 984532 984532 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069328 1069328 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 909100 909100 0 0.0
window-app BRD4187C (read/write) 1142856 1142856 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 975736 975736 0 0.0
k32w contact k32w0+release (read/write) 662796 662796 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 564548 564548 0 0.0
light k32w0+release (read/write) 673496 673496 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 593884 593884 0 0.0
lock k32w0+release (read/write) 634324 634324 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 553932 553932 0 0.0
linux all-clusters-app debug (read only) 3116217 3116217 0 0.0
(read/write) 158568 158568 0 0.0
.bss 62432 62432 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87240 87240 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281835 281835 0 0.0
.text 2649698 2649698 0 0.0
all-clusters-minimal-app debug (read only) 2939673 2939673 0 0.0
(read/write) 149968 149968 0 0.0
.bss 61632 61632 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79608 79608 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 281227 281227 0 0.0
.text 2476802 2476802 0 0.0
bridge-app debug (read only) 2498649 2498649 0 0.0
(read/write) 133088 133088 0 0.0
.bss 52512 52512 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 70696 70696 0 0.0
.dynamic 608 608 0 0.0
.got 4600 4600 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 212512 212512 0 0.0
.text 2114354 2114354 0 0.0
chip-tool debug (read only) 11157457 11157457 0 0.0
(read/write) 646880 646880 0 0.0
.bss 25880 25880 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 611648 611648 0 0.0
.dynamic 608 608 0 0.0
.got 5192 5192 0 0.0
.init 27 27 0 0.0
.init_array 736 736 0 0.0
.rodata 606565 606565 0 0.0
.text 9051716 9051716 0 0.0
chip-tool-ipv6only arm64 (read only) 10571348 10571348 0 0.0
(read/write) 696104 696104 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 640528 640528 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 536036 536036 0 0.0
.text 8386852 8386852 0 0.0
lighting-app debug+rpc (read only) 2665905 2665905 0 0.0
(read/write) 132456 132456 0 0.0
.bss 49952 49952 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 74024 74024 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228448 228448 0 0.0
.text 2260706 2260706 0 0.0
lock-app debug (read only) 2625001 2625001 0 0.0
(read/write) 127440 127440 0 0.0
.bss 48384 48384 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70936 70936 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244680 244680 0 0.0
.text 2208418 2208418 0 0.0
ota-provider-app debug (read only) 2198921 2198921 0 0.0
(read/write) 105872 105872 0 0.0
.bss 46560 46560 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 52120 52120 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 196008 196008 0 0.0
.text 1863010 1863010 0 0.0
ota-requestor-app debug (read only) 2360505 2360505 0 0.0
(read/write) 113920 113920 0 0.0
.bss 49056 49056 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57208 57208 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202704 202704 0 0.0
.text 2008898 2008898 0 0.0
shell debug (read only) 2648545 2648545 0 0.0
(read/write) 143032 143032 0 0.0
.bss 57832 57832 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78136 78136 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 240050 240050 0 0.0
.text 2248786 2248786 0 0.0
thermostat-no-ble arm64 (read only) 2479884 2479884 0 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149704 149704 0 0.0
.text 2069584 2069584 0 0.0
tv-app debug (read only) 3288321 3288321 0 0.0
(read/write) 262280 262280 0 0.0
.bss 170776 170776 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80544 80544 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 269080 269080 0 0.0
.text 2824914 2824914 0 0.0
tv-casting-app debug (read only) 5610849 5613025 2176 0.0
(read/write) 162640 162640 0 0.0
.bss 52152 52152 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101960 101960 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 360345 361081 736 0.2
.text 4972914 4974354 1440 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2464128 2464128 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1426772 1426772 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1170131 1170131 0 0.0
bss 143621 143621 0 0.0
rodata 136368 136368 0 0.0
text 810278 810278 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1349278 1349278 0 0.0
bss 105132 105132 0 0.0
rodata 204292 204292 0 0.0
text 755330 755330 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1115775 1115759 -16 -0.0
bss 142856 142856 0 0.0
rodata 112684 112684 0 0.0
text 780434 780430 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842056 842056 0 0.0
(read/write) 1750100 1750100 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238094 1238094 0 0.0
.debug_aranges 110816 110816 0 0.0
.debug_frame 372188 372188 0 0.0
.debug_info 27094289 27094288 -1 -0.0
.debug_line 3723394 3723394 0 0.0
.debug_loc 3628355 3628355 0 0.0
.debug_ranges 346712 346712 0 0.0
.debug_str 3459213 3459213 0 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 572583 572583 0 0.0
.symtab 422160 422160 0 0.0
.text 0 0 0 0.0
1550424 1550424 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1692628 1692628 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229985 1229985 0 0.0
.debug_aranges 110288 110288 0 0.0
.debug_frame 375244 375244 0 0.0
.debug_info 26830725 26830724 -1 -0.0
.debug_line 3742292 3742292 0 0.0
.debug_loc 3615961 3615961 0 0.0
.debug_ranges 345328 345328 0 0.0
.debug_str 3448225 3448225 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536672 536672 0 0.0
.symtab 408592 408592 0 0.0
.text 1493680 1493680 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1610828 1610828 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064762 1064762 0 0.0
.debug_aranges 102488 102488 0 0.0
.debug_frame 345576 345576 0 0.0
.debug_info 22287803 22287804 1 0.0
.debug_line 3307319 3307319 0 0.0
.debug_loc 3313852 3313852 0 0.0
.debug_ranges 309464 309464 0 0.0
.debug_str 3253811 3253811 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472997 472997 0 0.0
.symtab 376960 376960 0 0.0
.text 1420072 1420072 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1644780 1644780 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066580 1066580 0 0.0
.debug_aranges 102872 102872 0 0.0
.debug_frame 347376 347376 0 0.0
.debug_info 22506163 22506163 0 0.0
.debug_line 3308432 3308432 0 0.0
.debug_loc 3335391 3335391 0 0.0
.debug_ranges 311320 311320 0 0.0
.debug_str 3269649 3269649 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475714 475714 0 0.0
.symtab 378960 378960 0 0.0
.text 1449032 1449032 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151004 1151004 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 598104 598104 0 0.0
lock-app qpg6105+debug (read/write) 1117620 1117620 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 564716 564716 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1068724 1068724 0 0.0
bss 97632 97632 0 0.0
text 724800 724798 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1008024 1008024 0 0.0
bss 96856 96856 0 0.0
text 689954 689954 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 929472 929472 0 0.0
bss 89104 89104 0 0.0
text 636564 636562 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1007432 1007432 0 0.0
bss 97156 97156 0 0.0
text 702340 702340 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 943060 943060 0 0.0
bss 90052 90052 0 0.0
text 647820 647816 -4 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932628 932628 0 0.0
bss 90496 90496 0 0.0
text 637260 637262 2 0.0

@github-actions
Copy link

github-actions bot commented Jan 4, 2023 •
edited
Loading

PR #24268: Size comparison from 5f3dda9 to 094432c

Increases (1 build for qpg)
platform target config section 5f3dda9 094432c change % change
qpg lighting-app qpg6105+debug (read/write) 1149548 1149556 8 0.0
.text 596648 596656 8 0.0
Full report (6 builds for k32w, mbed, qpg)
platform target config section 5f3dda9 094432c change % change
k32w contact k32w0+release (read/write) 661340 661340 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 563092 563092 0 0.0
light k32w0+release (read/write) 672216 672216 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 592604 592604 0 0.0
lock k32w0+release (read/write) 632884 632884 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 552492 552492 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2462848 2462848 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1425492 1425492 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149548 1149556 8 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 596648 596656 8 0.0
lock-app qpg6105+debug (read/write) 1116044 1116044 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 563140 563140 0 0.0

@github-actions
Copy link

github-actions bot commented Jan 4, 2023 •
edited
Loading

PR #24268: Size comparison from 5f3dda9 to 423d8c4

Increases (13 builds for bl602, bl702, k32w, nrfconnect, psoc6, qpg, telink)
platform target config section 5f3dda9 423d8c4 change % change
bl602 lighting-app bl602 (read/write) 1344618 1344626 8 0.0
.text 1022160 1022164 4 0.0
bl602+rpc (read/write) 1390066 1390074 8 0.0
.text 1053112 1053116 4 0.0
bl702 lighting-app bl702+rpc .debug_info 44090297 44090299 2 0.0
.text 1033802 1033806 4 0.0
k32w contact k32w0+release (read/write) 661340 661356 16 0.0
.text 563092 563108 16 0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 753622 753626 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 778626 778630 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27078698 27078700 2 0.0
lock cy8ckit_062s2_43012 .debug_info 22496098 22496099 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1149548 1149556 8 0.0
.text 596648 596656 8 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 689962 689966 4 0.0
light-switch-app tlsr9518adk80d text 636564 636568 4 0.0
lighting-app tlsr9518adk80d (read/write) 1007432 1007440 8 0.0
text 702344 702346 2 0.0
ota-requestor-app tlsr9518adk80d text 647822 647824 2 0.0
Decreases (4 builds for psoc6, telink)
platform target config section 5f3dda9 423d8c4 change % change
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26815064 26815063 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22277406 22277405 -1 -0.0
telink all-clusters-app tlsr9518adk80d text 724816 724814 -2 -0.0
thermostat tlsr9518adk80d (read/write) 932644 932636 -8 -0.0
text 637274 637272 -2 -0.0
Full report (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 5f3dda9 423d8c4 change % change
bl602 lighting-app bl602 (read/write) 1344618 1344626 8 0.0
.bss 86510 86510 0 0.0
.data 9584 9584 0 0.0
.text 1022160 1022164 4 0.0
bl602+rpc (read/write) 1390066 1390074 8 0.0
.bss 94550 94550 0 0.0
.data 9976 9976 0 0.0
.text 1053112 1053116 4 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195951 1195951 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1534619 1534619 0 0.0
.debug_aranges 132536 132536 0 0.0
.debug_frame 486544 486544 0 0.0
.debug_info 39723332 39723332 0 0.0
.debug_line 5218349 5218349 0 0.0
.debug_loc 3391451 3391451 0 0.0
.debug_ranges 371816 371816 0 0.0
.debug_str 3503451 3503451 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 116400 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569359 569359 0 0.0
.symtab 172000 172000 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
957006 957006 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1288003 1288003 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1682744 1682744 0 0.0
.debug_aranges 140664 140664 0 0.0
.debug_frame 514076 514076 0 0.0
.debug_info 44090297 44090299 2 0.0
.debug_line 5614882 5614882 0 0.0
.debug_loc 3586745 3586745 0 0.0
.debug_ranges 395424 395424 0 0.0
.debug_str 3905986 3905986 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130848 130848 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629948 629948 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033802 1033806 4 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586850 586850 0 0.0
.app_xip_area 463196 463196 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 590550 590550 0 0.0
.app_xip_area 461600 461600 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550710 550710 0 0.0
.app_xip_area 432544 432544 0 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 975124 975124 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 820764 820764 0 0.0
BRD4161A+rs911x (read/write) 1038320 1038320 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 849640 849640 0 0.0
BRD4187C (read/write) 1149004 1149004 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 983324 983324 0 0.0
lock-app BRD4161A+wf200 (read/write) 1067840 1067840 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 907612 907612 0 0.0
window-app BRD4187C (read/write) 1141808 1141808 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 974688 974688 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219576 1219576 0 0.0
(read/write) 1791050 1791050 0 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248488 248488 0 0.0
.flash.text 1219576 1219576 0 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233447 1233447 0 0.0
(read/write) 564267 564267 0 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314260 314260 0 0.0
.flash.text 1228063 1228063 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 661340 661356 16 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 563092 563108 16 0.0
light k32w0+release (read/write) 672216 672216 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 592604 592604 0 0.0
lock k32w0+release (read/write) 632884 632884 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 552492 552492 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10568876 10568876 0 0.0
(read/write) 696104 696104 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 640528 640528 0 0.0
.dynamic 560 560 0 0.0
.got 13840 13840 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 536044 536044 0 0.0
.text 8384372 8384372 0 0.0
thermostat-no-ble arm64 (read only) 2478452 2478452 0 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149712 149712 0 0.0
.text 2068144 2068144 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2462848 2462848 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1425492 1425492 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1168227 1168227 0 0.0
bss 143621 143621 0 0.0
rodata 136368 136368 0 0.0
text 808376 808376 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1347566 1347566 0 0.0
bss 105132 105132 0 0.0
rodata 204292 204292 0 0.0
text 753622 753626 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1113967 1113967 0 0.0
bss 142856 142856 0 0.0
rodata 112684 112684 0 0.0
text 778626 778630 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842056 842056 0 0.0
(read/write) 1749268 1749268 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1243455 1243455 0 0.0
.debug_aranges 110824 110824 0 0.0
.debug_frame 372216 372216 0 0.0
.debug_info 27078698 27078700 2 0.0
.debug_line 3734352 3734352 0 0.0
.debug_loc 3635403 3635403 0 0.0
.debug_ranges 355496 355496 0 0.0
.debug_str 3459037 3459037 0 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 572583 572583 0 0.0
.symtab 422416 422416 0 0.0
.text 1549592 1549592 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1691908 1691908 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1235236 1235236 0 0.0
.debug_aranges 110296 110296 0 0.0
.debug_frame 375272 375272 0 0.0
.debug_info 26815064 26815063 -1 -0.0
.debug_line 3753250 3753250 0 0.0
.debug_loc 3623009 3623009 0 0.0
.debug_ranges 354112 354112 0 0.0
.debug_str 3448049 3448049 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536672 536672 0 0.0
.symtab 408688 408688 0 0.0
.text 1492960 1492960 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1609916 1609916 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1068625 1068625 0 0.0
.debug_aranges 102496 102496 0 0.0
.debug_frame 345604 345604 0 0.0
.debug_info 22277406 22277405 -1 -0.0
.debug_line 3319279 3319279 0 0.0
.debug_loc 3323158 3323158 0 0.0
.debug_ranges 318248 318248 0 0.0
.debug_str 3253635 3253635 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472997 472997 0 0.0
.symtab 377184 377184 0 0.0
.text 1419160 1419160 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1643932 1643932 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1070425 1070425 0 0.0
.debug_aranges 102880 102880 0 0.0
.debug_frame 347404 347404 0 0.0
.debug_info 22496098 22496099 1 0.0
.debug_line 3320445 3320445 0 0.0
.debug_loc 3344747 3344747 0 0.0
.debug_ranges 320104 320104 0 0.0
.debug_str 3269473 3269473 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475714 475714 0 0.0
.symtab 379008 379008 0 0.0
.text 1448184 1448184 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1149548 1149556 8 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 596648 596656 8 0.0
lock-app qpg6105+debug (read/write) 1116044 1116044 0 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 563140 563140 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1068740 1068740 0 0.0
bss 97632 97632 0 0.0
text 724816 724814 -2 -0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1008032 1008032 0 0.0
bss 96856 96856 0 0.0
text 689962 689966 4 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 929472 929472 0 0.0
bss 89104 89104 0 0.0
text 636564 636568 4 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1007432 1007440 8 0.0
bss 97156 97156 0 0.0
text 702344 702346 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 943068 943068 0 0.0
bss 90052 90052 0 0.0
text 647822 647824 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932644 932636 -8 -0.0
bss 90496 90496 0 0.0
text 637274 637272 -2 -0.0

@chrisdecenzo chrisdecenzo merged commit 7fe6577 into project-chip:master Jan 5, 2023
sharadb-amazon added a commit to sharadb-amazon/connectedhomeip that referenced this pull request Jan 5, 2023
@sharadb-amazon
tv-casting-app: On kBindingsChangedViaCluster, connect to VideoPlayer…
72353a0 
… if already commissioned with it (project-chip#24268)

* tv-casting-app: On kBindingsChangedViaCluster, connect to VideoPlayer if already commissioned with it

* Addressing chrisdecenzo@'s feedback

* Addressing bzbarsky-apple@'s feedback
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@sharadb-amazon
tv-casting-app: On kBindingsChangedViaCluster, connect to VideoPlayer…
511ac47 
… if already commissioned with it (project-chip#24268)

* tv-casting-app: On kBindingsChangedViaCluster, connect to VideoPlayer if already commissioned with it

* Addressing chrisdecenzo@'s feedback

* Addressing bzbarsky-apple@'s feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@chrisdecenzo chrisdecenzo chrisdecenzo approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] tv-casting-app does not connect to tv-app on recommissioning
3 participants
@sharadb-amazon @chrisdecenzo @bzbarsky-apple