-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Diagnostic Logs cluster XML with the spec. #24266
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-diagnostic-logs
Jan 6, 2023
Merged
Align naming in Diagnostic Logs cluster XML with the spec. #24266
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-diagnostic-logs
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
rgoliver and
robszewczyk
January 4, 2023 19:57
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 4, 2023 19:57
bzbarsky-apple
force-pushed
the
rename-diagnostic-logs
branch
from
January 4, 2023 19:57
1c4a416
to
550ffb3
Compare
PR #24266: Size comparison from 1dd6520 to 550ffb3 Increases (5 builds for bl702, cc13x2_26x2, linux, psoc6, telink)
Decreases (13 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 5, 2023
tcarmelveilleux
approved these changes
Jan 6, 2023
ReneJosefsen
approved these changes
Jan 6, 2023
jtung-apple
approved these changes
Jan 6, 2023
cletnick
pushed a commit
to cletnick/connectedhomeip
that referenced
this pull request
Jan 10, 2023
…hip#24266) * Align naming in Diagnostic Logs cluster XML with the spec. * Regenerate generated files.
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…hip#24266) * Align naming in Diagnostic Logs cluster XML with the spec. * Regenerate generated files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes. The rest is code-generated.