-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infineon PSoC6] Update Security type to unknown for Proper Commissioning #24246
Merged
andy31415
merged 1 commit into
project-chip:master
from
praveenCY:topic/pucn_removesecuritytype
Jan 18, 2023
Merged
[Infineon PSoC6] Update Security type to unknown for Proper Commissioning #24246
andy31415
merged 1 commit into
project-chip:master
from
praveenCY:topic/pucn_removesecuritytype
Jan 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis and
franck-apple
January 4, 2023 01:28
pullapprove
bot
requested review from
tecimovic,
yufengwangca,
woody-apple,
yunhanw-google,
tehampson,
xylophone21,
turon,
vijs and
vivien-apple
January 4, 2023 01:28
PR #24246: Size comparison from 23e5fb2 to afbe70b Increases (10 builds for bl602, bl702, nrfconnect, psoc6, telink)
Decreases (3 builds for psoc6, telink)
Full report (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 4, 2023
praveenCY
force-pushed
the
topic/pucn_removesecuritytype
branch
from
January 9, 2023 18:52
afbe70b
to
d2a832b
Compare
PR #24246: Size comparison from e7347ea to d2a832b Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (5 builds for bl602, cc13x2_26x2, qpg, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
praveenCY
force-pushed
the
topic/pucn_removesecuritytype
branch
from
January 16, 2023 03:16
d2a832b
to
d02e7ce
Compare
PR #24246: Size comparison from b4c2827 to d02e7ce Increases (5 builds for bl702, esp32, psoc6, telink)
Decreases (7 builds for bl602, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Infineon PSoC6 Station Security type is hardcoded to WPA2 PSK which prevents connection to WPA3 routers.
Soluton
Connect API already has logic to find the Security type of SSID during Join process when security type is configured as UNKNOWN
Testing
Tested manually using Chip-tool