-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in Descriptor cluster XML with the spec. #24238
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-descriptor-bits
Jan 3, 2023
Merged
Align naming in Descriptor cluster XML with the spec. #24238
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-descriptor-bits
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
mspang,
rgoliver,
robszewczyk and
saurabhst
January 3, 2023 14:32
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 3, 2023 14:32
tehampson
approved these changes
Jan 3, 2023
bzbarsky-apple
force-pushed
the
rename-descriptor-bits
branch
from
January 3, 2023 14:56
77b34bd
to
bdde932
Compare
msandstedt
approved these changes
Jan 3, 2023
PR #24238: Size comparison from f8aa1df to bdde932 Increases (8 builds for bl602, bl702, linux, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-descriptor-bits
branch
from
January 3, 2023 16:50
bdde932
to
e0d96e5
Compare
PR #24238: Size comparison from a83ce32 to e0d96e5 Increases (9 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Decreases (3 builds for bl602, cc13x2_26x2, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
rename-descriptor-bits
branch
from
January 3, 2023 20:19
e0d96e5
to
41b53c0
Compare
PR #24238: Size comparison from a2a3ac1 to 41b53c0 Increases (8 builds for bl702, linux, psoc6, telink)
Decreases (6 builds for bl602, bl702, cyw30739, esp32, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first commit contains manual changes.