Expose commissionerNodeId as a variable for yaml #24197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaml can now use commissionerNodeId directly in an argument or response and the generated code will fill in the commissionerNodeId of the current commissioner.
|
PR #24197: Size comparison from 443128a to 8538379 Increases (1 build for linux)
Decreases (1 build for nrfconnect)
Full report (11 builds for k32w, linux, mbed, nrfconnect, qpg)
|
tehampson
approved these changes
Dec 22, 2022
examples/darwin-framework-tool/templates/tests/partials/test_cluster.zapt
Show resolved
Hide resolved
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
ksperling-apple
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple and
xylophone21
|
PR #24197: Size comparison from 443128a to 1a7a3d2 Increases above 0.2%:
Increases (4 builds for cc13x2_26x2, cyw30739, linux)
Decreases (8 builds for bl602, cc13x2_26x2, esp32, nrfconnect, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
- useable on response and argument - usable for different identities - added test
|
PR #24197: Size comparison from ff8fe37 to 3ea7c80 Increases above 0.2%:
Increases (9 builds for bl602, linux, nrfconnect, telink)
Decreases (8 builds for bl702, cyw30739, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #24197: Size comparison from f104782 to e508b7e Increases above 0.2%:
Increases (8 builds for bl602, bl702, esp32, linux, psoc6, telink)
Decreases (5 builds for bl602, k32w, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cecille
commented
Jan 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Expose commissionerNodeId as a variable for yaml yaml can now use commissionerNodeId directly in an argument or response and the generated code will fill in the commissionerNodeId of the current commissioner. * Two more zap files. * Restyled by clang-format * Make node id useable for different identities - useable on response and argument - usable for different identities - added test * re-compile zap * Add comment * Restyled by prettier-yaml * Add commissioner node id to placeholder * Update src/app/tests/suites/TestCommissionerNodeId.yaml * Update zap Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yaml can now use commissionerNodeId directly in an argument or response and the generated code will fill in the commissionerNodeId of the current commissioner.
This is required to automate the ACE tests, as well as TC-SC-5.1 and TC-SC-5.2. Without this, we will need to do them in python as the darwin framework does not use a consistent commissioner node id for commissioning.