Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChipLog* calls in darwin-framework-tool itself to work right. #24195

Merged
merged 1 commit into from
Jan 3, 2023
Merged

Fix ChipLog* calls in darwin-framework-tool itself to work right. #24195

merged 1 commit into from
Jan 3, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple commented Dec 22, 2022 •
edited
Loading

REVIEW NOTE: A whitespace-ignoring diff is a lot easier to review.

darwin-framework-tool ends up linking in two copies of CHIPLogging, so the redirect we were setting up was only capturing ChipLog* calls that happened inside Matter.framework. The calls from
darwin-framework-tool itself were getting dropped after being logged via os_log, and not showing up on stdout.

Also includes a drive-by fix to stop building address-resolve-tool every time we build darwin-framework-tool.

Fixes #24194

@bzbarsky-apple
Fix ChipLog* calls in darwin-framework-tool itself to work right.
8769084 
darwin-framework-tool ends up linking in two copies of CHIPLogging, so
the redirect we were setting up was only capturing ChipLog* calls that
happened inside Matter.framework.  The calls from
darwin-framework-tool itself were getting dropped after being logged
via os_log, and not showing up on stdout.

Also includes a drive-by fix to stop building address-resolve-tool
every time we build darwin-framework-tool.

Fixes project-chip#24194
@github-actions
Copy link

github-actions bot commented Dec 22, 2022 •
edited
Loading

PR #24195: Size comparison from eafbaae to 8769084

Increases (6 builds for bl602, cc13x2_26x2, psoc6, qpg, telink)
platform target config section eafbaae 8769084 change % change
bl602 lighting-app bl602 (read/write) 1356434 1356442 8 0.0
.text 1039190 1039194 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679859 679867 8 0.0
.text 589552 589560 8 0.0
lock-ftd LP_CC2652R7 (read only) 677391 677399 8 0.0
.text 599496 599504 8 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22478109 22478111 2 0.0
qpg lock-app qpg6105+debug (read/write) 1117532 1117540 8 0.0
.text 564628 564636 8 0.0
telink all-clusters-app tlsr9518adk80d text 726246 726248 2 0.0
Decreases (11 builds for bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
platform target config section eafbaae 8769084 change % change
bl702 lighting-app bl702 (read/write) 1196351 1196335 -16 -0.0
.debug_info 39187934 39187933 -1 -0.0
.text 956882 956880 -2 -0.0
bl702+rpc .debug_info 43480353 43480352 -1 -0.0
.text 1030862 1030860 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 171588 171580 -8 -0.0
lock-ftd LP_CC2652R7 (read/write) 171616 171608 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1219468 1219466 -2 -0.0
.flash.text 1219468 1219466 -2 -0.0
nrfconnect all-clusters-app nrf7002dk_nrf5340_cpuapp text 759962 759958 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26797110 26797109 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22259725 22259723 -2 -0.0
telink light-switch-app tlsr9518adk80d text 638032 638030 -2 -0.0
lighting-app tlsr9518adk80d text 703808 703806 -2 -0.0
ota-requestor-app tlsr9518adk80d text 649288 649286 -2 -0.0
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section eafbaae 8769084 change % change
bl602 lighting-app bl602 (read/write) 1356434 1356442 8 0.0
.bss 86977 86977 0 0.0
.data 9984 9984 0 0.0
.text 1039190 1039194 4 0.0
bl602+rpc (read/write) 1402218 1402218 0 0.0
.bss 95017 95017 0 0.0
.data 10384 10384 0 0.0
.text 1070616 1070616 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1196351 1196335 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67102 67102 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1529044 1529044 0 0.0
.debug_aranges 132568 132568 0 0.0
.debug_frame 486476 486476 0 0.0
.debug_info 39187934 39187933 -1 -0.0
.debug_line 5150433 5150433 0 0.0
.debug_loc 3381394 3381394 0 0.0
.debug_ranges 363816 363816 0 0.0
.debug_str 3483437 3483437 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116400 116400 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569377 569377 0 0.0
.symtab 172160 172160 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956882 956880 -2 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284827 1284827 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75118 75118 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1676376 1676376 0 0.0
.debug_aranges 140688 140688 0 0.0
.debug_frame 513896 513896 0 0.0
.debug_info 43480353 43480352 -1 -0.0
.debug_line 5539882 5539882 0 0.0
.debug_loc 3576086 3576086 0 0.0
.debug_ranges 387352 387352 0 0.0
.debug_str 3885835 3885835 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130144 130144 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629661 629661 0 0.0
.symtab 190336 190336 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030862 1030860 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679859 679867 8 0.0
(read/write) 171588 171580 -8 -0.0
.bss 81140 81140 0 0.0
.data 3380 3380 0 0.0
.rodata 89995 89995 0 0.0
.text 589552 589560 8 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 644139 644139 0 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 79139 79139 0 0.0
.text 564680 564680 0 0.0
lock-ftd LP_CC2652R7 (read only) 677391 677399 8 0.0
(read/write) 171616 171608 -8 -0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 77415 77415 0 0.0
.text 599496 599504 8 0.0
lock-mtd LP_CC2652R7 (read only) 662203 662203 0 0.0
(read/write) 182068 182068 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 103507 103507 0 0.0
.text 558216 558216 0 0.0
pump-app LP_CC2652R7 (read only) 690439 690439 0 0.0
(read/write) 159304 159304 0 0.0
.bss 78756 78756 0 0.0
.data 3296 3296 0 0.0
.rodata 91031 91031 0 0.0
.text 598924 598924 0 0.0
pump-controller-app LP_CC2652R7 (read only) 674363 674363 0 0.0
(read/write) 175484 175484 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86587 86587 0 0.0
.text 587296 587296 0 0.0
shell LP_CC2652R7 (read only) 671090 671090 0 0.0
(read/write) 182684 182684 0 0.0
.bss 83468 83468 0 0.0
.data 3376 3376 0 0.0
.rodata 86738 86738 0 0.0
.text 584036 584036 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588482 588482 0 0.0
.app_xip_area 464828 464828 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592294 592294 0 0.0
.app_xip_area 463344 463344 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551862 551862 0 0.0
.app_xip_area 433704 433704 0 0.0
.bss 60656 60656 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976468 976468 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 822108 822108 0 0.0
BRD4161A+rs911x (read/write) 1038920 1038920 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 850240 850240 0 0.0
BRD4187C (read/write) 1149948 1149948 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 984268 984268 0 0.0
lock-app BRD4161A+wf200 (read/write) 1069136 1069136 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 908908 908908 0 0.0
window-app BRD4187C (read/write) 1142592 1142592 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 975472 975472 0 0.0
esp32 all-clusters-app c3devkit (read only) 1219468 1219466 -2 -0.0
(read/write) 1790954 1790954 0 0.0
.dram0.bss 76912 76912 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248392 248392 0 0.0
.flash.text 1219468 1219466 -2 -0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233407 1233407 0 0.0
(read/write) 564187 564187 0 0.0
.dram0.bss 82064 82064 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314180 314180 0 0.0
.flash.text 1228023 1228023 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662716 662716 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 564468 564468 0 0.0
light k32w0+release (read/write) 673400 673400 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 593788 593788 0 0.0
lock k32w0+release (read/write) 634228 634228 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 553836 553836 0 0.0
linux all-clusters-app debug (read only) 3114473 3114473 0 0.0
(read/write) 158600 158600 0 0.0
.bss 62464 62464 0 0.0
.data 2304 2304 0 0.0
.data.rel.ro 87240 87240 0 0.0
.dynamic 608 608 0 0.0
.got 4768 4768 0 0.0
.init 27 27 0 0.0
.init_array 1184 1184 0 0.0
.rodata 281611 281611 0 0.0
.text 2648178 2648178 0 0.0
all-clusters-minimal-app debug (read only) 2938137 2938137 0 0.0
(read/write) 150000 150000 0 0.0
.bss 61664 61664 0 0.0
.data 2272 2272 0 0.0
.data.rel.ro 79608 79608 0 0.0
.dynamic 608 608 0 0.0
.got 4680 4680 0 0.0
.init 27 27 0 0.0
.init_array 1160 1160 0 0.0
.rodata 281035 281035 0 0.0
.text 2475458 2475458 0 0.0
bridge-app debug (read only) 2475961 2475961 0 0.0
(read/write) 131344 131344 0 0.0
.bss 51488 51488 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 69992 69992 0 0.0
.dynamic 608 608 0 0.0
.got 4576 4576 0 0.0
.init 27 27 0 0.0
.init_array 840 840 0 0.0
.rodata 211808 211808 0 0.0
.text 2094274 2094274 0 0.0
chip-tool debug (read only) 11182713 11182713 0 0.0
(read/write) 646808 646808 0 0.0
.bss 25912 25912 0 0.0
.data 2754 2754 0 0.0
.data.rel.ro 611568 611568 0 0.0
.dynamic 608 608 0 0.0
.got 5184 5184 0 0.0
.init 27 27 0 0.0
.init_array 728 728 0 0.0
.rodata 605029 605029 0 0.0
.text 9078820 9078820 0 0.0
chip-tool-ipv6only arm64 (read only) 10595932 10595932 0 0.0
(read/write) 695928 695928 0 0.0
.bss 33912 33912 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 640376 640376 0 0.0
.dynamic 560 560 0 0.0
.got 13832 13832 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 535180 535180 0 0.0
.text 8412948 8412948 0 0.0
lighting-app debug+rpc (read only) 2664337 2664337 0 0.0
(read/write) 132488 132488 0 0.0
.bss 49984 49984 0 0.0
.data 2288 2288 0 0.0
.data.rel.ro 74024 74024 0 0.0
.dynamic 608 608 0 0.0
.got 4632 4632 0 0.0
.init 27 27 0 0.0
.init_array 928 928 0 0.0
.rodata 228224 228224 0 0.0
.text 2259362 2259362 0 0.0
lock-app debug (read only) 2623401 2623401 0 0.0
(read/write) 127472 127472 0 0.0
.bss 48416 48416 0 0.0
.data 1904 1904 0 0.0
.data.rel.ro 70936 70936 0 0.0
.dynamic 608 608 0 0.0
.got 4664 4664 0 0.0
.init 27 27 0 0.0
.init_array 904 904 0 0.0
.rodata 244488 244488 0 0.0
.text 2207010 2207010 0 0.0
ota-provider-app debug (read only) 2197337 2197337 0 0.0
(read/write) 105904 105904 0 0.0
.bss 46592 46592 0 0.0
.data 2080 2080 0 0.0
.data.rel.ro 52120 52120 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 744 744 0 0.0
.rodata 195784 195784 0 0.0
.text 1861650 1861650 0 0.0
ota-requestor-app debug (read only) 2358841 2358841 0 0.0
(read/write) 113952 113952 0 0.0
.bss 49088 49088 0 0.0
.data 2448 2448 0 0.0
.data.rel.ro 57208 57208 0 0.0
.dynamic 608 608 0 0.0
.got 3728 3728 0 0.0
.init 27 27 0 0.0
.init_array 824 824 0 0.0
.rodata 202512 202512 0 0.0
.text 2007426 2007426 0 0.0
shell debug (read only) 2646945 2646945 0 0.0
(read/write) 143064 143064 0 0.0
.bss 57864 57864 0 0.0
.data 1264 1264 0 0.0
.data.rel.ro 78136 78136 0 0.0
.dynamic 608 608 0 0.0
.got 4128 4128 0 0.0
.init 27 27 0 0.0
.init_array 1032 1032 0 0.0
.rodata 239858 239858 0 0.0
.text 2247378 2247378 0 0.0
thermostat-no-ble arm64 (read only) 2478044 2478044 0 0.0
(read/write) 145016 145016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 78640 78640 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149560 149560 0 0.0
.text 2067888 2067888 0 0.0
tv-app debug (read only) 3286737 3286737 0 0.0
(read/write) 262312 262312 0 0.0
.bss 170808 170808 0 0.0
.data 4256 4256 0 0.0
.data.rel.ro 80544 80544 0 0.0
.dynamic 608 608 0 0.0
.got 5000 5000 0 0.0
.init 27 27 0 0.0
.init_array 1064 1064 0 0.0
.rodata 268856 268856 0 0.0
.text 2823554 2823554 0 0.0
tv-casting-app debug (read only) 5645937 5645937 0 0.0
(read/write) 162672 162672 0 0.0
.bss 52184 52184 0 0.0
.data 1936 1936 0 0.0
.data.rel.ro 101960 101960 0 0.0
.dynamic 608 608 0 0.0
.got 4920 4920 0 0.0
.init 27 27 0 0.0
.init_array 1040 1040 0 0.0
.rodata 359321 359321 0 0.0
.text 5009026 5009026 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463832 2463832 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1426476 1426476 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190987 1190987 0 0.0
bss 145205 145205 0 0.0
rodata 144544 144544 0 0.0
text 820122 820122 0 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1361250 1361250 0 0.0
bss 105144 105144 0 0.0
rodata 211640 211640 0 0.0
text 759962 759958 -4 -0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136647 1136647 0 0.0
bss 144440 144440 0 0.0
rodata 120860 120860 0 0.0
text 790290 790290 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842056 842056 0 0.0
(read/write) 1749660 1749660 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188624 188624 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238156 1238156 0 0.0
.debug_aranges 110768 110768 0 0.0
.debug_frame 371952 371952 0 0.0
.debug_info 27060312 27060312 0 0.0
.debug_line 3709704 3709704 0 0.0
.debug_loc 3624768 3624768 0 0.0
.debug_ranges 346584 346584 0 0.0
.debug_str 3453864 3453864 0 0.0
.heap 842056 842056 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 572205 572205 0 0.0
.symtab 422128 422128 0 0.0
.text 0 0 0 0.0
1549984 1549984 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1692188 1692188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1230047 1230047 0 0.0
.debug_aranges 110240 110240 0 0.0
.debug_frame 375008 375008 0 0.0
.debug_info 26797110 26797109 -1 -0.0
.debug_line 3728609 3728609 0 0.0
.debug_loc 3612374 3612374 0 0.0
.debug_ranges 345200 345200 0 0.0
.debug_str 3442876 3442876 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536294 536294 0 0.0
.symtab 408560 408560 0 0.0
.text 1493240 1493240 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1610404 1610404 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064846 1064846 0 0.0
.debug_aranges 102440 102440 0 0.0
.debug_frame 345344 345344 0 0.0
.debug_info 22259725 22259723 -2 -0.0
.debug_line 3295718 3295718 0 0.0
.debug_loc 3310296 3310296 0 0.0
.debug_ranges 309336 309336 0 0.0
.debug_str 3248462 3248462 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 472619 472619 0 0.0
.symtab 376928 376928 0 0.0
.text 1419648 1419648 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1644356 1644356 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066756 1066756 0 0.0
.debug_aranges 102824 102824 0 0.0
.debug_frame 347140 347140 0 0.0
.debug_info 22478109 22478111 2 0.0
.debug_line 3295612 3295612 0 0.0
.debug_loc 3331728 3331728 0 0.0
.debug_ranges 311192 311192 0 0.0
.debug_str 3264300 3264300 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475336 475336 0 0.0
.symtab 378928 378928 0 0.0
.text 1448608 1448608 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151236 1151236 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 598336 598336 0 0.0
lock-app qpg6105+debug (read/write) 1117532 1117540 8 0.0
.bss 95828 95828 0 0.0
.data 836 836 0 0.0
.text 564628 564636 8 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1071524 1071524 0 0.0
bss 98856 98856 0 0.0
text 726246 726248 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1010824 1010824 0 0.0
bss 98080 98080 0 0.0
text 691408 691408 0 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932280 932280 0 0.0
bss 90320 90320 0 0.0
text 638032 638030 -2 -0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1010248 1010248 0 0.0
bss 98380 98380 0 0.0
text 703808 703806 -2 -0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 945884 945884 0 0.0
bss 91276 91276 0 0.0
text 649288 649286 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 935428 935428 0 0.0
bss 91712 91712 0 0.0
text 638716 638716 0 0.0

cecille
cecille approved these changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@cecille cecille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a c# programmer, so please don't count this as a thorough review, but this looks correct, and I pulled the change, and the logs are now showing up AND in colour.

vivien-apple
vivien-apple approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@vivien-apple vivien-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh.

@bzbarsky-apple
Copy link
Contributor Author

Fast-tracking platform-specific fix with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit f8aa1df into project-chip:master Jan 3, 2023
@bzbarsky-apple bzbarsky-apple deleted the darwin-tool-logging branch January 3, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cecille cecille cecille approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

Assignees
No one assigned
Labels
darwin examples fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChipLog* no longer logs to stdout/stderr in darwin-framework-tool
3 participants
@bzbarsky-apple @cecille @vivien-apple