Separate Rendezvous message handling from BLE session #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change, BLE handling remains in RendezvousSession and message processing independent of BLE moves to RendervousMessageHandler.
kpschoedel
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
robszewczyk,
rwalker-apple and
saurabhst
as code owners
kedars
reviewed
Sep 2, 2020
| const size_t bufferLen = buffer->DataLength(); | ||
| char * key = nullptr; | ||
| char * ssid = nullptr; | ||
| char msg[bufferLen]; |
There was a problem hiding this comment.
This makes the stack utilisation dependent on the received DataLength. Is the data length known to be capped to a threshold? We could be more deterministic by having the high threshold value in here?
I understand this mostly just moves the existing code into another function, maybe a follow-on then.
There was a problem hiding this comment.
Good catch; I'm surprised we don't use -Wvla.
There was a problem hiding this comment.
Could you please file a followup issue to use -Wvla?
|
@pan-apple Could you take a look, please? |
pan-apple
approved these changes
Sep 2, 2020
|
tag: @vivien-apple |
bzbarsky-apple
approved these changes
Sep 2, 2020
kedars
approved these changes
Sep 2, 2020
mspang
approved these changes
Sep 2, 2020
|
@saurabhst @BroderickCarlin @andy31415 could you take a look? |
rwalker-apple
approved these changes
Sep 6, 2020
BroderickCarlin
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, BLE handling remains in RendezvousSession and
message processing independent of BLE moves to RendervousMessageHandler.