-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add isort formatter to restyled configuration #24148
Conversation
This commit also removes unused imports (reported by flake8) in few places.
PR #24148: Size comparison from 50e7c19 to fefbc5a Increases (2 builds for esp32)
Decreases (2 builds for bl702)
Full report (27 builds for bl602, bl702, esp32, k32w, linux, mbed)
|
PR #24148: Size comparison from 50e7c19 to 7295e35 Increases (16 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (4 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Full report (68 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24148: Size comparison from 50e7c19 to 0c2d19d Increases (13 builds for bl602, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (9 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (68 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24148: Size comparison from 50e7c19 to 3f0e9ee Increases (15 builds for bl702, cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Decreases (7 builds for bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (63 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
|
PR #24148: Size comparison from e101730 to 232ea60 Increases (7 builds for bl702, nrfconnect, psoc6, qpg)
Decreases (5 builds for esp32, nrfconnect, telink)
Full report (68 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24148: Size comparison from 20cd80f to a5ec69a Increases (8 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Full report (68 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24148: Size comparison from 45986a3 to 77bc424 Increases (10 builds for bl702, nrfconnect, psoc6, telink)
Decreases (6 builds for esp32, nrfconnect, qpg, telink)
Full report (61 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24148: Size comparison from 926fefe to 5ec7470 Increases (6 builds for cc13x2_26x2, cyw30739, nrfconnect, psoc6, qpg)
Decreases (4 builds for bl702, cc13x2_26x2, telink)
Full report (68 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #24148: Size comparison from 260307b to e105cf3 Increases (8 builds for bl702, esp32, nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, nrfconnect, psoc6, qpg, telink)
Full report (68 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Add isort formatter to restyled configuration * Sort Python imports using isort tool This commit also removes unused imports (reported by flake8) in few places. * Restyled by autopep8 * Restyled by isort * Update ZAP template for cluster Objects * Fix E402 suppressions in connection with isort * Fix imports which depend on modified sys path * Fix circular dependency when importing FabricAdmin * Restyled by isort Co-authored-by: Restyled.io <[email protected]>
* Add isort formatter to restyled configuration * Sort Python imports using isort tool This commit also removes unused imports (reported by flake8) in few places. * Restyled by autopep8 * Restyled by isort * Update ZAP template for cluster Objects * Fix E402 suppressions in connection with isort * Fix imports which depend on modified sys path * Fix circular dependency when importing FabricAdmin * Restyled by isort Co-authored-by: Restyled.io <[email protected]>
Problem
Pythons imports style quality is very poor. This can be fixed with restyled isort module which uses isort to automatically sort Python imports.
Changes
Testing
CI should check that - this PR shall not change behavior of any Python file/module.