-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "Basic" cluster to "Basic Information". #24124
Merged
vivien-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-basic-cluster
Dec 18, 2022
Merged
Rename "Basic" cluster to "Basic Information". #24124
vivien-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:rename-basic-cluster
Dec 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
December 17, 2022 06:30
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 17, 2022 06:30
PR #24124: Size comparison from 3c2db4f to 55fae54 Increases (9 builds for bl602, bl702, cc13x2_26x2, linux, qpg)
Decreases (14 builds for bl702, cc13x2_26x2, k32w, linux, nrfconnect, qpg)
Full report (22 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg)
|
bzbarsky-apple
force-pushed
the
rename-basic-cluster
branch
from
December 17, 2022 07:15
55fae54
to
b361822
Compare
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Dec 17, 2022
PR #24124: Size comparison from 3c2db4f to b361822 Increases (3 builds for linux, qpg)
Decreases (5 builds for k32w, linux, qpg)
Full report (8 builds for k32w, linux, mbed, qpg)
|
This matches the spec name.
bzbarsky-apple
force-pushed
the
rename-basic-cluster
branch
from
December 17, 2022 07:47
b361822
to
8524f4f
Compare
PR #24124: Size comparison from 3c2db4f to 8524f4f Increases (23 builds for bl702, cc13x2_26x2, linux, psoc6, qpg)
Decreases (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tcarmelveilleux
approved these changes
Dec 17, 2022
PR #24124: Size comparison from 3c2db4f to 12158d1 Increases (23 builds for bl702, cc13x2_26x2, linux, psoc6, qpg)
Decreases (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
approved these changes
Dec 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
documentation
Improvements or additions to documentation
examples
github
review - approved
scripts
tests
workflows
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the spec name.
This will need project-chip/zap#867 to merge and the docker containers to be updated to pass the ZAP CI.