Fix support for 0-length hex-encoded octet strings in chip-tool. #24097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
pullapprove
bot
requested review from
vijs,
vivien-apple,
woody-apple and
xylophone21
|
PR #24097: Size comparison from b49c3ed to 28ae775 Increases (6 builds for bl702, linux, telink)
Decreases (4 builds for bl602, nrfconnect, telink)
Full report (21 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
Without this fix, these commands all fail to parse:
chip-tool unittesting write struct-attr '{"a": 1, "b": true, "c": 0, "d":"", "e": "abc", "f": 0, "g": 0, "h": 0}' 17 1
chip-tool unittesting write struct-attr '{"a": 1, "b": true, "c": 0, "d":"hex:", "e": "abc", "f": 0, "g": 0, "h": 0}' 17 1
chip-tool unittesting write octet-string "hex:" 17 1
chip-tool unittesting write-by-id 0 "hex:" 17 1
and with this fix they parse and send correct payloads.
Fixes project-chip#24054
bzbarsky-apple
force-pushed
the
chip-tool-empty-hex
branch
from
28ae775 to
025710c
Compare
|
PR #24097: Size comparison from b49c3ed to 025710c Increases (10 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Decreases (7 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmeg-sfy
approved these changes
Dec 22, 2022
jmeg-sfy
reviewed
Dec 22, 2022
Co-authored-by: Jonathan Mégevand <[email protected]>
bzbarsky-apple
force-pushed
the
chip-tool-empty-hex
branch
from
5906860 to
a2eccb5
Compare
|
PR #24097: Size comparison from 443128a to a2eccb5 Increases (5 builds for cc13x2_26x2, linux, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
tehampson
approved these changes
Dec 22, 2022
msandstedt
approved these changes
Jan 3, 2023
arkq
reviewed
Jan 3, 2023
msandstedt
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this fix, these commands all fail to parse:
chip-tool unittesting write struct-attr '{"a": 1, "b": true, "c": 0, "d":"", "e": "abc", "f": 0, "g": 0, "h": 0}' 17 1
chip-tool unittesting write struct-attr '{"a": 1, "b": true, "c": 0, "d":"hex:", "e": "abc", "f": 0, "g": 0, "h": 0}' 17 1
chip-tool unittesting write octet-string "hex:" 17 1
chip-tool unittesting write-by-id 0 "hex:" 17 1
and with this fix they parse and send correct payloads.
Fixes #24054