-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IC-Device] Initial implementation of Client Monitoring Registration table #24096
Merged
bzbarsky-apple
merged 11 commits into
project-chip:master
from
mkardous-silabs:feature/cm-table
Jan 4, 2023
Merged
[IC-Device] Initial implementation of Client Monitoring Registration table #24096
bzbarsky-apple
merged 11 commits into
project-chip:master
from
mkardous-silabs:feature/cm-table
Jan 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13 and
harimau-qirex
December 15, 2022 17:50
Damian-Nordic
approved these changes
Jan 3, 2023
turon
approved these changes
Jan 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
bzbarsky-apple
approved these changes
Jan 3, 2023
Add unit test for invalid values
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Damian Królik <[email protected]>
mkardous-silabs
force-pushed
the
feature/cm-table
branch
from
January 4, 2023 13:40
fced10e
to
e0677ff
Compare
PR #24096: Size comparison from ac82038 to a36c65c Increases (10 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (15 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, psoc6, qpg, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR implements a portion of #24253 |
rcasallas-silabs
approved these changes
Jan 4, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…table (project-chip#24096) * Client Monitoring table implementation * CM table tests * Add sub-struct to add a validation function Add unit test for invalid values * Address PR comments * Apply suggestions from code review Co-authored-by: Boris Zbarsky <[email protected]> * Increase max unit test limit * Apply suggestions from code review Co-authored-by: Damian Królik <[email protected]> * Move comments to headeR * update test assert * Add provisional comment * restyle Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Damian Królik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial implementation of the Client Monitoring Table for persistance of registration entires
Tests
Added test suite for the CM Table with basic sanity checks