-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin / MTRDeviceController] Add some abstraction for dispatch_sync… #24059
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Darwin_dispatch_sync_abstraction_for_mtr_controller
Dec 14, 2022
Merged
[darwin / MTRDeviceController] Add some abstraction for dispatch_sync… #24059
bzbarsky-apple
merged 2 commits into
project-chip:master
from
vivien-apple:Darwin_dispatch_sync_abstraction_for_mtr_controller
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
Darwin_dispatch_sync_abstraction_for_mtr_controller
branch
from
December 13, 2022 15:06
e6f3e60
to
9663c82
Compare
PR #24059: Size comparison from 0a09f68 to 9663c82 Increases (4 builds for esp32, psoc6, telink)
Decreases (4 builds for bl702, psoc6, telink)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 14, 2022
… on the chip work queue instead of duplicating the code all the time
vivien-apple
force-pushed
the
Darwin_dispatch_sync_abstraction_for_mtr_controller
branch
from
December 14, 2022 09:26
9663c82
to
efbc9b9
Compare
pullapprove
bot
requested review from
andy31415,
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt and
mspang
December 14, 2022 09:27
pullapprove
bot
requested review from
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
xylophone21 and
yufengwangca
December 14, 2022 09:27
PR #24059: Size comparison from 8055d86 to efbc9b9 Increases (7 builds for bl602, cc13x2_26x2, telink)
Decreases (5 builds for bl702, cc13x2_26x2, telink)
Full report (28 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
PR #24059: Size comparison from 8055d86 to c2f331a Decreases (2 builds for bl602, k32w)
Full report (15 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg)
|
vivien-apple
force-pushed
the
Darwin_dispatch_sync_abstraction_for_mtr_controller
branch
from
December 14, 2022 10:52
c2f331a
to
4ffc3a3
Compare
PR #24059: Size comparison from 8055d86 to 4ffc3a3 Increases (7 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 14, 2022
Fast-tracking platform-specific change with platform owner review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… on the chip work queue instead of duplicating the code all the time
Problem
This is a followup to #24033 where I forgot to add a
VerifyOrReturnValue([self checkIsRunning:error], NO);
at the beginning ofprepareCommissioningSession
.Instead of just adding it, this PR abstract that away so it should not happens anymore.