-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Silabs] zap configuration changes to support groups on thermostat app #24001
Merged
andy31415
merged 6 commits into
project-chip:master
from
kurvaSai:bugfix/thermostat_zap_changes_for_groups
Dec 12, 2022
Merged
[Silabs] zap configuration changes to support groups on thermostat app #24001
andy31415
merged 6 commits into
project-chip:master
from
kurvaSai:bugfix/thermostat_zap_changes_for_groups
Dec 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #24001: Size comparison from a7060e0 to d8f2257 Increases above 0.2%:
Increases (4 builds for bl602, linux, psoc6, telink)
Decreases (7 builds for bl702, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda and
mlepage-google
December 9, 2022 14:29
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
rgoliver,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 9, 2022 14:29
PR #24001: Size comparison from a7060e0 to 59e9a53 Increases above 0.2%:
Increases (6 builds for linux, psoc6, telink)
Decreases (10 builds for bl602, bl702, esp32, psoc6, telink)
Full report (46 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
pullapprove
bot
requested review from
ksperling-apple
and removed request for
isiu-apple
December 9, 2022 19:53
PR #24001: Size comparison from a7060e0 to 0f514ea Decreases (3 builds for nrfconnect)
Full report (4 builds for mbed, nrfconnect)
|
jmartinez-silabs
approved these changes
Dec 12, 2022
andy31415
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is being Fixed?
Added changes in thermostat.zap to make groups work and zap_generated files.
Testing:
Manually tested basic sanity and multicast groups on MG12-RS911x/WFF200 and MG24-RS911x/917/WF200.