-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix errant VerifyOrReturn in CASESession #23944
Merged
Damian-Nordic
merged 2 commits into
project-chip:master
from
mlepage-google:fix-verify-or-return
Dec 7, 2022
Merged
Fix errant VerifyOrReturn in CASESession #23944
Damian-Nordic
merged 2 commits into
project-chip:master
from
mlepage-google:fix-verify-or-return
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In CASESession::HandleSigma2 it should be VerifyOrExit not VerifyOrReturn. Otherwise, if it fails, a status report message won't be sent as intended.
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mrjerryjohns,
msandstedt,
mspang,
rgoliver and
robszewczyk
December 6, 2022 22:50
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
December 6, 2022 22:50
emargolis
approved these changes
Dec 6, 2022
Damian-Nordic
approved these changes
Dec 6, 2022
PR #23944: Size comparison from 141df0c to 745d9ad Increases (17 builds for bl702, cc13x2_26x2, esp32, linux, mbed, psoc6, telink)
Decreases (29 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CASESession::HandleSigma2 it should be VerifyOrExit not VerifyOrReturn.
Otherwise, if it fails, a status report message won't be sent as intended.