Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure the Neighbor Table averageRSSI and LastRSSI are valid. #23914

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Make sure the Neighbor Table averageRSSI and LastRSSI are valid. #23914

merged 2 commits into from
Dec 7, 2022

Conversation

jmartinez-silabs
Copy link
Member

Add some checks to make sure the average RSSI and LastRSSI obtained in the neighbour table info are valid and not greater than 0 to respect the matter spec.

We have seen some rare cases in a lab environment where the reported LastRSSI was slightly greater than 0

@github-actions
Copy link

github-actions bot commented Dec 5, 2022 •
edited
Loading

PR #23914: Size comparison from 0b8ecc8 to f569f6c

Increases (31 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, k32w, nrfconnect, psoc6, qpg, telink)
platform target config section 0b8ecc8 f569f6c change % change
bl602 lighting-app bl602 .text 1037740 1037744 4 0.0
bl602+rpc (read/write) 1400766 1400774 8 0.0
.text 1069160 1069164 4 0.0
bl702 lighting-app bl702 (read/write) 1195423 1195487 64 0.0
.debug_info 39222055 39222167 112 0.0
.debug_line 5145245 5145338 93 0.0
.debug_str 3479113 3479331 218 0.0
.text 955982 956040 58 0.0
bl702+rpc (read/write) 1283867 1283931 64 0.0
.debug_info 43520368 43520480 112 0.0
.debug_line 5536260 5536353 93 0.0
.debug_str 3881511 3881729 218 0.0
.text 1029918 1029976 58 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679459 679499 40 0.0
.text 589184 589224 40 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643715 643755 40 0.0
.text 564296 564336 40 0.0
lock-ftd LP_CC2652R7 (read only) 677079 677119 40 0.0
.text 599208 599248 40 0.0
lock-mtd LP_CC2652R7 (read only) 661787 661835 48 0.0
.text 557832 557880 48 0.0
pump-app LP_CC2652R7 (read only) 690007 690047 40 0.0
.text 598612 598652 40 0.0
pump-controller-app LP_CC2652R7 (read only) 673907 673947 40 0.0
.text 586968 587008 40 0.0
shell LP_CC2652R7 (read only) 670670 670710 40 0.0
.text 583644 583684 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588406 588446 40 0.0
.app_xip_area 464664 464704 40 0.0
lock cyw930739m2evb_01 (read/write) 592106 592154 48 0.0
.app_xip_area 463068 463116 48 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976116 976148 32 0.0
.text 821676 821708 32 0.0
BRD4187C (read/write) 1149188 1149236 48 0.0
.text 983428 983476 48 0.0
window-app BRD4187C (read/write) 1141720 1141768 48 0.0
.text 974520 974568 48 0.0
k32w contact k32w0+release (read/write) 662516 662548 32 0.0
.text 564188 564220 32 0.0
light k32w0+release (read/write) 673080 673128 48 0.0
.text 593388 593436 48 0.0
lock k32w0+release (read/write) 634036 634084 48 0.0
.text 553564 553612 48 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190747 1190795 48 0.0
text 819848 819890 42 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136391 1136439 48 0.0
text 790016 790058 42 0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27069253 27069254 1 0.0
lock cy8ckit_062s2_43012 .debug_info 22486334 22486335 1 0.0
qpg lighting-app qpg6105+debug (read/write) 1150932 1150972 40 0.0
.text 598032 598072 40 0.0
lock-app qpg6105+debug (read/write) 1116740 1116780 40 0.0
.text 563836 563876 40 0.0
telink all-clusters-app tlsr9518adk80d (read/write) 1092508 1092580 72 0.0
text 739664 739732 68 0.0
all-clusters-minimal-app tlsr9518adk80d (read/write) 1031692 1031756 64 0.0
text 704828 704892 64 0.0
light-switch-app tlsr9518adk80d (read/write) 953280 953344 64 0.0
text 651452 651518 66 0.0
lighting-app tlsr9518adk80d (read/write) 1035228 1035292 64 0.0
text 720046 720112 66 0.0
ota-requestor-app tlsr9518adk80d (read/write) 966392 966400 8 0.0
text 662748 662750 2 0.0
thermostat tlsr9518adk80d (read/write) 954028 954092 64 0.0
text 650078 650142 64 0.0
Decreases (10 builds for bl702, cc13x2_26x2, esp32, psoc6)
platform target config section 0b8ecc8 f569f6c change % change
bl702 lighting-app bl702 .debug_loc 3378732 3378688 -44 -0.0
bl702+rpc .debug_loc 3573846 3573802 -44 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 172068 172028 -40 -0.0
lock-ftd LP_CC2652R7 (read/write) 172016 171976 -40 -0.0
lock-mtd LP_CC2652R7 (read/write) 182564 182516 -48 -0.0
pump-app LP_CC2652R7 (read/write) 159824 159784 -40 -0.0
pump-controller-app LP_CC2652R7 (read/write) 176028 175988 -40 -0.0
shell LP_CC2652R7 (read/write) 183176 183136 -40 -0.0
esp32 all-clusters-app c3devkit (read only) 1218692 1218690 -2 -0.0
.flash.text 1218692 1218690 -2 -0.0
psoc6 light cy8ckit_062s2_43012 .debug_info 22268170 22268169 -1 -0.0
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 0b8ecc8 f569f6c change % change
bl602 lighting-app bl602 (read/write) 1354990 1354990 0 0.0
.bss 87057 87057 0 0.0
.data 9984 9984 0 0.0
.text 1037740 1037744 4 0.0
bl602+rpc (read/write) 1400766 1400774 8 0.0
.bss 95097 95097 0 0.0
.data 10384 10384 0 0.0
.text 1069160 1069164 4 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1195423 1195487 64 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67166 67166 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1529099 1529099 0 0.0
.debug_aranges 132680 132680 0 0.0
.debug_frame 486784 486784 0 0.0
.debug_info 39222055 39222167 112 0.0
.debug_line 5145245 5145338 93 0.0
.debug_loc 3378732 3378688 -44 -0.0
.debug_ranges 363712 363712 0 0.0
.debug_str 3479113 3479331 218 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116320 116320 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 568701 568701 0 0.0
.symtab 172096 172096 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
955982 956040 58 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1283867 1283931 64 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75198 75198 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4576 4576 0 0.0
.debug_abbrev 1677213 1677213 0 0.0
.debug_aranges 140824 140824 0 0.0
.debug_frame 514256 514256 0 0.0
.debug_info 43520368 43520480 112 0.0
.debug_line 5536260 5536353 93 0.0
.debug_loc 3573846 3573802 -44 -0.0
.debug_ranges 387280 387280 0 0.0
.debug_str 3881511 3881729 218 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 130032 130032 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 628923 628923 0 0.0
.symtab 190272 190272 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1029918 1029976 58 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 679459 679499 40 0.0
(read/write) 172068 172028 -40 -0.0
.bss 81220 81220 0 0.0
.data 3380 3380 0 0.0
.rodata 89963 89963 0 0.0
.text 589184 589224 40 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643715 643755 40 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 79099 79099 0 0.0
.text 564296 564336 40 0.0
lock-ftd LP_CC2652R7 (read only) 677079 677119 40 0.0
(read/write) 172016 171976 -40 -0.0
.bss 78876 78876 0 0.0
.data 3304 3304 0 0.0
.rodata 77391 77391 0 0.0
.text 599208 599248 40 0.0
lock-mtd LP_CC2652R7 (read only) 661787 661835 48 0.0
(read/write) 182564 182516 -48 -0.0
.bss 74132 74132 0 0.0
.data 3304 3304 0 0.0
.rodata 103475 103475 0 0.0
.text 557832 557880 48 0.0
pump-app LP_CC2652R7 (read only) 690007 690047 40 0.0
(read/write) 159824 159784 -40 -0.0
.bss 78844 78844 0 0.0
.data 3296 3296 0 0.0
.rodata 90911 90911 0 0.0
.text 598612 598652 40 0.0
pump-controller-app LP_CC2652R7 (read only) 673907 673947 40 0.0
(read/write) 176028 175988 -40 -0.0
.bss 78948 78948 0 0.0
.data 3292 3292 0 0.0
.rodata 86459 86459 0 0.0
.text 586968 587008 40 0.0
shell LP_CC2652R7 (read only) 670670 670710 40 0.0
(read/write) 183176 183136 -40 -0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86710 86710 0 0.0
.text 583644 583684 40 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 588406 588446 40 0.0
.app_xip_area 464664 464704 40 0.0
.bss 66200 66200 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 592106 592154 48 0.0
.app_xip_area 463068 463116 48 0.0
.bss 71488 71488 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 551506 551506 0 0.0
.app_xip_area 433268 433268 0 0.0
.bss 60736 60736 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 976116 976148 32 0.0
.bss 152252 152252 0 0.0
.data 2168 2168 0 0.0
.text 821676 821708 32 0.0
BRD4161A+rs911x (read/write) 1037616 1037616 0 0.0
.bss 186728 186728 0 0.0
.data 2012 2012 0 0.0
.text 848856 848856 0 0.0
BRD4187C (read/write) 1149188 1149236 48 0.0
.bss 138648 138648 0 0.0
.data 2516 2516 0 0.0
.text 983428 983476 48 0.0
lock-app BRD4161A+wf200 (read/write) 1163288 1163288 0 0.0
.bss 158296 158296 0 0.0
.data 2020 2020 0 0.0
.text 1002952 1002952 0 0.0
window-app BRD4187C (read/write) 1141720 1141768 48 0.0
.bss 140064 140064 0 0.0
.data 2540 2540 0 0.0
.text 974520 974568 48 0.0
esp32 all-clusters-app c3devkit (read only) 1218692 1218690 -2 -0.0
(read/write) 1790922 1790922 0 0.0
.dram0.bss 76984 76984 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 248280 248280 0 0.0
.flash.text 1218692 1218690 -2 -0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1232851 1232851 0 0.0
(read/write) 564159 564159 0 0.0
.dram0.bss 82144 82144 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 314072 314072 0 0.0
.flash.text 1227467 1227467 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 662516 662548 32 0.0
.bss 77112 77112 0 0.0
.data 2104 2104 0 0.0
.text 564188 564220 32 0.0
light k32w0+release (read/write) 673080 673128 48 0.0
.bss 74904 74904 0 0.0
.data 2060 2060 0 0.0
.text 593388 593436 48 0.0
lock k32w0+release (read/write) 634036 634084 48 0.0
.bss 75664 75664 0 0.0
.data 2080 2080 0 0.0
.text 553564 553612 48 0.0
linux chip-tool-ipv6only arm64 (read only) 10613308 10613308 0 0.0
(read/write) 708097 708097 0 0.0
.bss 33905 33905 0 0.0
.data 2768 2768 0 0.0
.data.rel.ro 652392 652392 0 0.0
.dynamic 560 560 0 0.0
.got 13960 13960 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 528844 528844 0 0.0
.text 8425044 8425044 0 0.0
thermostat-no-ble arm64 (read only) 2422028 2422028 0 0.0
(read/write) 143633 143633 0 0.0
.bss 55329 55329 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 77256 77256 0 0.0
.dynamic 560 560 0 0.0
.got 5184 5184 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 145092 145092 0 0.0
.text 2033216 2033216 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2463328 2463328 0 0.0
.bss 215012 215012 0 0.0
.data 5872 5872 0 0.0
.text 1425972 1425972 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1190747 1190795 48 0.0
bss 145285 145285 0 0.0
rodata 144448 144448 0 0.0
text 819848 819890 42 0.0
nrf7002dk_nrf5340_cpuapp (read/write) 1360874 1360874 0 0.0
bss 105224 105224 0 0.0
rodata 211552 211552 0 0.0
text 759606 759606 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1136391 1136439 48 0.0
bss 144520 144520 0 0.0
rodata 120764 120764 0 0.0
text 790016 790058 42 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841976 841976 0 0.0
(read/write) 1748412 1748412 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188704 188704 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1238033 1238033 0 0.0
.debug_aranges 110904 110904 0 0.0
.debug_frame 372244 372244 0 0.0
.debug_info 27069253 27069254 1 0.0
.debug_line 3706962 3706962 0 0.0
.debug_loc 3620645 3620645 0 0.0
.debug_ranges 345768 345768 0 0.0
.debug_str 3448037 3448037 0 0.0
.heap 841976 841976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 571557 571557 0 0.0
.symtab 421952 421952 0 0.0
.text 1548656 1548656 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842704 842704 0 0.0
(read/write) 1690940 1690940 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229924 1229924 0 0.0
.debug_aranges 110376 110376 0 0.0
.debug_frame 375300 375300 0 0.0
.debug_info 26806041 26806041 0 0.0
.debug_line 3725899 3725899 0 0.0
.debug_loc 3608251 3608251 0 0.0
.debug_ranges 344384 344384 0 0.0
.debug_str 3437049 3437049 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535646 535646 0 0.0
.symtab 408384 408384 0 0.0
.text 1491912 1491912 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850896 850896 0 0.0
(read/write) 1609132 1609132 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1064721 1064721 0 0.0
.debug_aranges 102576 102576 0 0.0
.debug_frame 345636 345636 0 0.0
.debug_info 22268170 22268169 -1 -0.0
.debug_line 3293223 3293223 0 0.0
.debug_loc 3306158 3306158 0 0.0
.debug_ranges 308520 308520 0 0.0
.debug_str 3242635 3242635 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 471971 471971 0 0.0
.symtab 376752 376752 0 0.0
.text 1418296 1418296 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845904 845904 0 0.0
(read/write) 1642572 1642572 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184968 184968 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1066637 1066637 0 0.0
.debug_aranges 102960 102960 0 0.0
.debug_frame 347432 347432 0 0.0
.debug_info 22486334 22486335 1 0.0
.debug_line 3292973 3292973 0 0.0
.debug_loc 3327556 3327556 0 0.0
.debug_ranges 310376 310376 0 0.0
.debug_str 3258478 3258478 0 0.0
.heap 845904 845904 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473633 473633 0 0.0
.symtab 378352 378352 0 0.0
.text 1446744 1446744 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1150932 1150972 40 0.0
.bss 97620 97620 0 0.0
.data 840 840 0 0.0
.text 598032 598072 40 0.0
lock-app qpg6105+debug (read/write) 1116740 1116780 40 0.0
.bss 93092 93092 0 0.0
.data 836 836 0 0.0
.text 563836 563876 40 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1092508 1092580 72 0.0
bss 99808 99808 0 0.0
text 739664 739732 68 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1031692 1031756 64 0.0
bss 99032 99032 0 0.0
text 704828 704892 64 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 953280 953344 64 0.0
bss 91272 91272 0 0.0
text 651452 651518 66 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1035228 1035292 64 0.0
bss 100420 100420 0 0.0
text 720046 720112 66 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 966392 966400 8 0.0
bss 92228 92228 0 0.0
text 662748 662750 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 954028 954092 64 0.0
bss 92664 92664 0 0.0
text 650078 650142 64 0.0

@yufengwangca yufengwangca merged commit 78fec18 into project-chip:master Dec 7, 2022
@jmartinez-silabs jmartinez-silabs deleted the max_neighbor_rssi branch December 7, 2022 21:56
@jmartinez-silabs jmartinez-silabs mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@andy31415 andy31415 Awaiting requested review from andy31415

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmartinez-silabs @yufengwangca @Damian-Nordic @jepenven-silabs