-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix APIs involved in the MTROperationalCredentialsDelegate. #23893
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:darwin-noc-chain-issuer-api
Dec 12, 2022
Merged
Fix APIs involved in the MTROperationalCredentialsDelegate. #23893
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:darwin-noc-chain-issuer-api
Dec 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
msandstedt,
mspang and
rgoliver
December 3, 2022 00:20
pullapprove
bot
requested review from
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
December 3, 2022 00:20
PR #23893: Size comparison from 1945a0f to aaa7585 Increases (12 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-noc-chain-issuer-api
branch
2 times, most recently
from
December 3, 2022 04:46
7b05497
to
3b5e74d
Compare
PR #23893: Size comparison from 1945a0f to 3b5e74d Increases (5 builds for bl602, esp32, psoc6, qpg)
Decreases (7 builds for nrfconnect, psoc6, telink)
Full report (35 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
* Rename CSRInfo to MTROperationalCSRInfo * Rename the properties of MTROperationalCSRInfo to match the spec more closely. * Rename AttestationInfo to MTRAttestationInfo. * Fix naming of the API on MTRDeviceController to follow conventions better, document the API more clearly, and have it return errors as needed. * Rename MTRNOCChainIssuer to MTROperationalCertificateIssuer * Change signature of the one method on MTROperationalCertificateIssuer to have better naming, take a controller, and name the completion block "completion". * Change the completion signature on MTROperationalCertificateIssuer to allow the external certificate issuer to return an error (e.g. if its device attestation checks failed). * Don't ask the external issuer for the IPK, since we should already have that anyway (from our controller init). * Allow the external issuer to return nil for the intermediate certificate, to indicate that there isn't one. * Make sure that all our access to mOnNOCCompletionCallback happens on the Matter queue, so we don't have thread races on that member. * Make all the dispatch we do as part of the credential-issuing process async. * Introduce backwards-compat shims for all the API changes for now. Fixes project-chip#23439
bzbarsky-apple
force-pushed
the
darwin-noc-chain-issuer-api
branch
from
December 5, 2022 15:24
3b5e74d
to
9a7a315
Compare
PR #23893: Size comparison from 0a765c6 to 9a7a315 Increases (4 builds for bl702, cyw30739, esp32, telink)
Decreases (10 builds for bl602, bl702, efr32, nrfconnect, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
reviewed
Dec 5, 2022
PR #23893: Size comparison from 0a765c6 to e05b7a4 Increases (13 builds for bl702, cc13x2_26x2, cyw30739, esp32, psoc6, qpg)
Decreases (15 builds for bl602, bl702, cc13x2_26x2, efr32, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Dec 7, 2022
cliffamzn
reviewed
Dec 9, 2022
cliffamzn
approved these changes
Dec 12, 2022
ksperling-apple
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23439