-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package the java-matter-controller as an executable format #23688
Merged
yunhanw-google
merged 2 commits into
project-chip:master
from
yufengwangca:pr/java/build
Nov 21, 2022
Merged
Package the java-matter-controller as an executable format #23688
yunhanw-google
merged 2 commits into
project-chip:master
from
yufengwangca:pr/java/build
Nov 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt,
mspang and
rgoliver
November 19, 2022 02:09
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
November 19, 2022 02:09
PR #23688: Size comparison from 76d834e to 09f327c Increases (5 builds for bl602, bl702, cc13x2_26x2, nrfconnect, telink)
Decreases (7 builds for cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
approved these changes
Nov 19, 2022
PR #23688: Size comparison from 76d834e to ca0c572 Increases (7 builds for bl602, bl702, cc13x2_26x2, nrfconnect, telink)
Decreases (4 builds for cc13x2_26x2, psoc6, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23688: Size comparison from 76d834e to 533cbf4 Increases (11 builds for bl602, bl702, esp32, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 19, 2022
andy31415
reviewed
Nov 19, 2022
examples/java-matter-controller/java/src/com/matter/controller/Main.java
Outdated
Show resolved
Hide resolved
andy31415
reviewed
Nov 19, 2022
examples/java-matter-controller/java/src/com/matter/controller/Main.java
Outdated
Show resolved
Hide resolved
PR #23688: Size comparison from 1bcbcfa to ad18034 Increases (4 builds for bl702, cc13x2_26x2, esp32, psoc6)
Decreases (8 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we need to run the java-matter-controller with the following format
java -verbose:jni -Xcheck:jni -Djava.library.path=out/linux-x64-java-matter-controller/lib/jni -cp out/linux-x64-java-matter-controller/lib/third_party/connectedhomeip/src/controller/java/CHIPController.jar:out/linux-x64-java-matter-controller/bin/java-matter-controller com.matter.controller.Main
We need to package it in an executable format to be run like
$ java -Djava.library.path=../lib/jni -jar java-matter-controller