Remove verbose text during building #23687
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s should not have non-fatal diagnostic or progress output
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
… second response time for non-filgered subscriptions
|
PR #23687: Size comparison from 669cd47 to 9d81b83 Increases (10 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (3 builds for bl702, cc13x2_26x2, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #23687: Size comparison from 669cd47 to 53504a4 Increases (10 builds for bl602, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (4 builds for bl702, cc13x2_26x2, psoc6, telink)
Full report (35 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #23687: Size comparison from 669cd47 to 0f893d1 Increases (8 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (33 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #23687: Size comparison from 669cd47 to d76928c Increases (9 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…d it looks like these drain randomness, causing sideffects with other tests requiring a lot of randomness source
|
PR #23687: Size comparison from 32dd689 to 85843fc Increases (4 builds for cc13x2_26x2, esp32, psoc6)
Decreases (9 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect, psoc6, telink)
Full report (50 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
requested changes
Nov 28, 2022
| params.mKeepSubscriptions = true; | ||
| params.mIsFabricFiltered = false; | ||
|
|
||
| // Increase timeout, so that slow versions (specifically gcc_debug) does not time out. |
There was a problem hiding this comment.
Why is this change needed? Why are things fine without this change before but not fine after?
| params.mTimeout = chip::System::Clock::Seconds16(15); | ||
|
|
||
| CHIP_ERROR err = | ||
| Controller::detail::ReportAttribute<Clusters::UnitTesting::Attributes::ListStructOctetString::TypeInfo::DecodableType>( |
There was a problem hiding this comment.
You should not be using "detail" APIs here. There are public APIs for all this; please use them.
| # We have many DUT vectors and dmalloc requires a lot of time to validate | ||
| # heap operations for large crypto processing. Skip this test for | ||
| # dmalloc. | ||
| test_sources += [ "TestCommissionerDUTVectors.cpp" ] |
There was a problem hiding this comment.
Why is this change needed for a logging change?
| @@ -765,10 +765,19 @@ void SessionAllocationTest(nlTestSuite * inSuite, void * inContext) | |||
| handle.Value()->AsSecureSession()->MarkForEviction(); | |||
| } | |||
|
|
|||
| #if CHIP_CONFIG_MEMORY_DEBUG_DMALLOC | |||
There was a problem hiding this comment.
Why is this needed for a logging change?
|
Giving up on this one: changes balooned. Realistically I only wanted to delete a print, yet that moves me towards debugging timing issues when using dmalloc in different sequences (likely crypto dependent). This is not the original PR anymore, so closing. |
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Dec 8, 2022
Currently dmalloc is disabled because of a stray print from GN combined with a strict comparison of GN's output in configuring this checker. This caused tests to timeout and fail in a previous attempt to remove the print in project-chip#23687. This checker is extremely expensive, especially for tests with more allocations. For one test, it increases the cost from 1 second to 1 hour: psyche:50095:~/connectedhomeip% time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 3325.35s user 0.05s system 99% cpu 55:25.65 total psyche:50097:~/connectedhomeip% time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 1.24s user 0.01s system 99% cpu 1.249 total This is much too costly to be enabled for all unit tests in presubmit, so disable it. Other tools such as ASAN have much lower overhead.
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Dec 8, 2022
Currently dmalloc is disabled because of a stray print from GN combined with a strict comparison of GN's output in configuring this checker. This caused tests to timeout and fail in a previous attempt to remove the print in project-chip#23687. This checker is extremely expensive, especially for tests with more allocations. For one test, it increases the cost from 1 second to 1 hour: psyche:50095:~/connectedhomeip% time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 3325.35s user 0.05s system 99% cpu 55:25.65 total psyche:50097:~/connectedhomeip% time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 1.24s user 0.01s system 99% cpu 1.249 total This is much too costly to be enabled for all unit tests in presubmit, so disable it. Other tools such as ASAN have much lower overhead.
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Dec 8, 2022
Currently dmalloc is disabled because of a stray print from GN combined with a strict comparison of GN's output in configuring this checker. This caused tests to timeout and fail in a previous attempt to remove the print in project-chip#23687. This checker is extremely expensive, especially for tests with more allocations. For one test, it increases the cost from 1 second to 1 hour: % time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 3325.35s user 0.05s system 99% cpu 55:25.65 total % time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 1.24s user 0.01s system 99% cpu 1.249 total This is much too costly to be enabled for all unit tests in presubmit, so disable it. Other tools such as ASAN have much lower overhead.
mspang
added a commit
to mspang/connectedhomeip
that referenced
this pull request
Dec 8, 2022
Currently dmalloc is disabled because of a stray print from GN combined with a strict comparison of GN's output in configuring this checker. This caused tests to timeout and fail in a previous attempt to remove the print in project-chip#23687. This checker is extremely expensive, especially for tests with more allocations. For one test, it increases the cost from 1 second to 1 hour: % time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 3325.35s user 0.05s system 99% cpu 55:25.65 total % unset DMALLOC_OPTIONS % time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 1.24s user 0.01s system 99% cpu 1.249 total This is much too costly to be enabled for all unit tests in presubmit, so disable it. Other tools such as ASAN have much lower overhead.
andy31415
pushed a commit
that referenced
this pull request
Dec 8, 2022
Currently dmalloc is disabled because of a stray print from GN combined with a strict comparison of GN's output in configuring this checker. This caused tests to timeout and fail in a previous attempt to remove the print in #23687. This checker is extremely expensive, especially for tests with more allocations. For one test, it increases the cost from 1 second to 1 hour: % time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 3325.35s user 0.05s system 99% cpu 55:25.65 total % unset DMALLOC_OPTIONS % time ./out/tests/TestCommissionerDUTVectors ./out/tests/TestCommissionerDUTVectors 1.24s user 0.01s system 99% cpu 1.249 total This is much too costly to be enabled for all unit tests in presubmit, so disable it. Other tools such as ASAN have much lower overhead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need non-fatal diagnostics to not be printed by default during builds, since that just makes logs noisy.
Deleting a message about input matter IDL detection.