-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[darwin-framework-tool] Propagate chip_inet_config_enable_ipv4 to chi… #23683
Merged
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFrameworkTool_chip_inet_config_enable_ipv4
Dec 9, 2022
Merged
[darwin-framework-tool] Propagate chip_inet_config_enable_ipv4 to chi… #23683
andy31415
merged 1 commit into
project-chip:master
from
vivien-apple:DarwinFrameworkTool_chip_inet_config_enable_ipv4
Dec 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
rgoliver and
saurabhst
November 18, 2022 15:35
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 18, 2022 15:35
PR #23683: Size comparison from 287c1b5 to 39d7c14 Increases (8 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (8 builds for cc13x2_26x2, esp32, k32w, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Nov 18, 2022
The darwin test suites is failing since this PR relies on #23683 (otherwise |
PR #23683: Size comparison from 7d786d0 to 86887e9 Increases (3 builds for cc13x2_26x2, esp32, psoc6)
Decreases (14 builds for bl602, bl702, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg, telink)
Full report (50 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 30, 2022
vivien-apple
force-pushed
the
DarwinFrameworkTool_chip_inet_config_enable_ipv4
branch
from
December 2, 2022 19:43
86887e9
to
47789a6
Compare
pullapprove
bot
requested review from
lpbeliveau-silabs
and removed request for
wbschiller
December 2, 2022 19:44
vivien-apple
force-pushed
the
DarwinFrameworkTool_chip_inet_config_enable_ipv4
branch
from
December 2, 2022 19:44
47789a6
to
85b5ffd
Compare
PR #23683: Size comparison from 85aa144 to 85b5ffd Increases (5 builds for cc13x2_26x2, esp32, psoc6, qpg)
Decreases (8 builds for bl702, esp32, k32w, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…p_xcode_build_connector.sh
vivien-apple
force-pushed
the
DarwinFrameworkTool_chip_inet_config_enable_ipv4
branch
from
December 5, 2022 10:29
85b5ffd
to
d98c371
Compare
PR #23683: Size comparison from 9c0ca13 to d98c371 Increases (9 builds for bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (3 builds for cc13x2_26x2, esp32, psoc6)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…p_xcode_build_connector.sh
Running
./scripts/examples/gn_build_example.sh examples/darwin-framework-tool out/debug/standalone chip_inet_config_enable_ipv4=false
does not produce the expected results since the options is passed to the Matter SDK copy that is built fordarwin-framework-tool
not for theMatter.framework
.This PR propagates the flag to
chip_xcode_build_connector.sh
and is meant to be on top of #23682 (this is why there are some checks related toconfig_enable_yaml_tests
).