[minimal mDNS] Fix sending mDNS goodbye packets #23661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy31415
reviewed
Nov 17, 2022
andy31415
approved these changes
Nov 17, 2022
|
PR #23661: Size comparison from a45cf79 to 329d109 Increases (7 builds for bl602, psoc6, telink)
Decreases (5 builds for bl702, nrfconnect, psoc6, telink)
Full report (24 builds for bl602, bl702, cyw30739, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
force-pushed
the
mdns-goodbye
branch
from
329d109
to
54ef16d
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
msandstedt,
saurabhst and
selissia
pullapprove
bot
requested review from
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
|
PR #23661: Size comparison from b1f48e2 to 54ef16d Increases (10 builds for cc13x2_26x2, esp32, k32w, linux, psoc6, telink)
Decreases (14 builds for cc13x2_26x2, esp32, linux, psoc6)
Full report (47 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Nov 18, 2022
mDNS clients such as avahi would keep stale commissionable node services in their caches because minimal mDNS did not send "Goodbye" packets properly on service removal. That is, it attempted to send records with TTL=0 in Advertise() methods, called after RemoveServices() which clears all allocated responders. It could be reproduce by opening and closing the commissioning window on the device because each open operation regenerates commissionable node service instance name. Signed-off-by: Damian Krolik <[email protected]>
Damian-Nordic
force-pushed
the
mdns-goodbye
branch
from
54ef16d
to
65eda68
Compare
|
PR #23661: Size comparison from 95d337c to 65eda68 Increases (10 builds for bl602, cc13x2_26x2, esp32, linux, psoc6)
Decreases (22 builds for bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
* [minimal mDNS] Fix sending mDNS goodbye packets mDNS clients such as avahi would keep stale commissionable node services in their caches because minimal mDNS did not send "Goodbye" packets properly on service removal. That is, it attempted to send records with TTL=0 in Advertise() methods, called after RemoveServices() which clears all allocated responders. It could be reproduce by opening and closing the commissioning window on the device because each open operation regenerates commissionable node service instance name. Signed-off-by: Damian Krolik <[email protected]> * Code review Signed-off-by: Damian Krolik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mDNS clients such as avahi would keep stale commissionable node services in their caches because minimal mDNS did not send "Goodbye" packets properly on service removal. That is, it attempted to send records with TTL=0 in Advertise() methods, called after RemoveServices() which clears all allocated responders.
It could be reproduce by opening and closing the commissioning window on the device because each open operation regenerates commissionable node service instance name.